From: John Hubbard <jhubbard@nvidia.com>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>, <linux-mm@kvack.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
William Kucharski <william.kucharski@oracle.com>,
Mike Rapoport <rppt@linux.ibm.com>
Subject: Re: [PATCH v2 2/6] mm: Dump compound page information on a second line
Date: Fri, 10 Jul 2020 18:35:28 -0700 [thread overview]
Message-ID: <a9297aeb-cff9-a222-97b7-8eb9ae1fc956@nvidia.com> (raw)
In-Reply-To: <20200709202117.7216-3-willy@infradead.org>
On 2020-07-09 13:21, Matthew Wilcox (Oracle) wrote:
> Simplify both the implementation and the output by splitting all the
> compound page information onto a second line.
>
> Reported-by: John Hubbard <jhubbard@nvidia.com>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> ---
> mm/debug.c | 30 ++++++++++++------------------
> 1 file changed, 12 insertions(+), 18 deletions(-)
>
Yes, looks good and is working nicely for me, too.
Reviewed-by: John Hubbard <jhubbard@nvidia.com>
thanks,
--
John Hubbard
NVIDIA
> diff --git a/mm/debug.c b/mm/debug.c
> index e5de63406b59..f35c1ae1a7a5 100644
> --- a/mm/debug.c
> +++ b/mm/debug.c
> @@ -89,27 +89,21 @@ void __dump_page(struct page *page, const char *reason)
> */
> mapcount = PageSlab(head) ? 0 : page_mapcount(page);
>
> - if (compound)
> + pr_warn("page:%px refcount:%d mapcount:%d mapping:%p index:%#lx\n",
> + page, page_ref_count(head), mapcount, mapping,
> + page_to_pgoff(page));
> + if (compound) {
> if (hpage_pincount_available(page)) {
> - pr_warn("page:%px refcount:%d mapcount:%d mapping:%p "
> - "index:%#lx head:%px order:%u "
> - "compound_mapcount:%d compound_pincount:%d\n",
> - page, page_ref_count(head), mapcount,
> - mapping, page_to_pgoff(page), head,
> - compound_order(head), compound_mapcount(page),
> - compound_pincount(page));
> + pr_warn("head:%px order:%u compound_mapcount:%d compound_pincount:%d\n",
> + head, compound_order(head),
> + compound_mapcount(head),
> + compound_pincount(head));
> } else {
> - pr_warn("page:%px refcount:%d mapcount:%d mapping:%p "
> - "index:%#lx head:%px order:%u "
> - "compound_mapcount:%d\n",
> - page, page_ref_count(head), mapcount,
> - mapping, page_to_pgoff(page), head,
> - compound_order(head), compound_mapcount(page));
> + pr_warn("head:%px order:%u compound_mapcount:%d\n",
> + head, compound_order(head),
> + compound_mapcount(head));
> }
> - else
> - pr_warn("page:%px refcount:%d mapcount:%d mapping:%p index:%#lx\n",
> - page, page_ref_count(page), mapcount,
> - mapping, page_to_pgoff(page));
> + }
> if (PageKsm(page))
> type = "ksm ";
> else if (PageAnon(page))
>
next prev parent reply other threads:[~2020-07-11 1:35 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 20:21 [PATCH v2 0/6] Improvements for dump_page() Matthew Wilcox (Oracle)
2020-07-09 20:21 ` [PATCH v2 1/6] mm: Handle page->mapping better in dump_page Matthew Wilcox (Oracle)
2020-07-11 1:30 ` John Hubbard
2020-07-11 1:32 ` John Hubbard
2020-07-14 11:06 ` Vlastimil Babka
2020-07-09 20:21 ` [PATCH v2 2/6] mm: Dump compound page information on a second line Matthew Wilcox (Oracle)
2020-07-11 1:35 ` John Hubbard [this message]
2020-07-14 12:03 ` Vlastimil Babka
2020-08-04 15:37 ` Qian Cai
2020-08-04 16:14 ` Matthew Wilcox
2020-08-04 18:39 ` [PATCH] mm, dump_page: do not crash with bad compound_page() John Hubbard
2020-08-04 18:48 ` Matthew Wilcox
2020-08-04 19:17 ` John Hubbard
2020-08-04 19:42 ` Matthew Wilcox
2020-07-09 20:21 ` [PATCH v2 3/6] mm: Print head flags in dump_page Matthew Wilcox (Oracle)
2020-07-11 1:40 ` John Hubbard
2020-07-14 12:06 ` Vlastimil Babka
2020-07-09 20:21 ` [PATCH v2 4/6] mm: Switch dump_page to get_kernel_nofault Matthew Wilcox (Oracle)
2020-07-14 12:11 ` Vlastimil Babka
2020-07-09 20:21 ` [PATCH v2 5/6] mm: Print the inode number in dump_page Matthew Wilcox (Oracle)
2020-07-11 2:04 ` John Hubbard
2020-07-14 12:18 ` Vlastimil Babka
2020-07-09 20:21 ` [PATCH v2 6/6] mm: Print hashed address of struct page Matthew Wilcox (Oracle)
2020-07-11 1:48 ` John Hubbard
2020-07-09 20:54 ` [PATCH v2 0/6] Improvements for dump_page() Mike Rapoport
2020-07-09 20:54 ` William Kucharski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9297aeb-cff9-a222-97b7-8eb9ae1fc956@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=kirill@shutemov.name \
--cc=linux-mm@kvack.org \
--cc=rppt@linux.ibm.com \
--cc=vbabka@suse.cz \
--cc=william.kucharski@oracle.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).