From: Miaohe Lin <linmiaohe@huawei.com>
To: Wan Jiabing <wanjiabing@vivo.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: <kael_w@yeah.net>, <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: process_vm_access: Remove duplicate include of compat.h
Date: Tue, 23 Mar 2021 14:33:14 +0800 [thread overview]
Message-ID: <a96d8bf1-292f-a239-fc31-1022c7c4a296@huawei.com> (raw)
In-Reply-To: <20210323032322.262579-1-wanjiabing@vivo.com>
On 2021/3/23 11:23, Wan Jiabing wrote:
> linux/compat.h has been included at line 8.So we remove
> the duplicate one at line 12.
>
line 12 one is added via eb351d75ce1e ("mm/process_vm_access.c: include compat.h") to fix the build error:
mm/process_vm_access.c:277:5: error: implicit declaration of function 'in_compat_syscall'; did you mean 'in_ia32_syscall'? [-Werror=implicit-function-declaration]
There might be something wrong.
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> mm/process_vm_access.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mm/process_vm_access.c b/mm/process_vm_access.c
> index f5fee9cf90f8..4bcc11958089 100644
> --- a/mm/process_vm_access.c
> +++ b/mm/process_vm_access.c
> @@ -9,7 +9,6 @@
> #include <linux/mm.h>
> #include <linux/uio.h>
> #include <linux/sched.h>
> -#include <linux/compat.h>
> #include <linux/sched/mm.h>
> #include <linux/highmem.h>
> #include <linux/ptrace.h>
>
prev parent reply other threads:[~2021-03-23 6:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 3:23 [PATCH] mm: process_vm_access: Remove duplicate include of compat.h Wan Jiabing
2021-03-23 6:33 ` Miaohe Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a96d8bf1-292f-a239-fc31-1022c7c4a296@huawei.com \
--to=linmiaohe@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=kael_w@yeah.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=wanjiabing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).