linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: Yang Shi <shy828301@gmail.com>,
	Dave Hansen <dave.hansen@linux.intel.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux MM <linux-mm@kvack.org>,
	Yang Shi <yang.shi@linux.alibaba.com>,
	David Rientjes <rientjes@google.com>,
	Huang Ying <ying.huang@intel.com>,
	Dan Williams <dan.j.williams@intel.com>,
	David Hildenbrand <david@redhat.com>,
	Oscar Salvador <osalvador@suse.de>
Subject: Re: [PATCH 03/10] mm/migrate: update node demotion order during on hotplug events
Date: Tue, 9 Mar 2021 14:07:44 -0800	[thread overview]
Message-ID: <aafc39d0-a002-f851-7da8-cf768ebe691d@intel.com> (raw)
In-Reply-To: <CAHbLzkqHHh2BK6BYW2kKnBjZcVKdmM+z-+0ij9HS0t73Xi8r1w@mail.gmail.com>

On 3/8/21 4:03 PM, Yang Shi wrote:
>> +static int __meminit migrate_on_reclaim_callback(struct notifier_block *self,
>> +                                                unsigned long action, void *arg)
>> +{
>> +       switch (action) {
>> +       case MEM_GOING_OFFLINE:
>> +               /*
>> +                * Make sure there are not transient states where
>> +                * an offline node is a migration target.  This
>> +                * will leave migration disabled until the offline
>> +                * completes and the MEM_OFFLINE case below runs.
>> +                */
>> +               disable_all_migrate_targets();
>> +
>> +               /*
>> +                * Ensure the disable operation is globally visible.
>> +                * This avoids readers ever being able to
>> +                * simultaneously observe the old (pre-hotplug) and
>> +                * new (post-hotplug) migration targets.
>> +                */
>> +               synchronize_rcu();
> It seems disable_all_migrate_targets() already has synchronize_rcu()
> called. We don't need to call it twice. Otherwise, it looks good to
> me. Reviewed-by: Yang Shi <shy828301@gmail.com>

Thanks for noticing that.  I've fixed it up.




  reply	other threads:[~2021-03-09 22:07 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-04 23:59 [PATCH 00/10] [v6] Migrate Pages in lieu of discard Dave Hansen
2021-03-04 23:59 ` [PATCH 01/10] mm/numa: node demotion data structure and lookup Dave Hansen
2021-03-08 23:58   ` Yang Shi
2021-03-04 23:59 ` [PATCH 02/10] mm/numa: automatically generate node migration order Dave Hansen
2021-03-08 23:59   ` Yang Shi
2021-03-04 23:59 ` [PATCH 03/10] mm/migrate: update node demotion order during on hotplug events Dave Hansen
2021-03-09  0:03   ` Yang Shi
2021-03-09 22:07     ` Dave Hansen [this message]
2021-03-04 23:59 ` [PATCH 04/10] mm/migrate: make migrate_pages() return nr_succeeded Dave Hansen
2021-03-09  0:05   ` Yang Shi
2021-03-04 23:59 ` [PATCH 05/10] mm/migrate: demote pages during reclaim Dave Hansen
2021-03-09  0:10   ` Yang Shi
2021-03-09 23:05     ` Dave Hansen
2021-03-05  0:00 ` [PATCH 06/10] mm/vmscan: add page demotion counter Dave Hansen
2021-03-09  0:11   ` Yang Shi
2021-03-05  0:00 ` [PATCH 07/10] mm/vmscan: add helper for querying ability to age anonymous pages Dave Hansen
2021-03-09  0:14   ` Yang Shi
2021-03-20  4:05   ` Greg Thelen
2021-03-05  0:00 ` [PATCH 08/10] mm/vmscan: Consider anonymous pages without swap Dave Hansen
2021-03-09  0:17   ` Yang Shi
2021-03-09 23:08     ` Dave Hansen
2021-03-05  0:00 ` [PATCH 09/10] mm/vmscan: never demote for memcg reclaim Dave Hansen
2021-03-09  0:17   ` Yang Shi
2021-03-05  0:00 ` [PATCH 10/10] mm/migrate: new zone_reclaim_mode to enable reclaim migration Dave Hansen
2021-03-09  0:24   ` Yang Shi
2021-03-09 21:53     ` Dave Hansen
2021-03-09  0:34 ` [PATCH 00/10] [v6] Migrate Pages in lieu of discard Yang Shi
2021-03-09 21:52   ` Dave Hansen
2021-04-01 18:32 [PATCH 00/10] [v7][RESEND] " Dave Hansen
2021-04-01 18:32 ` [PATCH 03/10] mm/migrate: update node demotion order during on hotplug events Dave Hansen
2021-04-08  9:52   ` Oscar Salvador
2021-04-09 10:14     ` Oscar Salvador
2021-04-09 10:15       ` Oscar Salvador
2021-04-09 18:59       ` David Hildenbrand
2021-04-12  7:19         ` Oscar Salvador
2021-04-12  9:19           ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aafc39d0-a002-f851-7da8-cf768ebe691d@intel.com \
    --to=dave.hansen@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=david@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=osalvador@suse.de \
    --cc=rientjes@google.com \
    --cc=shy828301@gmail.com \
    --cc=yang.shi@linux.alibaba.com \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).