* [PATCH v2] mm/slub: fix help comment of SLUB_DEBUG
@ 2023-03-14 7:16 Vernon Yang
2023-03-17 11:04 ` Vlastimil Babka
0 siblings, 1 reply; 2+ messages in thread
From: Vernon Yang @ 2023-03-14 7:16 UTC (permalink / raw)
To: akpm, vbabka, 42.hyeyoo; +Cc: linux-mm, linux-kernel, Vernon Yang
Since commit ab4d5ed5eeda ("slub: Enable sysfs support for
!CONFIG_SLUB_DEBUG"), disabling SLUB_DEBUG also disables
SLUB sysfs support that is not true anymore, so fix it correctly.
Signed-off-by: Vernon Yang <vernon2gm@gmail.com>
---
mm/Kconfig.debug | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/mm/Kconfig.debug b/mm/Kconfig.debug
index c3547a373c9c..9a90a88ce053 100644
--- a/mm/Kconfig.debug
+++ b/mm/Kconfig.debug
@@ -60,9 +60,8 @@ config SLUB_DEBUG
select STACKDEPOT if STACKTRACE_SUPPORT
help
SLUB has extensive debug support features. Disabling these can
- result in significant savings in code size. This also disables
- SLUB sysfs support. /sys/slab will not exist and there will be
- no support for cache validation etc.
+ result in significant savings in code size, the /sys/kernel/slab
+ will exist but will not provide e.g. cache validation.
config SLUB_DEBUG_ON
bool "SLUB debugging on by default"
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] mm/slub: fix help comment of SLUB_DEBUG
2023-03-14 7:16 [PATCH v2] mm/slub: fix help comment of SLUB_DEBUG Vernon Yang
@ 2023-03-17 11:04 ` Vlastimil Babka
0 siblings, 0 replies; 2+ messages in thread
From: Vlastimil Babka @ 2023-03-17 11:04 UTC (permalink / raw)
To: Vernon Yang, akpm, 42.hyeyoo; +Cc: linux-mm, linux-kernel
On 3/14/23 08:16, Vernon Yang wrote:
> Since commit ab4d5ed5eeda ("slub: Enable sysfs support for
> !CONFIG_SLUB_DEBUG"), disabling SLUB_DEBUG also disables
> SLUB sysfs support that is not true anymore, so fix it correctly.
>
> Signed-off-by: Vernon Yang <vernon2gm@gmail.com>
Thanks, slightly reworded and pushed to slab/for-6.4/trivial
> ---
> mm/Kconfig.debug | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/mm/Kconfig.debug b/mm/Kconfig.debug
> index c3547a373c9c..9a90a88ce053 100644
> --- a/mm/Kconfig.debug
> +++ b/mm/Kconfig.debug
> @@ -60,9 +60,8 @@ config SLUB_DEBUG
> select STACKDEPOT if STACKTRACE_SUPPORT
> help
> SLUB has extensive debug support features. Disabling these can
> - result in significant savings in code size. This also disables
> - SLUB sysfs support. /sys/slab will not exist and there will be
> - no support for cache validation etc.
> + result in significant savings in code size, the /sys/kernel/slab
> + will exist but will not provide e.g. cache validation.
>
> config SLUB_DEBUG_ON
> bool "SLUB debugging on by default"
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-17 11:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-14 7:16 [PATCH v2] mm/slub: fix help comment of SLUB_DEBUG Vernon Yang
2023-03-17 11:04 ` Vlastimil Babka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).