From: Christopher Lameter <cl@linux.com>
To: Vijayanand Jitta <vjitta@codeaurora.org>
Cc: penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.or, vinmenon@codeaurora.org,
kernel-team@android.com
Subject: Re: [PATCH] mm: slub: reinitialize random sequence cache on slab object update
Date: Thu, 30 Jan 2020 18:28:15 +0000 (UTC) [thread overview]
Message-ID: <alpine.DEB.2.21.2001301826130.9861@www.lameter.com> (raw)
In-Reply-To: <1580379523-32272-1-git-send-email-vjitta@codeaurora.org>
On Thu, 30 Jan 2020, vjitta@codeaurora.org wrote:
> Random sequence cache is precomputed during slab object creation
> based up on the object size and no of objects per slab. These could
> be changed when flags like SLAB_STORE_USER, SLAB_POISON are updated
> from sysfs. So when shuffle_freelist is called during slab_alloc it
Sorry no. That cannot happen. Changing the size of the slab is only
possible if no slab pages are allocated. Any sysfs changes that affect the
object size must fail if object and slab pages are already allocated.
If you were able to change the object size then we need to prevent that
from happening.
next prev parent reply other threads:[~2020-01-30 18:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 10:18 [PATCH] mm: slub: reinitialize random sequence cache on slab object update vjitta
2020-01-30 11:17 ` vjitta
2020-02-27 16:53 ` Vlastimil Babka
2020-03-05 5:48 ` vjitta
2020-03-05 12:40 ` Vlastimil Babka
2020-01-30 18:28 ` Christopher Lameter [this message]
2020-01-31 6:39 ` Vijayanand Jitta
2020-02-03 6:57 ` Vijayanand Jitta
2020-02-20 5:12 ` vjitta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2001301826130.9861@www.lameter.com \
--to=cl@linux.com \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.or \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=vinmenon@codeaurora.org \
--cc=vjitta@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).