Re: [PATCH] ramfs: fix mount source show for ramfs

[yangerkun <yangerkun@huawei.com>]

在 2021/9/9 6:39, Andrew Morton 写道:
> On Wed, 8 Sep 2021 16:56:25 +0800 yangerkun <yangerkun@huawei.com> wrote:
> 
>> 在 2021/8/11 20:28, yangerkun 写道:
>>> ramfs_parse_param does not parse key "source", and will convert
>>> -ENOPARAM to 0. This will skip vfs_parse_fs_param_source in
>>> vfs_parse_fs_param, which lead always "none" mount source for ramfs. Fix
>>> it by parse "source" in ramfs_parse_param.
>>>
>>> Signed-off-by: yangerkun <yangerkun@huawei.com>
>>> ---
>>>    fs/ramfs/inode.c | 4 ++++
>>>    1 file changed, 4 insertions(+)
>>>
>>> diff --git a/fs/ramfs/inode.c b/fs/ramfs/inode.c
>>> index 65e7e56005b8..0d7f5f655fd8 100644
>>> --- a/fs/ramfs/inode.c
>>> +++ b/fs/ramfs/inode.c
>>> @@ -202,6 +202,10 @@ static int ramfs_parse_param(struct fs_context *fc, struct fs_parameter *param)
>>>    	struct ramfs_fs_info *fsi = fc->s_fs_info;
>>>    	int opt;
>>>    
>>> +	opt = vfs_parse_fs_param_source(fc, param);
>>> +	if (opt != -ENOPARAM)
>>> +		return opt;
>>> +
>>>    	opt = fs_parse(fc, ramfs_fs_parameters, param, &result);
>>>    	if (opt < 0) {
>>>    		/*
>>>
> 
> (top-posting repaired)
> 
>> Hi, this patch seems still leave in linux-next, should we pull it to
>> mainline?
> 
> I was hoping for a comment from Al?

Hi, Al,

Can you help to review this patch...

Thanks,
Kun.

> .
>