From: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: dledford@redhat.com, Jann Horn <jannh@google.com>,
linux-rdma@vger.kernel.org,
Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>,
linux-mm@kvack.org, Ira Weiny <ira.weiny@intel.com>
Subject: Re: [PATCH for-rc v1] IB/hfi1: Move cached value of mm into handler
Date: Tue, 3 Nov 2020 08:41:53 -0500 [thread overview]
Message-ID: <be4067af-f491-81f6-39e2-771366f89086@cornelisnetworks.com> (raw)
In-Reply-To: <20201103002239.GI36674@ziepe.ca>
On 11/2/2020 7:22 PM, Jason Gunthorpe wrote:
> On Wed, Oct 28, 2020 at 09:22:43PM -0400, Dennis Dalessandro wrote:
>
>> Will add a Cc for stable once the patch is finalized. I'd like to get
>> some more feedback on this patch especially in the mmu_interval_notifier
>> stuff.
>
> Which mmu_interval_notifier stuff in this patch?
>
> Can you convert this last usage of mmu_notifier in mmu_rb_handler to
> use an interval notifier? I seem to remember thinking it was the right
> thing but too complicated for me to attempt
The call to mmu_interval_notifier_insert() in set_rcvarray_entry()
specifically. Instead of passing the saved mm I changed it to use current.
Yes we may be able to convert to the interval notifier for the rest of
it. I'd rather do that as a separate patch and get this fixed for 5.10
and in the stable kernels and do that as a for-next sort of thing.
-Denny
next prev parent reply other threads:[~2020-11-03 13:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 1:22 [PATCH for-rc v1] IB/hfi1: Move cached value of mm into handler Dennis Dalessandro
2020-11-03 0:22 ` Jason Gunthorpe
2020-11-03 13:41 ` Dennis Dalessandro [this message]
[not found] ` <20201105001245.GG1531489@iweiny-DESK2.sc.intel.com>
2020-11-05 15:17 ` Jason Gunthorpe
2020-11-05 17:13 ` Dennis Dalessandro
2020-11-10 4:36 ` Ira Weiny
2020-11-10 13:45 ` Dennis Dalessandro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be4067af-f491-81f6-39e2-771366f89086@cornelisnetworks.com \
--to=dennis.dalessandro@cornelisnetworks.com \
--cc=dledford@redhat.com \
--cc=ira.weiny@intel.com \
--cc=jannh@google.com \
--cc=jgg@ziepe.ca \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@cornelisnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).