* [PATCH -next] mm, slub: make function parse_slub_debug_flags() static
@ 2020-07-02 15:05 Wei Yongjun
2020-07-02 15:35 ` Vlastimil Babka
2020-07-05 23:14 ` David Rientjes
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2020-07-02 15:05 UTC (permalink / raw)
To: Hulk Robot, Christoph Lameter, Pekka Enberg, David Rientjes,
Joonsoo Kim, Andrew Morton, Vlastimil Babka
Cc: Wei Yongjun, linux-mm
Fix sparse build warning:
mm/slub.c:1267:6: warning:
symbol 'parse_slub_debug_flags' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
mm/slub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/slub.c b/mm/slub.c
index 62d2de56549e..cd260f18e6cb 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -1264,7 +1264,7 @@ static noinline int free_debug_processing(
*
* returns the start of next block if there's any, or NULL
*/
-char *
+static char *
parse_slub_debug_flags(char *str, slab_flags_t *flags, char **slabs, bool init)
{
bool higher_order_disable = false;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] mm, slub: make function parse_slub_debug_flags() static
2020-07-02 15:05 [PATCH -next] mm, slub: make function parse_slub_debug_flags() static Wei Yongjun
@ 2020-07-02 15:35 ` Vlastimil Babka
2020-07-05 23:14 ` David Rientjes
1 sibling, 0 replies; 3+ messages in thread
From: Vlastimil Babka @ 2020-07-02 15:35 UTC (permalink / raw)
To: Wei Yongjun, Hulk Robot, Christoph Lameter, Pekka Enberg,
David Rientjes, Joonsoo Kim, Andrew Morton
Cc: linux-mm
On 7/2/20 5:05 PM, Wei Yongjun wrote:
> Fix sparse build warning:
>
> mm/slub.c:1267:6: warning:
> symbol 'parse_slub_debug_flags' was not declared. Should it be static?
Right, thanks.
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
Could be squashed to mmotm patch:
mm-slub-extend-slub_debug-syntax-for-multiple-blocks.patch
> ---
> mm/slub.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/slub.c b/mm/slub.c
> index 62d2de56549e..cd260f18e6cb 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -1264,7 +1264,7 @@ static noinline int free_debug_processing(
> *
> * returns the start of next block if there's any, or NULL
> */
> -char *
> +static char *
> parse_slub_debug_flags(char *str, slab_flags_t *flags, char **slabs, bool init)
> {
> bool higher_order_disable = false;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] mm, slub: make function parse_slub_debug_flags() static
2020-07-02 15:05 [PATCH -next] mm, slub: make function parse_slub_debug_flags() static Wei Yongjun
2020-07-02 15:35 ` Vlastimil Babka
@ 2020-07-05 23:14 ` David Rientjes
1 sibling, 0 replies; 3+ messages in thread
From: David Rientjes @ 2020-07-05 23:14 UTC (permalink / raw)
To: Wei Yongjun
Cc: Hulk Robot, Christoph Lameter, Pekka Enberg, Joonsoo Kim,
Andrew Morton, Vlastimil Babka, linux-mm
On Thu, 2 Jul 2020, Wei Yongjun wrote:
> Fix sparse build warning:
>
> mm/slub.c:1267:6: warning:
> symbol 'parse_slub_debug_flags' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: David Rientjes <rientjes@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-05 23:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-02 15:05 [PATCH -next] mm, slub: make function parse_slub_debug_flags() static Wei Yongjun
2020-07-02 15:35 ` Vlastimil Babka
2020-07-05 23:14 ` David Rientjes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).