From: David Rientjes <rientjes@google.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Vijayanand Jitta <vjitta@codeaurora.org>,
cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, vinmenon@codeaurora.org
Subject: Re: [PATCH] mm: slub: Fix slub_debug disablement for list of slabs
Date: Sun, 1 Aug 2021 20:26:04 -0700 (PDT) [thread overview]
Message-ID: <c2d6cbbf-8eaa-3198-9b43-73eb5965fb1f@google.com> (raw)
In-Reply-To: <8a3d992a-473a-467b-28a0-4ad2ff60ab82@suse.cz>
On Tue, 27 Jul 2021, Vlastimil Babka wrote:
> From 81a225fe31e53701902bb4caa9ab1524eb044cbc Mon Sep 17 00:00:00 2001
> From: Vlastimil Babka <vbabka@suse.cz>
> Date: Tue, 13 Jul 2021 17:15:50 +0530
> Subject: [PATCH] mm: slub: fix slub_debug disabling for list of slabs
>
> Vijayanand Jitta reports:
>
> Consider the scenario where CONFIG_SLUB_DEBUG_ON is set
> and we would want to disable slub_debug for few slabs.
> Using boot parameter with slub_debug=-,slab_name syntax
> doesn't work as expected i.e; only disabling debugging for
> the specified list of slabs. Instead it disables debugging
> for all slabs, which is wrong.
>
> This patch fixes it by delaying the moment when the global slub_debug flags
> variable is updated. In case a "slub_debug=-,slab_name" has been passed, the
> global flags remain as initialized (depending on CONFIG_SLUB_DEBUG_ON enabled
> or disabled) and are not simply reset to 0.
>
> Reported-by: Vijayanand Jitta <vjitta@codeaurora.org>
> Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
> Reviewed-by: Vijayanand Jitta <vjitta@codeaurora.org>
Acked-by: David Rientjes <rientjes@google.com>
Looks better, thanks!
prev parent reply other threads:[~2021-08-02 3:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 11:45 [PATCH] mm: slub: Fix slub_debug disablement for list of slabs vjitta
2021-07-19 6:21 ` David Rientjes
2021-07-20 6:35 ` Vijayanand Jitta
2021-07-26 22:32 ` Vlastimil Babka
2021-07-27 4:43 ` Vijayanand Jitta
2021-07-27 12:22 ` Vlastimil Babka
2021-08-02 3:26 ` David Rientjes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2d6cbbf-8eaa-3198-9b43-73eb5965fb1f@google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=vbabka@suse.cz \
--cc=vinmenon@codeaurora.org \
--cc=vjitta@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).