* [PATCH -next] lib: fix test_hmm.c reference after free
@ 2020-06-18 5:31 Randy Dunlap
2020-06-18 16:21 ` Ralph Campbell
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2020-06-18 5:31 UTC (permalink / raw)
To: LKML, Andrew Morton, Linux MM; +Cc: Jérôme Glisse, Ralph Campbell
From: Randy Dunlap <rdunlap@infradead.org>
Coccinelle scripts report the following errors:
lib/test_hmm.c:523:20-26: ERROR: reference preceded by free on line 521
lib/test_hmm.c:524:21-27: ERROR: reference preceded by free on line 521
lib/test_hmm.c:523:28-35: ERROR: devmem is NULL but dereferenced.
lib/test_hmm.c:524:29-36: ERROR: devmem is NULL but dereferenced.
Fix these by using the local variable 'res' instead of devmem.
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Jérôme Glisse <jglisse@redhat.com>
Cc: linux-mm@kvack.org
Cc: Ralph Campbell <rcampbell@nvidia.com>
---
lib/test_hmm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- linux-next-20200617.orig/lib/test_hmm.c
+++ linux-next-20200617/lib/test_hmm.c
@@ -520,8 +520,7 @@ static bool dmirror_allocate_chunk(struc
err_free:
kfree(devmem);
err_release:
- release_mem_region(devmem->pagemap.res.start,
- resource_size(&devmem->pagemap.res));
+ release_mem_region(res->start, resource_size(res));
err:
mutex_unlock(&mdevice->devmem_lock);
return false;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] lib: fix test_hmm.c reference after free
2020-06-18 5:31 [PATCH -next] lib: fix test_hmm.c reference after free Randy Dunlap
@ 2020-06-18 16:21 ` Ralph Campbell
0 siblings, 0 replies; 2+ messages in thread
From: Ralph Campbell @ 2020-06-18 16:21 UTC (permalink / raw)
To: Randy Dunlap, LKML, Andrew Morton, Linux MM; +Cc: Jérôme Glisse
On 6/17/20 10:31 PM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Coccinelle scripts report the following errors:
>
> lib/test_hmm.c:523:20-26: ERROR: reference preceded by free on line 521
> lib/test_hmm.c:524:21-27: ERROR: reference preceded by free on line 521
> lib/test_hmm.c:523:28-35: ERROR: devmem is NULL but dereferenced.
> lib/test_hmm.c:524:29-36: ERROR: devmem is NULL but dereferenced.
>
> Fix these by using the local variable 'res' instead of devmem.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Jérôme Glisse <jglisse@redhat.com>
> Cc: linux-mm@kvack.org
> Cc: Ralph Campbell <rcampbell@nvidia.com>
> ---
> lib/test_hmm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> --- linux-next-20200617.orig/lib/test_hmm.c
> +++ linux-next-20200617/lib/test_hmm.c
> @@ -520,8 +520,7 @@ static bool dmirror_allocate_chunk(struc
> err_free:
> kfree(devmem);
> err_release:
> - release_mem_region(devmem->pagemap.res.start,
> - resource_size(&devmem->pagemap.res));
> + release_mem_region(res->start, resource_size(res));
> err:
> mutex_unlock(&mdevice->devmem_lock);
> return false;
>
Thanks for fixing this!
Reviewed-by: Ralph Campbell <rcampbell@nvidia.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-18 16:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-18 5:31 [PATCH -next] lib: fix test_hmm.c reference after free Randy Dunlap
2020-06-18 16:21 ` Ralph Campbell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).