From: Dave Hansen <dave.hansen@intel.com>
To: Matthew Wilcox <willy@infradead.org>, Marc Orr <marcorr@google.com>
Cc: kvm@vger.kernel.org, jmattson@google.com, rientjes@google.com,
konrad.wilk@oracle.com, linux-mm@kvack.org,
akpm@linux-foundation.org, pbonzini@redhat.com,
rkrcmar@redhat.com, sean.j.christopherson@intel.com,
Dave Hansen <dave.hansen@linux.intel.com>
Subject: Re: [kvm PATCH v4 0/2] use vmalloc to allocate vmx vcpus
Date: Fri, 26 Oct 2018 07:49:09 -0700 [thread overview]
Message-ID: <cd9934d3-2699-d705-9e66-88485fc74ead@intel.com> (raw)
In-Reply-To: <20181026144528.GS25444@bombadil.infradead.org>
On 10/26/18 7:45 AM, Matthew Wilcox wrote:
> struct fpu user_fpu; /* 2176 4160 */
> struct fpu guest_fpu; /* 6336 4160 */
Those are *not* supposed to be embedded in any other structures. My bad
for not documenting this better.
It also seems really goofy that we need an xsave buffer in the
task_struct for user fpu state, then another in the vcpu. Isn't one for
user state enough?
In any case, I'd suggest getting rid of 'user_fpu', then either moving
'guest_fpu' to the bottom of the structure, or just make it a 'struct
fpu *' and dynamically allocating it separately.
To do this, I'd take fpu__init_task_struct_size(), and break it apart a
bit to tell you the size of the 'struct fpu' separately from the size of
the 'task struct'.
next prev parent reply other threads:[~2018-10-26 14:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 7:58 [kvm PATCH v4 0/2] use vmalloc to allocate vmx vcpus Marc Orr
2018-10-26 7:58 ` [kvm PATCH v4 1/2] kvm: vmx: refactor vmx_msrs struct for vmalloc Marc Orr
2018-10-26 11:02 ` Sean Christopherson
2018-10-26 7:59 ` [kvm PATCH v4 2/2] kvm: vmx: use vmalloc() to allocate vcpus Marc Orr
2018-10-26 12:29 ` [kvm PATCH v4 0/2] use vmalloc to allocate vmx vcpus Matthew Wilcox
2018-10-26 14:45 ` Matthew Wilcox
2018-10-26 14:49 ` Dave Hansen [this message]
2018-10-31 13:06 ` Marc Orr
2018-10-29 1:58 ` Wanpeng Li
2018-10-29 16:25 ` Jim Mattson
2018-10-29 16:48 ` Matthew Wilcox
2018-10-29 18:12 ` Jim Mattson
2018-10-29 19:16 ` Marc Orr
2018-10-29 19:22 ` Marc Orr
2018-10-31 13:17 ` Marc Orr
2018-10-31 13:27 ` Matthew Wilcox
2018-10-31 13:48 ` Marc Orr
2018-10-31 14:21 ` Matthew Wilcox
2018-10-31 21:19 ` Marc Orr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd9934d3-2699-d705-9e66-88485fc74ead@intel.com \
--to=dave.hansen@intel.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@linux.intel.com \
--cc=jmattson@google.com \
--cc=konrad.wilk@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=marcorr@google.com \
--cc=pbonzini@redhat.com \
--cc=rientjes@google.com \
--cc=rkrcmar@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).