From: Vlastimil Babka <vbabka@suse.cz>
To: Michal Hocko <mhocko@kernel.org>, linux-mm@kvack.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>,
Johannes Weiner <hannes@cmpxchg.org>,
LKML <linux-kernel@vger.kernel.org>,
Michal Hocko <mhocko@suse.com>,
Wen Congyang <wency@cn.fujitsu.com>
Subject: Re: [PATCH 4/9] mm, memory_hotplug: drop zone from build_all_zonelists
Date: Wed, 19 Jul 2017 15:33:32 +0200 [thread overview]
Message-ID: <d32539e9-8ac3-7536-a205-8953d436b301@suse.cz> (raw)
In-Reply-To: <20170714080006.7250-5-mhocko@kernel.org>
On 07/14/2017 10:00 AM, Michal Hocko wrote:
> From: Michal Hocko <mhocko@suse.com>
>
> build_all_zonelists gets a zone parameter to initialize zone's
> pagesets. There is only a single user which gives a non-NULL
> zone parameter and that one doesn't really need the rest of the
> build_all_zonelists (see 6dcd73d7011b ("memory-hotplug: allocate zone's
> pcp before onlining pages")).
>
> Therefore remove setup_zone_pageset from build_all_zonelists and call it
> from its only user directly. This will also remove a pointless zonlists
> rebuilding which is always good.
>
> Cc: Wen Congyang <wency@cn.fujitsu.com>
> Signed-off-by: Michal Hocko <mhocko@suse.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
with a small point below
...
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index ebc3311555b1..00e117922b3f 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -5065,7 +5065,6 @@ static void build_zonelists(pg_data_t *pgdat)
> static void setup_pageset(struct per_cpu_pageset *p, unsigned long batch);
> static DEFINE_PER_CPU(struct per_cpu_pageset, boot_pageset);
> static DEFINE_PER_CPU(struct per_cpu_nodestat, boot_nodestats);
> -static void setup_zone_pageset(struct zone *zone);
>
> /*
> * Global mutex to protect against size modification of zonelists
> @@ -5146,19 +5145,14 @@ build_all_zonelists_init(void)
> * unless system_state == SYSTEM_BOOTING.
> *
> * __ref due to (1) call of __meminit annotated setup_zone_pageset
Isn't the whole (1) in the comment invalid now?
> - * [we're only called with non-NULL zone through __meminit paths] and
> - * (2) call of __init annotated helper build_all_zonelists_init
> + * and (2) call of __init annotated helper build_all_zonelists_init
> * [protected by SYSTEM_BOOTING].
> */
> -void __ref build_all_zonelists(pg_data_t *pgdat, struct zone *zone)
> +void __ref build_all_zonelists(pg_data_t *pgdat)
> {
> if (system_state == SYSTEM_BOOTING) {
> build_all_zonelists_init();
> } else {
> -#ifdef CONFIG_MEMORY_HOTPLUG
> - if (zone)
> - setup_zone_pageset(zone);
> -#endif
> /* we have to stop all cpus to guarantee there is no user
> of zonelist */
> stop_machine_cpuslocked(__build_all_zonelists, pgdat, NULL);
> @@ -5432,7 +5426,7 @@ static void __meminit zone_pageset_init(struct zone *zone, int cpu)
> pageset_set_high_and_batch(zone, pcp);
> }
>
> -static void __meminit setup_zone_pageset(struct zone *zone)
> +void __meminit setup_zone_pageset(struct zone *zone)
> {
> int cpu;
> zone->pageset = alloc_percpu(struct per_cpu_pageset);
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-07-19 13:33 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-14 7:59 [PATCH 0/9] cleanup zonelists initialization Michal Hocko
2017-07-14 7:59 ` [PATCH 1/9] mm, page_alloc: rip out ZONELIST_ORDER_ZONE Michal Hocko
2017-07-14 9:36 ` Mel Gorman
2017-07-14 10:47 ` Michal Hocko
2017-07-14 11:16 ` Mel Gorman
2017-07-14 11:38 ` Michal Hocko
2017-07-14 12:56 ` Mel Gorman
2017-07-14 13:01 ` Mel Gorman
2017-07-14 13:08 ` Michal Hocko
2017-07-19 9:33 ` Vlastimil Babka
2017-07-19 13:44 ` Michal Hocko
2017-07-14 7:59 ` [PATCH 2/9] mm, page_alloc: remove boot pageset initialization from memory hotplug Michal Hocko
2017-07-14 9:39 ` Mel Gorman
2017-07-19 13:15 ` Vlastimil Babka
2017-07-14 8:00 ` [PATCH 3/9] mm, page_alloc: do not set_cpu_numa_mem on empty nodes initialization Michal Hocko
2017-07-14 9:48 ` Mel Gorman
2017-07-14 10:50 ` Michal Hocko
2017-07-14 12:32 ` Mel Gorman
2017-07-14 12:39 ` Michal Hocko
2017-07-14 12:56 ` Mel Gorman
2017-07-19 13:19 ` Vlastimil Babka
2017-07-14 8:00 ` [PATCH 4/9] mm, memory_hotplug: drop zone from build_all_zonelists Michal Hocko
2017-07-19 13:33 ` Vlastimil Babka [this message]
2017-07-20 8:15 ` Michal Hocko
2017-07-14 8:00 ` [PATCH 5/9] mm, memory_hotplug: remove explicit build_all_zonelists from try_online_node Michal Hocko
2017-07-14 12:14 ` Michal Hocko
2017-07-20 6:13 ` Vlastimil Babka
2017-07-14 8:00 ` [PATCH 6/9] mm, page_alloc: simplify zonelist initialization Michal Hocko
2017-07-14 9:55 ` Mel Gorman
2017-07-14 10:51 ` Michal Hocko
2017-07-14 12:46 ` Mel Gorman
2017-07-14 13:02 ` Michal Hocko
2017-07-14 14:18 ` Mel Gorman
2017-07-17 6:06 ` Michal Hocko
2017-07-17 8:07 ` Mel Gorman
2017-07-17 8:19 ` Michal Hocko
2017-07-17 8:58 ` Mel Gorman
2017-07-17 9:15 ` Michal Hocko
2017-07-20 6:55 ` Vlastimil Babka
2017-07-20 7:19 ` Michal Hocko
2017-07-14 8:00 ` [PATCH 7/9] mm, page_alloc: remove stop_machine from build_all_zonelists Michal Hocko
2017-07-14 9:59 ` Mel Gorman
2017-07-14 11:00 ` Michal Hocko
2017-07-14 12:47 ` Mel Gorman
2017-07-14 11:29 ` Vlastimil Babka
2017-07-14 11:43 ` Michal Hocko
2017-07-14 11:45 ` Michal Hocko
2017-07-20 6:16 ` Vlastimil Babka
2017-07-20 7:24 ` Vlastimil Babka
2017-07-20 9:21 ` Michal Hocko
2017-07-14 8:00 ` [PATCH 8/9] mm, memory_hotplug: get rid of zonelists_mutex Michal Hocko
2017-07-14 8:00 ` [PATCH 9/9] mm, sparse, page_ext: drop ugly N_HIGH_MEMORY branches for allocations Michal Hocko
2017-07-20 8:04 ` Vlastimil Babka
2017-07-21 14:39 [PATCH -v1 0/9] cleanup zonelists initialization Michal Hocko
2017-07-21 14:39 ` [PATCH 4/9] mm, memory_hotplug: drop zone from build_all_zonelists Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d32539e9-8ac3-7536-a205-8953d436b301@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=wency@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).