From: Alexander Duyck <alexander.h.duyck@linux.intel.com>
To: akpm@linux-foundation.org, mgorman@techsingularity.net, david@redhat.com
Cc: yang.zhang.wz@gmail.com, nitesh@redhat.com,
konrad.wilk@oracle.com, pagupta@redhat.com, riel@surriel.com,
lcapitulino@redhat.com, dave.hansen@intel.com,
wei.w.wang@intel.com, aarcange@redhat.com, pbonzini@redhat.com,
dan.j.williams@intel.com, osalvador@suse.de, vbabka@suse.cz,
AlexanderDuyck <alexander.duyck@gmail.com>,
kvm@vger.kernel.org, mst@redhat.com,
linux-kernel@vger.kernel.org, willy@infradead.org,
mhocko@kernel.org, linux-mm@kvack.org
Subject: Should I repost? (was: Re: [PATCH v16.1 0/9] mm / virtio: Provide support for free page reporting)
Date: Mon, 10 Feb 2020 11:18:59 -0800 [thread overview]
Message-ID: <d943ada56babfbebf408ad0f94988a5b09d2b472.camel@linux.intel.com> (raw)
In-Reply-To: <6758b1e3373fc06b37af1c87901237974d52322f.camel@linux.intel.com>
On Mon, 2020-02-03 at 14:05 -0800, Alexander Duyck wrote:
> On Wed, 2020-01-22 at 09:43 -0800, Alexander Duyck wrote:
> > This series provides an asynchronous means of reporting free guest pages
> > to a hypervisor so that the memory associated with those pages can be
> > dropped and reused by other processes and/or guests on the host. Using
> > this it is possible to avoid unnecessary I/O to disk and greatly improve
> > performance in the case of memory overcommit on the host.
>
> <snip>
>
> > A brief history on the background of free page reporting can be found at:
> > https://lore.kernel.org/lkml/29f43d5796feed0dec8e8bb98b187d9dac03b900.camel@linux.intel.com/
> >
> > Changes from v14:
> > https://lore.kernel.org/lkml/20191119214454.24996.66289.stgit@localhost.localdomain/
> > Renamed "unused page reporting" to "free page reporting"
> > Updated code, kconfig, and patch descriptions
> > Split out patch for __free_isolated_page
> > Renamed function to __putback_isolated_page
> > Rewrote core reporting functionality
> > Added logic to reschedule worker in 2 seconds instead of run to completion
> > Removed reported_pages statistics
> > Removed REPORTING_REQUESTED bit used in zone flags
> > Replaced page_reporting_dev_info refcount with state variable
> > Removed scatterlist from page_reporting_dev_info
> > Removed capacity from page reporting device
> > Added dynamic scatterlist allocation/free at start/end of reporting process
> > Updated __free_one_page so that reported pages are not always added to tail
> > Added logic to handle error from report function
> > Updated virtio-balloon patch that adds support for page reporting
> > Updated patch description to try and highlight differences in approaches
> > Updated logic to reflect that we cannot limit the scatterlist from device
> > Added logic to return error from report function
> > Moved documentation patch to end of patch set
> >
> > Changes from v15:
> > https://lore.kernel.org/lkml/20191205161928.19548.41654.stgit@localhost.localdomain/
> > Rebased on linux-next-20191219
> > Split out patches for budget and moving head to last page processed
> > Updated budget code to reduce how much memory is reported per pass
> > Added logic to also rotate the list if we exit due a page isolation failure
> > Added migratetype as argument in __putback_isolated_page
> >
> > Changes from v16:
> > https://lore.kernel.org/lkml/20200103210509.29237.18426.stgit@localhost.localdomain/
> > Rebased on linux-next-20200122
> > Updated patch 2 to to account for removal of pr_info in __isolate_free_page
> > Updated patch title for patches 7, 8, and 9 to use prefix mm/page_reporting
> > No code changes other than conflict resolution for patch 2
>
> So I thought I would put out a gentle nudge since it has been about 4
> weeks since v16 was submitted, a little over a week and a half for v16.1,
> and I have yet to get any feedback on the code contained in the patchset.
> Codewise nothing has changed from the v16 patchset other than rebasing it
> off of the linux-next tree to resolve some merge conflicts that I saw
> recently, and discussion around v16.1 was mostly about next steps and how
> to deal with the page cache instead of discussing the code itself.
>
> The full patchset can be found at:
> https://lore.kernel.org/lkml/20200122173040.6142.39116.stgit@localhost.localdomain/
>
> I believe I still need review feedback for patches 3, 4, 7, 8, and 9.
>
> Thanks.
>
> - Alex
So I had posted this patch set a few days before Linus's merge window
opened. When I posted it the discussion was about what the follow-up on
this patch set will be in terms of putting pressure on the page cache to
force it to shrink. However I didn't get any review comments on the code
itself.
My last understanding on this patch set is that I am waiting on patch
feedback from Mel Gorman as he had the remaining requests that led to most
of the changes in v15 and v16. I believe I have addressed them, but I
don't believe he has had a chance to review them.
I am wondering now if it is still possible to either get it reviewed
and/or applied without reposting, or do I need to repost it since it has
been several weeks since I submitted it? The patch set still applies to
the linux-next tree without any issues.
Thanks.
- Alex
next prev parent reply other threads:[~2020-02-10 19:19 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 17:43 [PATCH v16.1 0/9] mm / virtio: Provide support for free page reporting Alexander Duyck
2020-01-22 17:43 ` [PATCH v16.1 1/9] mm: Adjust shuffle code to allow for future coalescing Alexander Duyck
2020-01-22 17:43 ` [PATCH v16.1 2/9] mm: Use zone and order instead of free area in free_list manipulators Alexander Duyck
2020-01-22 17:43 ` [PATCH v16.1 3/9] mm: Add function __putback_isolated_page Alexander Duyck
2020-01-22 17:43 ` [PATCH v16.1 4/9] mm: Introduce Reported pages Alexander Duyck
2020-01-22 17:43 ` [PATCH v16.1 5/9] virtio-balloon: Pull page poisoning config out of free page hinting Alexander Duyck
2020-01-22 17:43 ` [PATCH v16.1 6/9] virtio-balloon: Add support for providing free page reports to host Alexander Duyck
2020-02-11 11:03 ` David Hildenbrand
2020-02-11 11:47 ` Michael S. Tsirkin
2020-02-11 12:19 ` David Hildenbrand
2020-02-11 14:07 ` Michael S. Tsirkin
2020-02-11 14:31 ` David Hildenbrand
2020-02-11 14:48 ` Michael S. Tsirkin
2020-02-11 15:13 ` David Hildenbrand
2020-02-11 16:33 ` Alexander Duyck
2020-02-11 17:04 ` David Hildenbrand
2020-01-22 17:43 ` [PATCH v16.1 7/9] mm/page_reporting: Rotate reported pages to the tail of the list Alexander Duyck
2020-01-22 17:43 ` [PATCH v16.1 8/9] mm/page_reporting: Add budget limit on how many pages can be reported per pass Alexander Duyck
2020-01-22 17:44 ` [PATCH v16.1 9/9] mm/page_reporting: Add free page reporting documentation Alexander Duyck
2020-01-23 10:20 ` [PATCH v16.1 0/9] mm / virtio: Provide support for free page reporting Alexander Graf
2020-01-23 14:05 ` David Hildenbrand
2020-01-23 14:52 ` Alexander Graf
2020-01-24 13:25 ` David Hildenbrand
2020-01-24 16:20 ` David Hildenbrand
2020-01-23 16:26 ` Alexander Duyck
2020-01-23 16:54 ` Alexander Graf
2020-01-23 18:33 ` Alexander Duyck
2020-01-23 18:47 ` Graf (AWS), Alexander
2020-01-23 22:05 ` Alexander Duyck
2020-01-23 17:20 ` Dave Hansen
2020-01-23 19:23 ` Konrad Rzeszutek Wilk
2020-01-23 19:17 ` Johannes Weiner
2020-01-23 22:29 ` Alexander Duyck
2020-01-23 23:24 ` Dave Hansen
2020-01-24 13:23 ` Hillf Danton
2020-01-24 16:40 ` Alexander Graf
2020-01-25 2:01 ` Hillf Danton
2020-02-03 22:05 ` Alexander Duyck
2020-02-10 19:18 ` Alexander Duyck [this message]
2020-02-11 10:40 ` Should I repost? (was: Re: [PATCH v16.1 0/9] mm / virtio: Provide support for free page reporting) Mel Gorman
2020-02-11 22:57 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d943ada56babfbebf408ad0f94988a5b09d2b472.camel@linux.intel.com \
--to=alexander.h.duyck@linux.intel.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.duyck@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=david@redhat.com \
--cc=konrad.wilk@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=lcapitulino@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=mst@redhat.com \
--cc=nitesh@redhat.com \
--cc=osalvador@suse.de \
--cc=pagupta@redhat.com \
--cc=pbonzini@redhat.com \
--cc=riel@surriel.com \
--cc=vbabka@suse.cz \
--cc=wei.w.wang@intel.com \
--cc=willy@infradead.org \
--cc=yang.zhang.wz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).