* [PATCH v1 0/2] mm/memory_hotplug: pass in nid to online_pages()
@ 2020-01-13 11:33 David Hildenbrand
2020-01-13 11:33 ` [PATCH v1 1/2] " David Hildenbrand
2020-01-13 11:33 ` [PATCH v1 2/2] drivers/base/memory.c: get rid of find_memory_block() David Hildenbrand
0 siblings, 2 replies; 4+ messages in thread
From: David Hildenbrand @ 2020-01-13 11:33 UTC (permalink / raw)
To: linux-kernel
Cc: linux-mm, David Hildenbrand, Andrew Morton, Anshuman Khandual,
Dan Williams, Greg Kroah-Hartman, Michal Hocko, Oscar Salvador,
Pavel Tatashin, Rafael J. Wysocki
Simplify onlining code and get rid of find_memory_block(). Pass in the
nid from the memory block we are trying to online directly, instead of
manually looking it up.
David Hildenbrand (2):
mm/memory_hotplug: pass in nid to online_pages()
drivers/base/memory.c: get rid of find_memory_block()
drivers/base/memory.c | 15 ++++-----------
include/linux/memory.h | 1 -
include/linux/memory_hotplug.h | 3 ++-
mm/memory_hotplug.c | 13 ++-----------
4 files changed, 8 insertions(+), 24 deletions(-)
--
2.24.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v1 1/2] mm/memory_hotplug: pass in nid to online_pages()
2020-01-13 11:33 [PATCH v1 0/2] mm/memory_hotplug: pass in nid to online_pages() David Hildenbrand
@ 2020-01-13 11:33 ` David Hildenbrand
2020-01-13 11:33 ` [PATCH v1 2/2] drivers/base/memory.c: get rid of find_memory_block() David Hildenbrand
1 sibling, 0 replies; 4+ messages in thread
From: David Hildenbrand @ 2020-01-13 11:33 UTC (permalink / raw)
To: linux-kernel
Cc: linux-mm, David Hildenbrand, Greg Kroah-Hartman,
Rafael J. Wysocki, Andrew Morton, Michal Hocko, Oscar Salvador
No need to lookup the memory block, we can directly pass in the nid.
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Oscar Salvador <osalvador@suse.de>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
drivers/base/memory.c | 6 +++---
include/linux/memory_hotplug.h | 3 ++-
mm/memory_hotplug.c | 13 ++-----------
3 files changed, 7 insertions(+), 15 deletions(-)
diff --git a/drivers/base/memory.c b/drivers/base/memory.c
index 2604a15c728b..2cf3542b04d0 100644
--- a/drivers/base/memory.c
+++ b/drivers/base/memory.c
@@ -236,7 +236,7 @@ static bool pages_correctly_probed(unsigned long start_pfn)
*/
static int
memory_block_action(unsigned long start_section_nr, unsigned long action,
- int online_type)
+ int online_type, int nid)
{
unsigned long start_pfn;
unsigned long nr_pages = PAGES_PER_SECTION * sections_per_block;
@@ -249,7 +249,7 @@ memory_block_action(unsigned long start_section_nr, unsigned long action,
if (!pages_correctly_probed(start_pfn))
return -EBUSY;
- ret = online_pages(start_pfn, nr_pages, online_type);
+ ret = online_pages(start_pfn, nr_pages, online_type, nid);
break;
case MEM_OFFLINE:
ret = offline_pages(start_pfn, nr_pages);
@@ -275,7 +275,7 @@ static int memory_block_change_state(struct memory_block *mem,
mem->state = MEM_GOING_OFFLINE;
ret = memory_block_action(mem->start_section_nr, to_state,
- mem->online_type);
+ mem->online_type, mem->nid);
mem->state = ret ? from_state_req : to_state;
diff --git a/include/linux/memory_hotplug.h b/include/linux/memory_hotplug.h
index 820689093894..f4d59155f3d4 100644
--- a/include/linux/memory_hotplug.h
+++ b/include/linux/memory_hotplug.h
@@ -94,7 +94,8 @@ extern int zone_grow_free_lists(struct zone *zone, unsigned long new_nr_pages);
extern int zone_grow_waitqueues(struct zone *zone, unsigned long nr_pages);
extern int add_one_highpage(struct page *page, int pfn, int bad_ppro);
/* VM interface that may be used by firmware interface */
-extern int online_pages(unsigned long, unsigned long, int);
+extern int online_pages(unsigned long pfn, unsigned long nr_pages,
+ int online_type, int nid);
extern struct zone *test_pages_in_a_zone(unsigned long start_pfn,
unsigned long end_pfn);
extern unsigned long __offline_isolated_pages(unsigned long start_pfn,
diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index 5ee2c6e10934..fb1c878d054d 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -758,27 +758,18 @@ struct zone * zone_for_pfn_range(int online_type, int nid, unsigned start_pfn,
return default_zone_for_pfn(nid, start_pfn, nr_pages);
}
-int __ref online_pages(unsigned long pfn, unsigned long nr_pages, int online_type)
+int __ref online_pages(unsigned long pfn, unsigned long nr_pages,
+ int online_type, int nid)
{
unsigned long flags;
unsigned long onlined_pages = 0;
struct zone *zone;
int need_zonelists_rebuild = 0;
- int nid;
int ret;
struct memory_notify arg;
- struct memory_block *mem;
mem_hotplug_begin();
- /*
- * We can't use pfn_to_nid() because nid might be stored in struct page
- * which is not yet initialized. Instead, we find nid from memory block.
- */
- mem = find_memory_block(__pfn_to_section(pfn));
- nid = mem->nid;
- put_device(&mem->dev);
-
/* associate pfn range with the zone */
zone = zone_for_pfn_range(online_type, nid, pfn, nr_pages);
move_pfn_range_to_zone(zone, pfn, nr_pages, NULL);
--
2.24.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v1 2/2] drivers/base/memory.c: get rid of find_memory_block()
2020-01-13 11:33 [PATCH v1 0/2] mm/memory_hotplug: pass in nid to online_pages() David Hildenbrand
2020-01-13 11:33 ` [PATCH v1 1/2] " David Hildenbrand
@ 2020-01-13 11:33 ` David Hildenbrand
2020-01-14 8:24 ` David Hildenbrand
1 sibling, 1 reply; 4+ messages in thread
From: David Hildenbrand @ 2020-01-13 11:33 UTC (permalink / raw)
To: linux-kernel
Cc: linux-mm, David Hildenbrand, Greg Kroah-Hartman,
Rafael J. Wysocki, Andrew Morton, Dan Williams, Michal Hocko,
Pavel Tatashin, Anshuman Khandual, Oscar Salvador
No longer needed, remove it.
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Pavel Tatashin <pasha.tatashin@soleen.com>
Cc: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Oscar Salvador <osalvador@suse.de>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
drivers/base/memory.c | 9 +--------
include/linux/memory.h | 1 -
2 files changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/base/memory.c b/drivers/base/memory.c
index 2cf3542b04d0..8b3ab910b812 100644
--- a/drivers/base/memory.c
+++ b/drivers/base/memory.c
@@ -590,13 +590,6 @@ static struct memory_block *find_memory_block_by_id(unsigned long block_id)
return mem;
}
-struct memory_block *find_memory_block(struct mem_section *section)
-{
- unsigned long block_id = base_memory_block_id(__section_nr(section));
-
- return find_memory_block_by_id(block_id);
-}
-
static struct attribute *memory_memblk_attrs[] = {
&dev_attr_phys_index.attr,
&dev_attr_state.attr,
@@ -700,7 +693,7 @@ static void unregister_memory(struct memory_block *memory)
WARN_ON(radix_tree_delete(&memory_blocks, memory->dev.id) == NULL);
- /* drop the ref. we got via find_memory_block() */
+ /* drop the ref. we got via find_memory_block_by_id() */
put_device(&memory->dev);
device_unregister(&memory->dev);
}
diff --git a/include/linux/memory.h b/include/linux/memory.h
index 3ab4aa2d67ae..0b0732a94972 100644
--- a/include/linux/memory.h
+++ b/include/linux/memory.h
@@ -113,7 +113,6 @@ void remove_memory_block_devices(unsigned long start, unsigned long size);
extern void memory_dev_init(void);
extern int memory_notify(unsigned long val, void *v);
extern int memory_isolate_notify(unsigned long val, void *v);
-extern struct memory_block *find_memory_block(struct mem_section *);
typedef int (*walk_memory_blocks_func_t)(struct memory_block *, void *);
extern int walk_memory_blocks(unsigned long start, unsigned long size,
void *arg, walk_memory_blocks_func_t func);
--
2.24.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1 2/2] drivers/base/memory.c: get rid of find_memory_block()
2020-01-13 11:33 ` [PATCH v1 2/2] drivers/base/memory.c: get rid of find_memory_block() David Hildenbrand
@ 2020-01-14 8:24 ` David Hildenbrand
0 siblings, 0 replies; 4+ messages in thread
From: David Hildenbrand @ 2020-01-14 8:24 UTC (permalink / raw)
To: linux-kernel
Cc: linux-mm, Greg Kroah-Hartman, Rafael J. Wysocki, Andrew Morton,
Dan Williams, Michal Hocko, Pavel Tatashin, Anshuman Khandual,
Oscar Salvador, Stephen Rothwell
On 13.01.20 12:33, David Hildenbrand wrote:
> No longer needed, remove it.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Michal Hocko <mhocko@suse.com>
> Cc: Pavel Tatashin <pasha.tatashin@soleen.com>
> Cc: Anshuman Khandual <anshuman.khandual@arm.com>
> Cc: Oscar Salvador <osalvador@suse.de>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
> drivers/base/memory.c | 9 +--------
> include/linux/memory.h | 1 -
> 2 files changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/drivers/base/memory.c b/drivers/base/memory.c
> index 2cf3542b04d0..8b3ab910b812 100644
> --- a/drivers/base/memory.c
> +++ b/drivers/base/memory.c
> @@ -590,13 +590,6 @@ static struct memory_block *find_memory_block_by_id(unsigned long block_id)
> return mem;
> }
>
> -struct memory_block *find_memory_block(struct mem_section *section)
> -{
> - unsigned long block_id = base_memory_block_id(__section_nr(section));
> -
> - return find_memory_block_by_id(block_id);
> -}
> -
> static struct attribute *memory_memblk_attrs[] = {
> &dev_attr_phys_index.attr,
> &dev_attr_state.attr,
> @@ -700,7 +693,7 @@ static void unregister_memory(struct memory_block *memory)
>
> WARN_ON(radix_tree_delete(&memory_blocks, memory->dev.id) == NULL);
>
> - /* drop the ref. we got via find_memory_block() */
> + /* drop the ref. we got via find_memory_block_by_id() */
> put_device(&memory->dev);
> device_unregister(&memory->dev);
> }
> diff --git a/include/linux/memory.h b/include/linux/memory.h
> index 3ab4aa2d67ae..0b0732a94972 100644
> --- a/include/linux/memory.h
> +++ b/include/linux/memory.h
> @@ -113,7 +113,6 @@ void remove_memory_block_devices(unsigned long start, unsigned long size);
> extern void memory_dev_init(void);
> extern int memory_notify(unsigned long val, void *v);
> extern int memory_isolate_notify(unsigned long val, void *v);
> -extern struct memory_block *find_memory_block(struct mem_section *);
> typedef int (*walk_memory_blocks_func_t)(struct memory_block *, void *);
> extern int walk_memory_blocks(unsigned long start, unsigned long size,
> void *arg, walk_memory_blocks_func_t func);
>
My git-grepping skills betrayed me :) There is one remaining user in ppc
code. Let's drop this patch for now.
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-14 8:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-13 11:33 [PATCH v1 0/2] mm/memory_hotplug: pass in nid to online_pages() David Hildenbrand
2020-01-13 11:33 ` [PATCH v1 1/2] " David Hildenbrand
2020-01-13 11:33 ` [PATCH v1 2/2] drivers/base/memory.c: get rid of find_memory_block() David Hildenbrand
2020-01-14 8:24 ` David Hildenbrand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).