From: Alexander Graf <graf@amazon.com>
To: Michal Hocko <mhocko@kernel.org>, Jann Horn <jannh@google.com>
Cc: Pavel Machek <pavel@ucw.cz>,
"Catangiu, Adrian Costin" <acatan@amazon.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"linux-api@vger.kernel.org" <linux-api@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"len.brown@intel.com" <len.brown@intel.com>,
"fweimer@redhat.com" <fweimer@redhat.com>,
"keescook@chromium.org" <keescook@chromium.org>,
"luto@amacapital.net" <luto@amacapital.net>,
"wad@chromium.org" <wad@chromium.org>,
"mingo@kernel.org" <mingo@kernel.org>,
"bonzini@gnu.org" <bonzini@gnu.org>,
"MacCarthaigh, Colm" <colmmacc@amazon.com>,
"Singh, Balbir" <sblbir@amazon.com>,
"Sandu, Andrei" <sandreim@amazon.com>,
"Brooker, Marc" <mbrooker@amazon.com>,
"Weiss, Radu" <raduweis@amazon.com>,
"Manwaring, Derek" <derekmn@amazon.com>
Subject: Re: [RFC]: mm,power: introduce MADV_WIPEONSUSPEND
Date: Tue, 7 Jul 2020 10:01:23 +0200 [thread overview]
Message-ID: <efa55313-ce8a-bac9-15df-167f93c672b3@amazon.com> (raw)
In-Reply-To: <20200707074425.GC3820@dhcp22.suse.cz>
On 07.07.20 09:44, Michal Hocko wrote:
> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
>
>
>
> On Mon 06-07-20 14:52:07, Jann Horn wrote:
>> On Mon, Jul 6, 2020 at 2:27 PM Alexander Graf <graf@amazon.com> wrote:
>>> Unless we create a vsyscall that returns both the PID as well as the
>>> epoch and thus handles fork *and* suspend. I need to think about this a
>>> bit more :).
>>
>> You can't reliably detect forking by checking the PID if it is
>> possible for multiple forks to be chained before the reuse check runs:
>>
>> - pid 1000 remembers its PID
>> - pid 1000 forks, creating child pid 1001
>> - pid 1000 exits and is waited on by init
>> - the pid allocator wraps around
>> - pid 1001 forks, creating child pid 1000
>> - child with pid 1000 tries to check for forking, determines that its
>> PID is 1000, and concludes that it is still the original process
>
> I must be really missing something here because I really fail to see why
> there has to be something new even invented. Sure, checking for pid is
> certainly a suboptimal solution because pids are terrible tokens to work
> with. We do have a concept of file descriptors which a much better and
> supports signaling. There is a clear source of the signal IIUC
> (migration) and there are consumers to act upon that (e.g. crypto
> backends). So what does really prevent to use a standard signal delivery
> over fd for this usecase?
I wasn't part of the discussions on why things like WIPEONFORK were
invented instead of just using signalling mechanisms, but the main
reason I can think of are libraries.
As a library, you are under no control of the main loop usually, which
means you just don't have a way to poll for an fd. As a library author,
I would usually try to avoid very hard to create such a dependency,
because it makes it really hard to glue pieces together.
The same applies to signals btw, which would also be a possible way to
propagate such events.
Alex
Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879
next prev parent reply other threads:[~2020-07-07 8:01 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-03 10:34 [RFC]: mm,power: introduce MADV_WIPEONSUSPEND Catangiu, Adrian Costin
2020-07-03 11:04 ` Jann Horn
2020-07-04 1:33 ` Colm MacCárthaigh
2020-07-06 12:09 ` Alexander Graf
2020-07-03 11:30 ` Michal Hocko
2020-07-03 12:17 ` Rafael J. Wysocki
2020-07-03 22:39 ` Pavel Machek
2020-07-03 13:29 ` Jann Horn
2020-07-03 22:34 ` Pavel Machek
2020-07-03 22:53 ` Jann Horn
2020-07-07 7:38 ` Michal Hocko
2020-07-07 8:07 ` Pavel Machek
2020-07-07 8:58 ` Michal Hocko
2020-07-07 16:37 ` Pavel Machek
2020-07-07 19:00 ` Colm MacCarthaigh
2020-07-12 7:22 ` Pavel Machek
2020-07-13 8:02 ` Michal Hocko
2020-07-04 1:45 ` Colm MacCárthaigh
2020-07-07 7:40 ` Michal Hocko
2020-07-03 22:44 ` Pavel Machek
2020-07-03 22:56 ` Jann Horn
2020-07-04 11:48 ` Pavel Machek
2020-07-06 12:26 ` Alexander Graf
2020-07-06 12:52 ` Jann Horn
2020-07-06 13:14 ` Alexander Graf
2020-07-07 7:44 ` Michal Hocko
2020-07-07 8:01 ` Alexander Graf [this message]
2020-07-07 9:14 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efa55313-ce8a-bac9-15df-167f93c672b3@amazon.com \
--to=graf@amazon.com \
--cc=acatan@amazon.com \
--cc=akpm@linux-foundation.org \
--cc=bonzini@gnu.org \
--cc=colmmacc@amazon.com \
--cc=derekmn@amazon.com \
--cc=fweimer@redhat.com \
--cc=jannh@google.com \
--cc=keescook@chromium.org \
--cc=len.brown@intel.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pm@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mbrooker@amazon.com \
--cc=mhocko@kernel.org \
--cc=mingo@kernel.org \
--cc=pavel@ucw.cz \
--cc=raduweis@amazon.com \
--cc=rjw@rjwysocki.net \
--cc=sandreim@amazon.com \
--cc=sblbir@amazon.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=wad@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).