From: Mike Kravetz <mike.kravetz@oracle.com>
To: Oscar Salvador <osalvador@suse.de>,
Andrew Morton <akpm@linux-foundation.org>
Cc: David Hildenbrand <david@redhat.com>,
Muchun Song <songmuchun@bytedance.com>,
Michal Hocko <mhocko@kernel.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] mm: Make alloc_contig_range handle in-use hugetlb pages
Date: Thu, 25 Feb 2021 15:05:15 -0800 [thread overview]
Message-ID: <f179cd81-5c8f-7b98-2ebc-c93da5a60ee2@oracle.com> (raw)
In-Reply-To: <20210222135137.25717-3-osalvador@suse.de>
On 2/22/21 5:51 AM, Oscar Salvador wrote:
> alloc_contig_range() will fail if it finds a HugeTLB page within the range,
> without a chance to handle them. Since HugeTLB pages can be migrated as any
> LRU or Movable page, it does not make sense to bail out without trying.
> Enable the interface to recognize in-use HugeTLB pages so we can migrate
> them, and have much better chances to succeed the call.
>
> Signed-off-by: Oscar Salvador <osalvador@suse.de>
> ---
> include/linux/hugetlb.h | 5 +++--
> mm/compaction.c | 12 +++++++++++-
> mm/hugetlb.c | 21 +++++++++++++++++----
> mm/vmscan.c | 5 +++--
> 4 files changed, 34 insertions(+), 9 deletions(-)
Thanks,
Changes look good. I like the simple retry one time for pages which may
go from free to in use.
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
BTW,
This series will need to be rebased on latest which has hugetlb page flag
changes. Should be as simple as:
s/PageHugeFreed/HPageFreed/
--
Mike Kravetz
next prev parent reply other threads:[~2021-02-25 23:05 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 13:51 [PATCH v3 0/2] Make alloc_contig_range handle Hugetlb pages Oscar Salvador
2021-02-22 13:51 ` [PATCH v3 1/2] mm: Make alloc_contig_range handle free hugetlb pages Oscar Salvador
2021-02-25 20:03 ` Mike Kravetz
2021-02-26 9:48 ` Oscar Salvador
2021-02-26 8:35 ` Michal Hocko
2021-02-26 8:38 ` Michal Hocko
2021-02-26 9:25 ` David Hildenbrand
2021-02-26 9:47 ` Oscar Salvador
2021-02-26 9:45 ` Oscar Salvador
2021-02-26 9:51 ` Michal Hocko
2021-03-01 14:09 ` David Hildenbrand
2021-03-04 10:19 ` Oscar Salvador
2021-03-04 10:32 ` David Hildenbrand
2021-03-04 10:41 ` Oscar Salvador
2021-02-22 13:51 ` [PATCH v3 2/2] mm: Make alloc_contig_range handle in-use " Oscar Salvador
2021-02-25 23:05 ` Mike Kravetz [this message]
2021-02-26 8:46 ` Michal Hocko
2021-02-26 10:24 ` Oscar Salvador
2021-02-26 10:27 ` Oscar Salvador
2021-02-26 12:46 ` Michal Hocko
2021-02-28 13:43 ` Oscar Salvador
2021-03-05 17:30 ` David Hildenbrand
2021-03-01 12:43 ` [PATCH v3 0/2] Make alloc_contig_range handle Hugetlb pages David Hildenbrand
2021-03-01 12:57 ` Oscar Salvador
2021-03-01 12:59 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f179cd81-5c8f-7b98-2ebc-c93da5a60ee2@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=osalvador@suse.de \
--cc=songmuchun@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).