From: Arun KS <arunks@codeaurora.org>
To: Oscar Salvador <osalvador@techadventures.net>
Cc: kys@microsoft.com, haiyangz@microsoft.com,
sthemmin@microsoft.com, boris.ostrovsky@oracle.com,
jgross@suse.com, akpm@linux-foundation.org,
dan.j.williams@intel.com, mhocko@suse.com, vbabka@suse.cz,
iamjoonsoo.kim@lge.com, gregkh@linuxfoundation.org,
osalvador@suse.de, malat@debian.org,
kirill.shutemov@linux.intel.com, jrdr.linux@gmail.com,
yasu.isimatu@gmail.com, mgorman@techsingularity.net,
aaron.lu@intel.com, devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
xen-devel@lists.xenproject.org, vatsa@codeaurora.org,
vinmenon@codeaurora.org, getarunks@gmail.com
Subject: Re: [PATCH v5 1/2] memory_hotplug: Free pages as higher order
Date: Wed, 10 Oct 2018 16:21:16 +0530 [thread overview]
Message-ID: <f18b87a0762c4379b78e9b5e09ff4840@codeaurora.org> (raw)
In-Reply-To: <20181010080724.GA20338@techadventures.net>
On 2018-10-10 13:37, Oscar Salvador wrote:
> On Fri, Oct 05, 2018 at 01:40:05PM +0530, Arun KS wrote:
>> When free pages are done with higher order, time spend on
>> coalescing pages by buddy allocator can be reduced. With
>> section size of 256MB, hot add latency of a single section
>> shows improvement from 50-60 ms to less than 1 ms, hence
>> improving the hot add latency by 60%. Modify external
>> providers of online callback to align with the change.
>
> Hi Arun, out of curiosity:
>
> could you please explain how exactly did you mesure the speed
> improvement?
diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index e379e85..2416136 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -690,9 +690,13 @@ static int online_pages_range(unsigned long
start_pfn, unsigned long nr_pages,
void *arg)
{
unsigned long onlined_pages = *(unsigned long *)arg;
+ u64 t1, t2;
+ t1 = local_clock();
if (PageReserved(pfn_to_page(start_pfn)))
onlined_pages = online_pages_blocks(start_pfn,
nr_pages);
+ t2 = local_clock();
+ trace_printk("time spend = %llu us\n", (t2-t1)/(1000));
online_mem_sections(start_pfn, start_pfn + nr_pages);
Regards,
Arun
>
> Thanks
next prev parent reply other threads:[~2018-10-10 10:51 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-05 8:10 [PATCH v5 1/2] memory_hotplug: Free pages as higher order Arun KS
2018-10-05 8:10 ` [PATCH v5 2/2] mm/page_alloc: remove software prefetching in __free_pages_core Arun KS
2018-10-09 9:30 ` Michal Hocko
2018-10-10 16:36 ` Vlastimil Babka
2018-10-08 7:34 ` [PATCH v5 1/2] memory_hotplug: Free pages as higher order Oscar Salvador
2018-10-09 9:29 ` Michal Hocko
2018-10-09 9:54 ` Arun KS
2018-10-09 11:06 ` Michal Hocko
2018-10-10 8:07 ` Oscar Salvador
2018-10-10 10:51 ` Arun KS [this message]
2018-10-10 11:01 ` Oscar Salvador
2018-10-10 15:30 ` Vlastimil Babka
2018-10-10 16:56 ` Arun KS
2018-10-10 17:33 ` Michal Hocko
2018-10-11 2:29 ` Arun KS
2018-10-11 7:55 ` Michal Hocko
2018-10-19 2:18 ` Andrew Morton
2018-10-19 8:07 ` Michal Hocko
2018-10-22 10:33 ` Arun KS
2018-11-05 9:42 ` Arun KS
2018-11-05 21:44 ` Andrew Morton
2018-11-06 5:31 ` Arun KS
2018-10-11 8:07 ` Vlastimil Babka
2018-10-11 8:15 ` Michal Hocko
2018-11-19 22:15 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f18b87a0762c4379b78e9b5e09ff4840@codeaurora.org \
--to=arunks@codeaurora.org \
--cc=aaron.lu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=boris.ostrovsky@oracle.com \
--cc=dan.j.williams@intel.com \
--cc=devel@linuxdriverproject.org \
--cc=getarunks@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=jgross@suse.com \
--cc=jrdr.linux@gmail.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=malat@debian.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=osalvador@techadventures.net \
--cc=sthemmin@microsoft.com \
--cc=vatsa@codeaurora.org \
--cc=vbabka@suse.cz \
--cc=vinmenon@codeaurora.org \
--cc=xen-devel@lists.xenproject.org \
--cc=yasu.isimatu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).