* [PATCH] mm/vmscan.c: remove unused return value of shrink_node
@ 2019-11-28 14:35 Liu Song
2019-11-28 15:10 ` David Hildenbrand
0 siblings, 1 reply; 2+ messages in thread
From: Liu Song @ 2019-11-28 14:35 UTC (permalink / raw)
To: akpm, mhocko, hannes, daniel.m.jordan, laoar.shao, yang.shi,
aryabinin, mgorman
Cc: linux-mm, linux-kernel, liu.song11
From: Liu Song <liu.song11@zte.com.cn>
The return value of shrink_node is not used, so remove
unnecessary operations.
Signed-off-by: Liu Song <liu.song11@zte.com.cn>
---
mm/vmscan.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 44df66a98f2a..fd282d86f4ad 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -2652,7 +2652,7 @@ static bool pgdat_memcg_congested(pg_data_t *pgdat, struct mem_cgroup *memcg)
(memcg && memcg_congested(pgdat, memcg));
}
-static bool shrink_node(pg_data_t *pgdat, struct scan_control *sc)
+static void shrink_node(pg_data_t *pgdat, struct scan_control *sc)
{
struct reclaim_state *reclaim_state = current->reclaim_state;
unsigned long nr_reclaimed, nr_scanned;
@@ -2818,8 +2818,6 @@ static bool shrink_node(pg_data_t *pgdat, struct scan_control *sc)
*/
if (reclaimable)
pgdat->kswapd_failures = 0;
-
- return reclaimable;
}
/*
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mm/vmscan.c: remove unused return value of shrink_node
2019-11-28 14:35 [PATCH] mm/vmscan.c: remove unused return value of shrink_node Liu Song
@ 2019-11-28 15:10 ` David Hildenbrand
0 siblings, 0 replies; 2+ messages in thread
From: David Hildenbrand @ 2019-11-28 15:10 UTC (permalink / raw)
To: Liu Song, akpm, mhocko, hannes, daniel.m.jordan, laoar.shao,
yang.shi, aryabinin, mgorman
Cc: linux-mm, linux-kernel, liu.song11
On 28.11.19 15:35, Liu Song wrote:
> From: Liu Song <liu.song11@zte.com.cn>
>
> The return value of shrink_node is not used, so remove
> unnecessary operations.
>
> Signed-off-by: Liu Song <liu.song11@zte.com.cn>
> ---
> mm/vmscan.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 44df66a98f2a..fd282d86f4ad 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -2652,7 +2652,7 @@ static bool pgdat_memcg_congested(pg_data_t *pgdat, struct mem_cgroup *memcg)
> (memcg && memcg_congested(pgdat, memcg));
> }
>
> -static bool shrink_node(pg_data_t *pgdat, struct scan_control *sc)
> +static void shrink_node(pg_data_t *pgdat, struct scan_control *sc)
> {
> struct reclaim_state *reclaim_state = current->reclaim_state;
> unsigned long nr_reclaimed, nr_scanned;
> @@ -2818,8 +2818,6 @@ static bool shrink_node(pg_data_t *pgdat, struct scan_control *sc)
> */
> if (reclaimable)
> pgdat->kswapd_failures = 0;
> -
> - return reclaimable;
> }
>
> /*
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-28 15:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-28 14:35 [PATCH] mm/vmscan.c: remove unused return value of shrink_node Liu Song
2019-11-28 15:10 ` David Hildenbrand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).