linux-mmc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] mmc: host: use kzalloc instead of kmalloc and memset
@ 2019-12-17  7:18 Pan Zhang
  2019-12-17  7:32 ` David Rientjes
  2019-12-17  7:32 ` Greg KH
  0 siblings, 2 replies; 4+ messages in thread
From: Pan Zhang @ 2019-12-17  7:18 UTC (permalink / raw)
  To: zhangpan26, hushiyuan, ulf.hansson, allison, gregkh, tglx
  Cc: linux-mmc, linux-kernel

Signed-off-by: Pan Zhang <zhangpan26@huawei.com>
---
 drivers/mmc/host/vub300.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/drivers/mmc/host/vub300.c b/drivers/mmc/host/vub300.c
index 6ced1b7..e18931d 100644
--- a/drivers/mmc/host/vub300.c
+++ b/drivers/mmc/host/vub300.c
@@ -1227,12 +1227,10 @@ static void __download_offload_pseudocode(struct vub300_mmc_host *vub300,
 	size -= 1;
 	if (interrupt_size < size) {
 		u16 xfer_length = roundup_to_multiple_of_64(interrupt_size);
-		u8 *xfer_buffer = kmalloc(xfer_length, GFP_KERNEL);
+		u8 *xfer_buffer = kzalloc(xfer_length, GFP_KERNEL);
 		if (xfer_buffer) {
 			int retval;
 			memcpy(xfer_buffer, data, interrupt_size);
-			memset(xfer_buffer + interrupt_size, 0,
-			       xfer_length - interrupt_size);
 			size -= interrupt_size;
 			data += interrupt_size;
 			retval =
@@ -1270,12 +1268,10 @@ static void __download_offload_pseudocode(struct vub300_mmc_host *vub300,
 	size -= 1;
 	if (ts < size) {
 		u16 xfer_length = roundup_to_multiple_of_64(ts);
-		u8 *xfer_buffer = kmalloc(xfer_length, GFP_KERNEL);
+		u8 *xfer_buffer = kzalloc(xfer_length, GFP_KERNEL);
 		if (xfer_buffer) {
 			int retval;
 			memcpy(xfer_buffer, data, ts);
-			memset(xfer_buffer + ts, 0,
-			       xfer_length - ts);
 			size -= ts;
 			data += ts;
 			retval =
@@ -1465,7 +1461,7 @@ static int __command_read_data(struct vub300_mmc_host *vub300,
 			}
 		}
 	} else {
-		u8 *buf = kmalloc(padded_length, GFP_KERNEL);
+		u8 *buf = kzalloc(padded_length, GFP_KERNEL);
 		if (buf) {
 			int result;
 			unsigned pipe = usb_rcvbulkpipe(vub300->udev,
@@ -2024,7 +2020,7 @@ static void vub300_mmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
 		msleep(600);
 		vub300->card_powered = 1;
 	} else if (ios->power_mode == MMC_POWER_ON) {
-		u8 *buf = kmalloc(8, GFP_KERNEL);
+		u8 *buf = kzalloc(8, GFP_KERNEL);
 		if (buf) {
 			__set_clock_speed(vub300, buf, ios);
 			kfree(buf);
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-12-17 14:18 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-17  7:18 [PATCH v2] mmc: host: use kzalloc instead of kmalloc and memset Pan Zhang
2019-12-17  7:32 ` David Rientjes
2019-12-17  7:32 ` Greg KH
2019-12-17 14:17   ` Re: [PATCH] " Pan Zhang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).