* [PATCH V2] arm64: dts: qcom: sc7180: SD-card GPIO pin set bias-pull up
@ 2020-07-21 10:44 Shaik Sajida Bhanu
2020-07-22 3:42 ` Bjorn Andersson
0 siblings, 1 reply; 2+ messages in thread
From: Shaik Sajida Bhanu @ 2020-07-21 10:44 UTC (permalink / raw)
To: adrian.hunter, ulf.hansson, robh+dt, mka
Cc: linux-mmc, linux-kernel, linux-arm-msm, devicetree, agross,
bjorn.andersson, Veerabhadrarao Badiganti, Shaik Sajida Bhanu
From: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>
On some sc7180 based platforms where external pull is not present on cd-gpio,
this gpio state is getting read as HIGH when sleep config is applied on it.
This is resulting in SDcard rescan after suspend-resume even though SDcard
is not present.
Update cd-gpio sleep config with bais-pull to fix this issue.
Signed-off-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>
Signed-off-by: Shaik Sajida Bhanu <sbhanu@codeaurora.org>
---
Changes since V1:
- Incorporated review comments by Bjorn Andersson.
---
arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index d78a066..a3527c3 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -1819,7 +1819,7 @@
pinconf-sd-cd {
pins = "gpio69";
- bias-disable;
+ bias-pull-up;
drive-strength = <2>;
};
};
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH V2] arm64: dts: qcom: sc7180: SD-card GPIO pin set bias-pull up
2020-07-21 10:44 [PATCH V2] arm64: dts: qcom: sc7180: SD-card GPIO pin set bias-pull up Shaik Sajida Bhanu
@ 2020-07-22 3:42 ` Bjorn Andersson
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2020-07-22 3:42 UTC (permalink / raw)
To: Shaik Sajida Bhanu
Cc: adrian.hunter, ulf.hansson, robh+dt, mka, linux-mmc,
linux-kernel, linux-arm-msm, devicetree, agross,
Veerabhadrarao Badiganti
On Tue 21 Jul 03:44 PDT 2020, Shaik Sajida Bhanu wrote:
> From: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>
>
> On some sc7180 based platforms where external pull is not present on cd-gpio,
> this gpio state is getting read as HIGH when sleep config is applied on it.
> This is resulting in SDcard rescan after suspend-resume even though SDcard
> is not present.
>
This is exactly why pinconf properties (such as bias, drive-strength)
should be defined in the board specific file.
Please move the "pinconf-sd-cd" node to sc7180-idp.dts.
Regards,
Bjorn
> Update cd-gpio sleep config with bais-pull to fix this issue.
>
> Signed-off-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>
> Signed-off-by: Shaik Sajida Bhanu <sbhanu@codeaurora.org>
> ---
>
> Changes since V1:
> - Incorporated review comments by Bjorn Andersson.
> ---
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index d78a066..a3527c3 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -1819,7 +1819,7 @@
>
> pinconf-sd-cd {
> pins = "gpio69";
> - bias-disable;
> + bias-pull-up;
> drive-strength = <2>;
> };
> };
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-22 3:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-21 10:44 [PATCH V2] arm64: dts: qcom: sc7180: SD-card GPIO pin set bias-pull up Shaik Sajida Bhanu
2020-07-22 3:42 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).