Linux-mmc Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] dt-bindings: mmc: clarify disable-wp text
@ 2019-12-19 14:58 Johan Jonker
  2019-12-28  9:30 ` [PATCH v2 1/2] dt-bindings: mmc: remove identical phrase in " Johan Jonker
  0 siblings, 1 reply; 7+ messages in thread
From: Johan Jonker @ 2019-12-19 14:58 UTC (permalink / raw)
  To: ulf.hansson; +Cc: robh+dt, mark.rutland, linux-mmc, devicetree, linux-kernel

Clarify disable-wp text.
Clean up and add that "disable-wp" is not used in combination
with eMMC or SDIO.

Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
 Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
index b130450c3..3c0df4016 100644
--- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
+++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
@@ -96,11 +96,10 @@ properties:
     description:
       When set, no physical write-protect line is present. This
       property should only be specified when the controller has a
-      dedicated write-protect detection logic. If a GPIO is always
-      used for the write-protect detection. If a GPIO is always used
+      dedicated write-protect detection logic. If a GPIO is always used
       for the write-protect detection logic, it is sufficient to not
       specify the wp-gpios property in the absence of a write-protect
-      line.
+      line. Not used in combination with eMMC or SDIO.
 
   wp-gpios:
     description:
-- 
2.11.0


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH v2 1/2] dt-bindings: mmc: remove identical phrase in disable-wp text
  2019-12-19 14:58 [PATCH] dt-bindings: mmc: clarify disable-wp text Johan Jonker
@ 2019-12-28  9:30 ` " Johan Jonker
  2019-12-28  9:30   ` [PATCH v2 2/2] dt-bindings: mmc: clarify " Johan Jonker
  2020-01-04 21:55   ` [PATCH v2 1/2] dt-bindings: mmc: remove identical phrase in " Rob Herring
  0 siblings, 2 replies; 7+ messages in thread
From: Johan Jonker @ 2019-12-28  9:30 UTC (permalink / raw)
  To: robh+dt
  Cc: mark.rutland, ulf.hansson, linux-mmc, linux-rockchip, devicetree,
	linux-kernel

There are two identical phrases in the disable-wp text,
so remove one of them.

Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
 Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
index b130450c3..d668d0fbe 100644
--- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
+++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
@@ -96,8 +96,7 @@ properties:
     description:
       When set, no physical write-protect line is present. This
       property should only be specified when the controller has a
-      dedicated write-protect detection logic. If a GPIO is always
-      used for the write-protect detection. If a GPIO is always used
+      dedicated write-protect detection logic. If a GPIO is always used
       for the write-protect detection logic, it is sufficient to not
       specify the wp-gpios property in the absence of a write-protect
       line.
-- 
2.11.0


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH v2 2/2] dt-bindings: mmc: clarify disable-wp text
  2019-12-28  9:30 ` [PATCH v2 1/2] dt-bindings: mmc: remove identical phrase in " Johan Jonker
@ 2019-12-28  9:30   ` " Johan Jonker
  2020-01-04 21:55     ` Rob Herring
  2020-01-04 21:55   ` [PATCH v2 1/2] dt-bindings: mmc: remove identical phrase in " Rob Herring
  1 sibling, 1 reply; 7+ messages in thread
From: Johan Jonker @ 2019-12-28  9:30 UTC (permalink / raw)
  To: robh+dt
  Cc: mark.rutland, ulf.hansson, linux-mmc, linux-rockchip, devicetree,
	linux-kernel

"disable-wp" has been removed from all Rockchip eMMC and SDIO dts nodes,
but people still continue to submit new patches with "disable-wp" added
to other nodes then for the SD card slot,
what it was designed for in the first place.
So clarify the "disable-wp" text by adding that this option should
not be used in combination with eMMC or SDIO.

Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
 Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
index d668d0fbe..3c0df4016 100644
--- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
+++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
@@ -99,7 +99,7 @@ properties:
       dedicated write-protect detection logic. If a GPIO is always used
       for the write-protect detection logic, it is sufficient to not
       specify the wp-gpios property in the absence of a write-protect
-      line.
+      line. Not used in combination with eMMC or SDIO.
 
   wp-gpios:
     description:
-- 
2.11.0


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2 1/2] dt-bindings: mmc: remove identical phrase in disable-wp text
  2019-12-28  9:30 ` [PATCH v2 1/2] dt-bindings: mmc: remove identical phrase in " Johan Jonker
  2019-12-28  9:30   ` [PATCH v2 2/2] dt-bindings: mmc: clarify " Johan Jonker
@ 2020-01-04 21:55   ` " Rob Herring
  2020-01-16 11:16     ` Ulf Hansson
  1 sibling, 1 reply; 7+ messages in thread
From: Rob Herring @ 2020-01-04 21:55 UTC (permalink / raw)
  To: Johan Jonker
  Cc: robh+dt, mark.rutland, ulf.hansson, linux-mmc, linux-rockchip,
	devicetree, linux-kernel

On Sat, 28 Dec 2019 10:30:58 +0100, Johan Jonker wrote:
> There are two identical phrases in the disable-wp text,
> so remove one of them.
> 
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> ---
>  Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 

Applied, thanks.

Rob

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2 2/2] dt-bindings: mmc: clarify disable-wp text
  2019-12-28  9:30   ` [PATCH v2 2/2] dt-bindings: mmc: clarify " Johan Jonker
@ 2020-01-04 21:55     ` Rob Herring
  0 siblings, 0 replies; 7+ messages in thread
From: Rob Herring @ 2020-01-04 21:55 UTC (permalink / raw)
  To: Johan Jonker
  Cc: robh+dt, mark.rutland, ulf.hansson, linux-mmc, linux-rockchip,
	devicetree, linux-kernel

On Sat, 28 Dec 2019 10:30:59 +0100, Johan Jonker wrote:
> "disable-wp" has been removed from all Rockchip eMMC and SDIO dts nodes,
> but people still continue to submit new patches with "disable-wp" added
> to other nodes then for the SD card slot,
> what it was designed for in the first place.
> So clarify the "disable-wp" text by adding that this option should
> not be used in combination with eMMC or SDIO.
> 
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> ---
>  Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Applied, thanks.

Rob

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2 1/2] dt-bindings: mmc: remove identical phrase in disable-wp text
  2020-01-04 21:55   ` [PATCH v2 1/2] dt-bindings: mmc: remove identical phrase in " Rob Herring
@ 2020-01-16 11:16     ` Ulf Hansson
  2020-01-16 17:18       ` Rob Herring
  0 siblings, 1 reply; 7+ messages in thread
From: Ulf Hansson @ 2020-01-16 11:16 UTC (permalink / raw)
  To: Rob Herring
  Cc: Johan Jonker, Rob Herring, Mark Rutland, linux-mmc,
	open list:ARM/Rockchip SoC...,
	DTML, Linux Kernel Mailing List

On Sat, 4 Jan 2020 at 22:55, Rob Herring <robh@kernel.org> wrote:
>
> On Sat, 28 Dec 2019 10:30:58 +0100, Johan Jonker wrote:
> > There are two identical phrases in the disable-wp text,
> > so remove one of them.
> >
> > Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> > ---
> >  Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
>
> Applied, thanks.
>
> Rob

Rob,

Normally I pick up the DT doc changes for mmc whenever you have acked
them (at least more non-trivial changes). I regards to the
mmc-controller.yaml file, I have no queued changes in my tree for this
cycle so this should be fine in regards to conflicts.

Going forward, do you prefer to pick the DT doc changes for mmc, or
can I consider this as a single occasion thingy?

Kind regards
Uffe

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2 1/2] dt-bindings: mmc: remove identical phrase in disable-wp text
  2020-01-16 11:16     ` Ulf Hansson
@ 2020-01-16 17:18       ` Rob Herring
  0 siblings, 0 replies; 7+ messages in thread
From: Rob Herring @ 2020-01-16 17:18 UTC (permalink / raw)
  To: Ulf Hansson
  Cc: Johan Jonker, Mark Rutland, linux-mmc,
	open list:ARM/Rockchip SoC...,
	DTML, Linux Kernel Mailing List

On Thu, Jan 16, 2020 at 5:17 AM Ulf Hansson <ulf.hansson@linaro.org> wrote:
>
> On Sat, 4 Jan 2020 at 22:55, Rob Herring <robh@kernel.org> wrote:
> >
> > On Sat, 28 Dec 2019 10:30:58 +0100, Johan Jonker wrote:
> > > There are two identical phrases in the disable-wp text,
> > > so remove one of them.
> > >
> > > Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> > > ---
> > >  Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 3 +--
> > >  1 file changed, 1 insertion(+), 2 deletions(-)
> > >
> >
> > Applied, thanks.
> >
> > Rob
>
> Rob,
>
> Normally I pick up the DT doc changes for mmc whenever you have acked
> them (at least more non-trivial changes). I regards to the
> mmc-controller.yaml file, I have no queued changes in my tree for this
> cycle so this should be fine in regards to conflicts.
>
> Going forward, do you prefer to pick the DT doc changes for mmc, or
> can I consider this as a single occasion thingy?

I usually only pick up small changes if they are a binding only series
and if they haven't been picked up already.

Though I've been picking up a few schema conversions primarily so I
can check that they validate. Hopefully that's temporary.

Rob

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, back to index

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-19 14:58 [PATCH] dt-bindings: mmc: clarify disable-wp text Johan Jonker
2019-12-28  9:30 ` [PATCH v2 1/2] dt-bindings: mmc: remove identical phrase in " Johan Jonker
2019-12-28  9:30   ` [PATCH v2 2/2] dt-bindings: mmc: clarify " Johan Jonker
2020-01-04 21:55     ` Rob Herring
2020-01-04 21:55   ` [PATCH v2 1/2] dt-bindings: mmc: remove identical phrase in " Rob Herring
2020-01-16 11:16     ` Ulf Hansson
2020-01-16 17:18       ` Rob Herring

Linux-mmc Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mmc/0 linux-mmc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mmc linux-mmc/ https://lore.kernel.org/linux-mmc \
		linux-mmc@vger.kernel.org
	public-inbox-index linux-mmc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-mmc


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git