* [PATCH] mmc: renesas_sdhi: Use BITS_PER_LONG helper
@ 2020-03-02 9:35 Geert Uytterhoeven
2020-03-03 12:48 ` Niklas Söderlund
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2020-03-02 9:35 UTC (permalink / raw)
To: Wolfram Sang, Ulf Hansson
Cc: linux-mmc, linux-renesas-soc, Geert Uytterhoeven
Use the existing BITS_PER_LONG helper definition instead of calculating
this value.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/mmc/host/renesas_sdhi.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/renesas_sdhi.h b/drivers/mmc/host/renesas_sdhi.h
index 7a1a741547f25de5..2a4c83a5f32ef8e2 100644
--- a/drivers/mmc/host/renesas_sdhi.h
+++ b/drivers/mmc/host/renesas_sdhi.h
@@ -60,7 +60,7 @@ struct renesas_sdhi {
bool doing_tune;
/* Tuning values: 1 for success, 0 for failure */
- DECLARE_BITMAP(taps, BITS_PER_BYTE * sizeof(long));
+ DECLARE_BITMAP(taps, BITS_PER_LONG);
unsigned int tap_num;
unsigned long tap_set;
};
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: renesas_sdhi: Use BITS_PER_LONG helper
2020-03-02 9:35 [PATCH] mmc: renesas_sdhi: Use BITS_PER_LONG helper Geert Uytterhoeven
@ 2020-03-03 12:48 ` Niklas Söderlund
2020-03-03 13:45 ` Wolfram Sang
0 siblings, 1 reply; 3+ messages in thread
From: Niklas Söderlund @ 2020-03-03 12:48 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Wolfram Sang, Ulf Hansson, linux-mmc, linux-renesas-soc
Hi Geert,
Thanks for your work.
On 2020-03-02 10:35:34 +0100, Geert Uytterhoeven wrote:
> Use the existing BITS_PER_LONG helper definition instead of calculating
> this value.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> drivers/mmc/host/renesas_sdhi.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/renesas_sdhi.h b/drivers/mmc/host/renesas_sdhi.h
> index 7a1a741547f25de5..2a4c83a5f32ef8e2 100644
> --- a/drivers/mmc/host/renesas_sdhi.h
> +++ b/drivers/mmc/host/renesas_sdhi.h
> @@ -60,7 +60,7 @@ struct renesas_sdhi {
> bool doing_tune;
>
> /* Tuning values: 1 for success, 0 for failure */
> - DECLARE_BITMAP(taps, BITS_PER_BYTE * sizeof(long));
> + DECLARE_BITMAP(taps, BITS_PER_LONG);
> unsigned int tap_num;
> unsigned long tap_set;
> };
> --
> 2.17.1
>
--
Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: renesas_sdhi: Use BITS_PER_LONG helper
2020-03-03 12:48 ` Niklas Söderlund
@ 2020-03-03 13:45 ` Wolfram Sang
0 siblings, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2020-03-03 13:45 UTC (permalink / raw)
To: Niklas Söderlund
Cc: Geert Uytterhoeven, Wolfram Sang, Ulf Hansson, linux-mmc,
linux-renesas-soc
[-- Attachment #1: Type: text/plain, Size: 482 bytes --]
On Tue, Mar 03, 2020 at 01:48:42PM +0100, Niklas Söderlund wrote:
> Hi Geert,
>
> Thanks for your work.
>
> On 2020-03-02 10:35:34 +0100, Geert Uytterhoeven wrote:
> > Use the existing BITS_PER_LONG helper definition instead of calculating
> > this value.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-03 13:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-02 9:35 [PATCH] mmc: renesas_sdhi: Use BITS_PER_LONG helper Geert Uytterhoeven
2020-03-03 12:48 ` Niklas Söderlund
2020-03-03 13:45 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).