* [PATCH v5 1/3] dt-bindings: mmc: sdhci-msm: Document the QDU1000/QRU1000 compatible
2023-06-01 11:11 [PATCH v5 0/3] arm64: dts: qcom: qdu1000: add SDHCI Komal Bajaj
@ 2023-06-01 11:11 ` Komal Bajaj
2023-06-08 23:10 ` Ulf Hansson
2023-06-01 11:11 ` [PATCH v5 2/3] arm64: dts: qcom: qdu1000: Add SDHCI node Komal Bajaj
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Komal Bajaj @ 2023-06-01 11:11 UTC (permalink / raw)
To: Ulf Hansson, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Andy Gross, Bjorn Andersson, Konrad Dybcio, Bhupesh Sharma
Cc: Komal Bajaj, linux-mmc, devicetree, linux-kernel, linux-arm-msm
Document the compatible for SDHCI on QDU1000 and QRU1000 SoCs.
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Reviewed-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com>
---
Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
index 4f2d9e8127dd..af29d60ff0d6 100644
--- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
+++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
@@ -39,6 +39,7 @@ properties:
- qcom,ipq9574-sdhci
- qcom,qcm2290-sdhci
- qcom,qcs404-sdhci
+ - qcom,qdu1000-sdhci
- qcom,sc7180-sdhci
- qcom,sc7280-sdhci
- qcom,sdm630-sdhci
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v5 1/3] dt-bindings: mmc: sdhci-msm: Document the QDU1000/QRU1000 compatible
2023-06-01 11:11 ` [PATCH v5 1/3] dt-bindings: mmc: sdhci-msm: Document the QDU1000/QRU1000 compatible Komal Bajaj
@ 2023-06-08 23:10 ` Ulf Hansson
0 siblings, 0 replies; 6+ messages in thread
From: Ulf Hansson @ 2023-06-08 23:10 UTC (permalink / raw)
To: Komal Bajaj
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Bhupesh Sharma, linux-mmc,
devicetree, linux-kernel, linux-arm-msm
On Thu, 1 Jun 2023 at 13:11, Komal Bajaj <quic_kbajaj@quicinc.com> wrote:
>
> Document the compatible for SDHCI on QDU1000 and QRU1000 SoCs.
>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> Reviewed-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
> index 4f2d9e8127dd..af29d60ff0d6 100644
> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
> @@ -39,6 +39,7 @@ properties:
> - qcom,ipq9574-sdhci
> - qcom,qcm2290-sdhci
> - qcom,qcs404-sdhci
> + - qcom,qdu1000-sdhci
> - qcom,sc7180-sdhci
> - qcom,sc7280-sdhci
> - qcom,sdm630-sdhci
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v5 2/3] arm64: dts: qcom: qdu1000: Add SDHCI node
2023-06-01 11:11 [PATCH v5 0/3] arm64: dts: qcom: qdu1000: add SDHCI Komal Bajaj
2023-06-01 11:11 ` [PATCH v5 1/3] dt-bindings: mmc: sdhci-msm: Document the QDU1000/QRU1000 compatible Komal Bajaj
@ 2023-06-01 11:11 ` Komal Bajaj
2023-06-01 11:11 ` [PATCH v5 3/3] arm64: dts: qcom: qdu1000-idp: add SDHCI for emmc Komal Bajaj
2023-06-13 23:48 ` (subset) [PATCH v5 0/3] arm64: dts: qcom: qdu1000: add SDHCI Bjorn Andersson
3 siblings, 0 replies; 6+ messages in thread
From: Komal Bajaj @ 2023-06-01 11:11 UTC (permalink / raw)
To: Ulf Hansson, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Andy Gross, Bjorn Andersson, Konrad Dybcio, Bhupesh Sharma
Cc: Komal Bajaj, linux-mmc, devicetree, linux-kernel, linux-arm-msm
Add sdhc node for eMMC on QDU1000 and QRU1000 SoCs. Also add
required pins for SDHCI, so that the interface can work reliably.
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com>
---
arch/arm64/boot/dts/qcom/qdu1000.dtsi | 97 +++++++++++++++++++++++++++
1 file changed, 97 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/qdu1000.dtsi b/arch/arm64/boot/dts/qcom/qdu1000.dtsi
index 734438113bba..9f615f3368c2 100644
--- a/arch/arm64/boot/dts/qcom/qdu1000.dtsi
+++ b/arch/arm64/boot/dts/qcom/qdu1000.dtsi
@@ -842,6 +842,53 @@
#hwlock-cells = <1>;
};
+ sdhc: mmc@8804000 {
+ compatible = "qcom,qdu1000-sdhci", "qcom,sdhci-msm-v5";
+ reg = <0x0 0x08804000 0x0 0x1000>,
+ <0x0 0x08805000 0x0 0x1000>;
+ reg-names = "hc", "cqhci";
+
+ interrupts = <GIC_SPI 207 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 223 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "hc_irq", "pwr_irq";
+
+ clocks = <&gcc GCC_SDCC5_AHB_CLK>,
+ <&gcc GCC_SDCC5_APPS_CLK>,
+ <&rpmhcc RPMH_CXO_CLK>;
+ clock-names = "iface",
+ "core",
+ "xo";
+
+ resets = <&gcc GCC_SDCC5_BCR>;
+
+ interconnects = <&system_noc MASTER_SDCC_1 0 &mc_virt SLAVE_EBI1 0>,
+ <&gem_noc MASTER_APPSS_PROC 0 &system_noc SLAVE_SDCC_2 0>;
+ interconnect-names = "sdhc-ddr", "cpu-sdhc";
+ power-domains = <&rpmhpd QDU1000_CX>;
+ operating-points-v2 = <&sdhc1_opp_table>;
+
+ iommus = <&apps_smmu 0x80 0x0>;
+ dma-coherent;
+
+ bus-width = <8>;
+
+ qcom,dll-config = <0x0007642c>;
+ qcom,ddr-config = <0x80040868>;
+
+ status = "disabled";
+
+ sdhc1_opp_table: opp-table {
+ compatible = "operating-points-v2";
+
+ opp-384000000 {
+ opp-hz = /bits/ 64 <384000000>;
+ required-opps = <&rpmhpd_opp_nom>;
+ opp-peak-kBps = <6528000 1652800>;
+ opp-avg-kBps = <400000 0>;
+ };
+ };
+ };
+
pdc: interrupt-controller@b220000 {
compatible = "qcom,qdu1000-pdc", "qcom,pdc";
reg = <0x0 0xb220000 0x0 0x30000>, <0x0 0x174000f0 0x0 0x64>;
@@ -1100,6 +1147,56 @@
pins = "gpio31";
function = "gpio";
};
+
+ sdc_on_state: sdc-on-state {
+ clk-pins {
+ pins = "sdc1_clk";
+ drive-strength = <16>;
+ bias-disable;
+ };
+
+ cmd-pins {
+ pins = "sdc1_cmd";
+ drive-strength = <10>;
+ bias-pull-up;
+ };
+
+ data-pins {
+ pins = "sdc1_data";
+ drive-strength = <10>;
+ bias-pull-up;
+ };
+
+ rclk-pins {
+ pins = "sdc1_rclk";
+ bias-pull-down;
+ };
+ };
+
+ sdc_off_state: sdc-off-state {
+ clk-pins {
+ pins = "sdc1_clk";
+ drive-strength = <2>;
+ bias-disable;
+ };
+
+ cmd-pins {
+ pins = "sdc1_cmd";
+ drive-strength = <2>;
+ bias-pull-up;
+ };
+
+ data-pins {
+ pins = "sdc1_data";
+ drive-strength = <2>;
+ bias-pull-up;
+ };
+
+ rclk-pins {
+ pins = "sdc1_rclk";
+ bias-pull-down;
+ };
+ };
};
apps_smmu: iommu@15000000 {
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v5 3/3] arm64: dts: qcom: qdu1000-idp: add SDHCI for emmc
2023-06-01 11:11 [PATCH v5 0/3] arm64: dts: qcom: qdu1000: add SDHCI Komal Bajaj
2023-06-01 11:11 ` [PATCH v5 1/3] dt-bindings: mmc: sdhci-msm: Document the QDU1000/QRU1000 compatible Komal Bajaj
2023-06-01 11:11 ` [PATCH v5 2/3] arm64: dts: qcom: qdu1000: Add SDHCI node Komal Bajaj
@ 2023-06-01 11:11 ` Komal Bajaj
2023-06-13 23:48 ` (subset) [PATCH v5 0/3] arm64: dts: qcom: qdu1000: add SDHCI Bjorn Andersson
3 siblings, 0 replies; 6+ messages in thread
From: Komal Bajaj @ 2023-06-01 11:11 UTC (permalink / raw)
To: Ulf Hansson, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Andy Gross, Bjorn Andersson, Konrad Dybcio, Bhupesh Sharma
Cc: Komal Bajaj, linux-mmc, devicetree, linux-kernel, linux-arm-msm
Add sdhci node for emmc in qdu1000-idp.
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com>
---
arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
index 9e9fd4b8023e..1d22f87fd238 100644
--- a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
+++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
@@ -448,6 +448,29 @@
status = "okay";
};
+&sdhc {
+ pinctrl-0 = <&sdc_on_state>;
+ pinctrl-1 = <&sdc_off_state>;
+ pinctrl-names = "default", "sleep";
+
+ cap-mmc-hw-reset;
+ mmc-ddr-1_8v;
+ mmc-hs200-1_8v;
+ mmc-hs400-1_8v;
+ mmc-hs400-enhanced-strobe;
+
+ non-removable;
+ no-sd;
+ no-sdio;
+
+ supports-cqe;
+
+ vmmc-supply = <&vreg_l10a_2p95>;
+ vqmmc-supply = <&vreg_l7a_1p8>;
+
+ status = "okay";
+};
+
&uart7 {
status = "okay";
};
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: (subset) [PATCH v5 0/3] arm64: dts: qcom: qdu1000: add SDHCI
2023-06-01 11:11 [PATCH v5 0/3] arm64: dts: qcom: qdu1000: add SDHCI Komal Bajaj
` (2 preceding siblings ...)
2023-06-01 11:11 ` [PATCH v5 3/3] arm64: dts: qcom: qdu1000-idp: add SDHCI for emmc Komal Bajaj
@ 2023-06-13 23:48 ` Bjorn Andersson
3 siblings, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2023-06-13 23:48 UTC (permalink / raw)
To: Bhupesh Sharma, Krzysztof Kozlowski, Ulf Hansson, Andy Gross,
Komal Bajaj, Rob Herring, Conor Dooley, Konrad Dybcio
Cc: linux-arm-msm, devicetree, linux-mmc, linux-kernel
On Thu, 1 Jun 2023 16:41:25 +0530, Komal Bajaj wrote:
> Changes in v5 -
> * Combined sdhc node addition and pin configuration into one commit.
>
> Changes in v4 -
> * Fixed the subject prefix to arm64.
> * Updated the pinctrl entries alphabetically.
>
> [...]
Applied, thanks!
[2/3] arm64: dts: qcom: qdu1000: Add SDHCI node
commit: 90c8c4eb4bbb5e2e241fd5286bd43dd30a850b9d
[3/3] arm64: dts: qcom: qdu1000-idp: add SDHCI for emmc
commit: 6901ff9987469fa33d06990463adc8a63f8be5d0
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread