From: Matthias Brugger <matthias.bgg@gmail.com>
To: "Pali Rohár" <pali@kernel.org>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org
Cc: "Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Kalle Valo" <kvalo@codeaurora.org>,
"Amitkumar Karwar" <amitkarwar@gmail.com>,
"Ganapathi Bhat" <ganapathi.bhat@nxp.com>,
"Xinming Hu" <huxinming820@gmail.com>,
linux-kernel@vger.kernel.org, ath10k@lists.infradead.org,
b43-dev@lists.infradead.org, brcm80211-dev-list.pdl@broadcom.com,
brcm80211-dev-list@cypress.com, libertas-dev@lists.infradead.org,
linux-wireless@vger.kernel.org,
"Marek Behún" <marek.behun@nic.cz>,
"Sean Wang" <sean.wang@mediatek.com>
Subject: Re: [PATCH 05/11] mmc: sdio: Move SDIO IDs from btmtksdio driver to common include file
Date: Fri, 22 May 2020 17:02:11 +0200 [thread overview]
Message-ID: <804fbad7-11ba-8d8b-d58e-3eb4e5cf2b41@gmail.com> (raw)
In-Reply-To: <20200522144412.19712-6-pali@kernel.org>
On 22/05/2020 16:44, Pali Rohár wrote:
> Define appropriate macro names for consistency with other macros.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> drivers/bluetooth/btmtksdio.c | 4 ++--
> include/linux/mmc/sdio_ids.h | 2 ++
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bluetooth/btmtksdio.c b/drivers/bluetooth/btmtksdio.c
> index 519788c442ca..bff095be2f97 100644
> --- a/drivers/bluetooth/btmtksdio.c
> +++ b/drivers/bluetooth/btmtksdio.c
> @@ -51,9 +51,9 @@ static const struct btmtksdio_data mt7668_data = {
> };
>
> static const struct sdio_device_id btmtksdio_table[] = {
> - {SDIO_DEVICE(SDIO_VENDOR_ID_MEDIATEK, 0x7663),
> + {SDIO_DEVICE(SDIO_VENDOR_ID_MEDIATEK, SDIO_DEVICE_ID_MEDIATEK_MT7663),
> .driver_data = (kernel_ulong_t)&mt7663_data },
> - {SDIO_DEVICE(SDIO_VENDOR_ID_MEDIATEK, 0x7668),
> + {SDIO_DEVICE(SDIO_VENDOR_ID_MEDIATEK, SDIO_DEVICE_ID_MEDIATEK_MT7668),
> .driver_data = (kernel_ulong_t)&mt7668_data },
> { } /* Terminating entry */
> };
> diff --git a/include/linux/mmc/sdio_ids.h b/include/linux/mmc/sdio_ids.h
> index 1237e1048d06..c9aca57d4dea 100644
> --- a/include/linux/mmc/sdio_ids.h
> +++ b/include/linux/mmc/sdio_ids.h
> @@ -80,6 +80,8 @@
> #define SDIO_DEVICE_ID_MARVELL_8987_BT 0x914a
>
> #define SDIO_VENDOR_ID_MEDIATEK 0x037a
> +#define SDIO_DEVICE_ID_MEDIATEK_MT7663 0x7663
> +#define SDIO_DEVICE_ID_MEDIATEK_MT7668 0x7668
>
> #define SDIO_VENDOR_ID_SIANO 0x039a
> #define SDIO_DEVICE_ID_SIANO_NOVA_B0 0x0201
>
next prev parent reply other threads:[~2020-05-22 15:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 14:44 [PATCH 00/11] mmc: sdio: Move SDIO IDs from drivers to common include file Pali Rohár
2020-05-22 14:44 ` [PATCH 01/11] mmc: sdio: Fix macro name for Marvell device with ID 0x9134 Pali Rohár
2020-05-29 3:28 ` [EXT] " Ganapathi Bhat
2020-05-22 14:44 ` [PATCH 02/11] mmc: sdio: Change macro names for Marvell 8688 modules Pali Rohár
2020-05-28 12:32 ` [EXT] " Ganapathi Bhat
2020-05-22 14:44 ` [PATCH 03/11] mmc: sdio: Move SDIO IDs from mwifiex driver to common include file Pali Rohár
2020-05-25 10:38 ` Kalle Valo
2020-05-28 12:29 ` [EXT] " Ganapathi Bhat
2020-05-22 14:44 ` [PATCH 04/11] mmc: sdio: Move SDIO IDs from btmrvl " Pali Rohár
2020-05-28 12:27 ` [EXT] " Ganapathi Bhat
2020-05-22 14:44 ` [PATCH 05/11] mmc: sdio: Move SDIO IDs from btmtksdio " Pali Rohár
2020-05-22 15:02 ` Matthias Brugger [this message]
2020-05-22 14:44 ` [PATCH 06/11] mmc: sdio: Move SDIO IDs from smssdio " Pali Rohár
2020-05-22 14:44 ` [PATCH 07/11] mmc: sdio: Move SDIO IDs from ath6kl " Pali Rohár
2020-05-25 10:38 ` Kalle Valo
2020-05-22 14:44 ` [PATCH 08/11] mmc: sdio: Move SDIO IDs from ath10k " Pali Rohár
2020-05-22 14:44 ` [PATCH 09/11] mmc: sdio: Move SDIO IDs from b43-sdio " Pali Rohár
2020-05-22 14:44 ` [PATCH 10/11] mmc: sdio: Fix Cypress SDIO IDs macros in " Pali Rohár
2020-05-22 14:44 ` [PATCH 11/11] mmc: sdio: Sort all SDIO IDs " Pali Rohár
2020-05-25 7:15 ` [PATCH 00/11] mmc: sdio: Move SDIO IDs from drivers to " Ulf Hansson
2020-05-28 10:13 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=804fbad7-11ba-8d8b-d58e-3eb4e5cf2b41@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=amitkarwar@gmail.com \
--cc=ath10k@lists.infradead.org \
--cc=b43-dev@lists.infradead.org \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=ganapathi.bhat@nxp.com \
--cc=huxinming820@gmail.com \
--cc=kvalo@codeaurora.org \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=marek.behun@nic.cz \
--cc=mchehab@kernel.org \
--cc=pali@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).