Linux-mmc Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] mmc: sdhci-s3c: remove unused ext_cd_gpio field
@ 2019-12-09 18:37 Michał Mirosław
  2019-12-12  8:57 ` Adrian Hunter
  2019-12-18 14:01 ` Ulf Hansson
  0 siblings, 2 replies; 3+ messages in thread
From: Michał Mirosław @ 2019-12-09 18:37 UTC (permalink / raw)
  To: linux-mmc
  Cc: Ulf Hansson, Ben Dooks, Jaehoon Chung, Adrian Hunter, linux-kernel

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
---
 drivers/mmc/host/sdhci-s3c.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
index 51e096f27388..8b15945dd499 100644
--- a/drivers/mmc/host/sdhci-s3c.c
+++ b/drivers/mmc/host/sdhci-s3c.c
@@ -117,7 +117,6 @@ struct sdhci_s3c {
 	struct s3c_sdhci_platdata *pdata;
 	int			cur_clk;
 	int			ext_cd_irq;
-	int			ext_cd_gpio;
 
 	struct clk		*clk_io;
 	struct clk		*clk_bus[MAX_BUS_CLK];
@@ -512,7 +511,6 @@ static int sdhci_s3c_probe(struct platform_device *pdev)
 			goto err_pdata_io_clk;
 	} else {
 		memcpy(pdata, pdev->dev.platform_data, sizeof(*pdata));
-		sc->ext_cd_gpio = -1; /* invalid gpio number */
 	}
 
 	drv_data = sdhci_s3c_get_driver_data(pdev);
-- 
2.20.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mmc: sdhci-s3c: remove unused ext_cd_gpio field
  2019-12-09 18:37 [PATCH] mmc: sdhci-s3c: remove unused ext_cd_gpio field Michał Mirosław
@ 2019-12-12  8:57 ` Adrian Hunter
  2019-12-18 14:01 ` Ulf Hansson
  1 sibling, 0 replies; 3+ messages in thread
From: Adrian Hunter @ 2019-12-12  8:57 UTC (permalink / raw)
  To: Michał Mirosław, linux-mmc
  Cc: Ulf Hansson, Ben Dooks, Jaehoon Chung, linux-kernel

On 9/12/19 8:37 pm, Michał Mirosław wrote:
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

> ---
>  drivers/mmc/host/sdhci-s3c.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
> index 51e096f27388..8b15945dd499 100644
> --- a/drivers/mmc/host/sdhci-s3c.c
> +++ b/drivers/mmc/host/sdhci-s3c.c
> @@ -117,7 +117,6 @@ struct sdhci_s3c {
>  	struct s3c_sdhci_platdata *pdata;
>  	int			cur_clk;
>  	int			ext_cd_irq;
> -	int			ext_cd_gpio;
>  
>  	struct clk		*clk_io;
>  	struct clk		*clk_bus[MAX_BUS_CLK];
> @@ -512,7 +511,6 @@ static int sdhci_s3c_probe(struct platform_device *pdev)
>  			goto err_pdata_io_clk;
>  	} else {
>  		memcpy(pdata, pdev->dev.platform_data, sizeof(*pdata));
> -		sc->ext_cd_gpio = -1; /* invalid gpio number */
>  	}
>  
>  	drv_data = sdhci_s3c_get_driver_data(pdev);
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mmc: sdhci-s3c: remove unused ext_cd_gpio field
  2019-12-09 18:37 [PATCH] mmc: sdhci-s3c: remove unused ext_cd_gpio field Michał Mirosław
  2019-12-12  8:57 ` Adrian Hunter
@ 2019-12-18 14:01 ` Ulf Hansson
  1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2019-12-18 14:01 UTC (permalink / raw)
  To: Michał Mirosław
  Cc: linux-mmc, Ben Dooks, Jaehoon Chung, Adrian Hunter,
	Linux Kernel Mailing List

On Mon, 9 Dec 2019 at 19:37, Michał Mirosław <mirq-linux@rere.qmqm.pl> wrote:
>
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/sdhci-s3c.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
> index 51e096f27388..8b15945dd499 100644
> --- a/drivers/mmc/host/sdhci-s3c.c
> +++ b/drivers/mmc/host/sdhci-s3c.c
> @@ -117,7 +117,6 @@ struct sdhci_s3c {
>         struct s3c_sdhci_platdata *pdata;
>         int                     cur_clk;
>         int                     ext_cd_irq;
> -       int                     ext_cd_gpio;
>
>         struct clk              *clk_io;
>         struct clk              *clk_bus[MAX_BUS_CLK];
> @@ -512,7 +511,6 @@ static int sdhci_s3c_probe(struct platform_device *pdev)
>                         goto err_pdata_io_clk;
>         } else {
>                 memcpy(pdata, pdev->dev.platform_data, sizeof(*pdata));
> -               sc->ext_cd_gpio = -1; /* invalid gpio number */
>         }
>
>         drv_data = sdhci_s3c_get_driver_data(pdev);
> --
> 2.20.1
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-09 18:37 [PATCH] mmc: sdhci-s3c: remove unused ext_cd_gpio field Michał Mirosław
2019-12-12  8:57 ` Adrian Hunter
2019-12-18 14:01 ` Ulf Hansson

Linux-mmc Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mmc/0 linux-mmc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mmc linux-mmc/ https://lore.kernel.org/linux-mmc \
		linux-mmc@vger.kernel.org
	public-inbox-index linux-mmc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-mmc


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git