* [PATCH] mmc: mediatek: Avoid ugly error message when SDIO wakeup IRQ isn't used
@ 2023-05-10 13:44 Douglas Anderson
2023-05-10 14:19 ` Matthias Brugger
2023-05-24 13:10 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Douglas Anderson @ 2023-05-10 13:44 UTC (permalink / raw)
To: Chaotian Jing, Ulf Hansson
Cc: Douglas Anderson, AngeloGioacchino Del Regno, Linus Walleij,
Matthias Brugger, Yong Mao, linux-arm-kernel, linux-kernel,
linux-mediatek, linux-mmc
When I boot a kukui-kodama board, I see an ugly warning in my kernel
log:
mtk-msdc 11240000.mmc: error -ENXIO: IRQ sdio_wakeup not found
It's pretty normal not to have an "sdio_wakeup" IRQ defined. In fact,
no device trees in mainline seem to have it. Let's use the
platform_get_irq_byname_optional() to avoid the error message.
Fixes: 527f36f5efa4 ("mmc: mediatek: add support for SDIO eint wakup IRQ")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
drivers/mmc/host/mtk-sd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index edade0e54a0c..8ce864169986 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -2707,7 +2707,7 @@ static int msdc_drv_probe(struct platform_device *pdev)
/* Support for SDIO eint irq ? */
if ((mmc->pm_caps & MMC_PM_WAKE_SDIO_IRQ) && (mmc->pm_caps & MMC_PM_KEEP_POWER)) {
- host->eint_irq = platform_get_irq_byname(pdev, "sdio_wakeup");
+ host->eint_irq = platform_get_irq_byname_optional(pdev, "sdio_wakeup");
if (host->eint_irq > 0) {
host->pins_eint = pinctrl_lookup_state(host->pinctrl, "state_eint");
if (IS_ERR(host->pins_eint)) {
--
2.40.1.521.gf1e218fcd8-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: mediatek: Avoid ugly error message when SDIO wakeup IRQ isn't used
2023-05-10 13:44 [PATCH] mmc: mediatek: Avoid ugly error message when SDIO wakeup IRQ isn't used Douglas Anderson
@ 2023-05-10 14:19 ` Matthias Brugger
2023-05-24 13:10 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Matthias Brugger @ 2023-05-10 14:19 UTC (permalink / raw)
To: Douglas Anderson, Chaotian Jing, Ulf Hansson
Cc: AngeloGioacchino Del Regno, Linus Walleij, Yong Mao,
linux-arm-kernel, linux-kernel, linux-mediatek, linux-mmc
On 10/05/2023 15:44, Douglas Anderson wrote:
> When I boot a kukui-kodama board, I see an ugly warning in my kernel
> log:
> mtk-msdc 11240000.mmc: error -ENXIO: IRQ sdio_wakeup not found
>
> It's pretty normal not to have an "sdio_wakeup" IRQ defined. In fact,
> no device trees in mainline seem to have it. Let's use the
> platform_get_irq_byname_optional() to avoid the error message.
>
> Fixes: 527f36f5efa4 ("mmc: mediatek: add support for SDIO eint wakup IRQ")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
>
> drivers/mmc/host/mtk-sd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index edade0e54a0c..8ce864169986 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -2707,7 +2707,7 @@ static int msdc_drv_probe(struct platform_device *pdev)
>
> /* Support for SDIO eint irq ? */
> if ((mmc->pm_caps & MMC_PM_WAKE_SDIO_IRQ) && (mmc->pm_caps & MMC_PM_KEEP_POWER)) {
> - host->eint_irq = platform_get_irq_byname(pdev, "sdio_wakeup");
> + host->eint_irq = platform_get_irq_byname_optional(pdev, "sdio_wakeup");
> if (host->eint_irq > 0) {
> host->pins_eint = pinctrl_lookup_state(host->pinctrl, "state_eint");
> if (IS_ERR(host->pins_eint)) {
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: mediatek: Avoid ugly error message when SDIO wakeup IRQ isn't used
2023-05-10 13:44 [PATCH] mmc: mediatek: Avoid ugly error message when SDIO wakeup IRQ isn't used Douglas Anderson
2023-05-10 14:19 ` Matthias Brugger
@ 2023-05-24 13:10 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2023-05-24 13:10 UTC (permalink / raw)
To: Douglas Anderson
Cc: Chaotian Jing, AngeloGioacchino Del Regno, Linus Walleij,
Matthias Brugger, Yong Mao, linux-arm-kernel, linux-kernel,
linux-mediatek, linux-mmc
On Wed, 10 May 2023 at 15:46, Douglas Anderson <dianders@chromium.org> wrote:
>
> When I boot a kukui-kodama board, I see an ugly warning in my kernel
> log:
> mtk-msdc 11240000.mmc: error -ENXIO: IRQ sdio_wakeup not found
>
> It's pretty normal not to have an "sdio_wakeup" IRQ defined. In fact,
> no device trees in mainline seem to have it. Let's use the
> platform_get_irq_byname_optional() to avoid the error message.
>
> Fixes: 527f36f5efa4 ("mmc: mediatek: add support for SDIO eint wakup IRQ")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
Applied for next, thanks!
Kind regards
Uffe
> ---
>
> drivers/mmc/host/mtk-sd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index edade0e54a0c..8ce864169986 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -2707,7 +2707,7 @@ static int msdc_drv_probe(struct platform_device *pdev)
>
> /* Support for SDIO eint irq ? */
> if ((mmc->pm_caps & MMC_PM_WAKE_SDIO_IRQ) && (mmc->pm_caps & MMC_PM_KEEP_POWER)) {
> - host->eint_irq = platform_get_irq_byname(pdev, "sdio_wakeup");
> + host->eint_irq = platform_get_irq_byname_optional(pdev, "sdio_wakeup");
> if (host->eint_irq > 0) {
> host->pins_eint = pinctrl_lookup_state(host->pinctrl, "state_eint");
> if (IS_ERR(host->pins_eint)) {
> --
> 2.40.1.521.gf1e218fcd8-goog
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-24 13:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-10 13:44 [PATCH] mmc: mediatek: Avoid ugly error message when SDIO wakeup IRQ isn't used Douglas Anderson
2023-05-10 14:19 ` Matthias Brugger
2023-05-24 13:10 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).