* [PATCH] mmc: core: disable TRIM on Micron MTFC4GACAJCN-1M
@ 2023-05-30 21:32 Robert Marko
2023-05-31 5:30 ` Avri Altman
2023-06-08 22:18 ` Ulf Hansson
0 siblings, 2 replies; 5+ messages in thread
From: Robert Marko @ 2023-05-30 21:32 UTC (permalink / raw)
To: ulf.hansson, windhl, avri.altman, linux-mmc, linux-kernel; +Cc: Robert Marko
It seems that Micron MTFC4GACAJCN-1M despite advertising TRIM support does
not work when the core is trying to use REQ_OP_WRITE_ZEROES.
We are seeing the following errors in OpenWrt under 6.1 on Qnap Qhora 301W
that we did not previously have and tracked it down to REQ_OP_WRITE_ZEROES:
[ 18.085950] I/O error, dev loop0, sector 596 op 0x9:(WRITE_ZEROES) flags 0x800 phys_seg 0 prio class 2
Disabling TRIM makes the error go away, so lets add a quirk for this eMMC
to disable TRIM.
Signed-off-by: Robert Marko <robimarko@gmail.com>
---
drivers/mmc/core/quirks.h | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/mmc/core/quirks.h b/drivers/mmc/core/quirks.h
index 29b9497936df..77caa0c903f8 100644
--- a/drivers/mmc/core/quirks.h
+++ b/drivers/mmc/core/quirks.h
@@ -100,6 +100,13 @@ static const struct mmc_fixup __maybe_unused mmc_blk_fixups[] = {
MMC_FIXUP("V10016", CID_MANFID_KINGSTON, CID_OEMID_ANY, add_quirk_mmc,
MMC_QUIRK_TRIM_BROKEN),
+ /*
+ * Micron MTFC4GACAJCN-1M advertises TRIM but it does not seems to
+ * support being used to offload WRITE_ZEROES.
+ */
+ MMC_FIXUP("Q2J54A", CID_MANFID_MICRON, 0x014e, add_quirk_mmc,
+ MMC_QUIRK_TRIM_BROKEN),
+
/*
* Some SD cards reports discard support while they don't
*/
--
2.40.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* RE: [PATCH] mmc: core: disable TRIM on Micron MTFC4GACAJCN-1M
2023-05-30 21:32 [PATCH] mmc: core: disable TRIM on Micron MTFC4GACAJCN-1M Robert Marko
@ 2023-05-31 5:30 ` Avri Altman
2023-06-08 22:18 ` Ulf Hansson
1 sibling, 0 replies; 5+ messages in thread
From: Avri Altman @ 2023-05-31 5:30 UTC (permalink / raw)
To: Robert Marko, ulf.hansson, windhl, linux-mmc, linux-kernel
Cc: Bean Huo (beanhuo)
+Bean
Thanks,
Avri
> It seems that Micron MTFC4GACAJCN-1M despite advertising TRIM support
> does not work when the core is trying to use REQ_OP_WRITE_ZEROES.
>
> We are seeing the following errors in OpenWrt under 6.1 on Qnap Qhora
> 301W that we did not previously have and tracked it down to
> REQ_OP_WRITE_ZEROES:
> [ 18.085950] I/O error, dev loop0, sector 596 op 0x9:(WRITE_ZEROES) flags
> 0x800 phys_seg 0 prio class 2
>
> Disabling TRIM makes the error go away, so lets add a quirk for this eMMC to
> disable TRIM.
>
> Signed-off-by: Robert Marko <robimarko@gmail.com>
> ---
> drivers/mmc/core/quirks.h | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/mmc/core/quirks.h b/drivers/mmc/core/quirks.h index
> 29b9497936df..77caa0c903f8 100644
> --- a/drivers/mmc/core/quirks.h
> +++ b/drivers/mmc/core/quirks.h
> @@ -100,6 +100,13 @@ static const struct mmc_fixup __maybe_unused
> mmc_blk_fixups[] = {
> MMC_FIXUP("V10016", CID_MANFID_KINGSTON, CID_OEMID_ANY,
> add_quirk_mmc,
> MMC_QUIRK_TRIM_BROKEN),
>
> + /*
> + * Micron MTFC4GACAJCN-1M advertises TRIM but it does not seems to
> + * support being used to offload WRITE_ZEROES.
> + */
> + MMC_FIXUP("Q2J54A", CID_MANFID_MICRON, 0x014e, add_quirk_mmc,
> + MMC_QUIRK_TRIM_BROKEN),
> +
> /*
> * Some SD cards reports discard support while they don't
> */
> --
> 2.40.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] mmc: core: disable TRIM on Micron MTFC4GACAJCN-1M
2023-05-30 21:32 [PATCH] mmc: core: disable TRIM on Micron MTFC4GACAJCN-1M Robert Marko
2023-05-31 5:30 ` Avri Altman
@ 2023-06-08 22:18 ` Ulf Hansson
2023-06-19 11:43 ` Ulf Hansson
1 sibling, 1 reply; 5+ messages in thread
From: Ulf Hansson @ 2023-06-08 22:18 UTC (permalink / raw)
To: Robert Marko, Luca Porzio (lporzio)
Cc: windhl, avri.altman, linux-mmc, linux-kernel
+ Luca (Bean was added by Avri in another thread)
On Tue, 30 May 2023 at 23:33, Robert Marko <robimarko@gmail.com> wrote:
>
> It seems that Micron MTFC4GACAJCN-1M despite advertising TRIM support does
> not work when the core is trying to use REQ_OP_WRITE_ZEROES.
>
> We are seeing the following errors in OpenWrt under 6.1 on Qnap Qhora 301W
> that we did not previously have and tracked it down to REQ_OP_WRITE_ZEROES:
> [ 18.085950] I/O error, dev loop0, sector 596 op 0x9:(WRITE_ZEROES) flags 0x800 phys_seg 0 prio class 2
>
> Disabling TRIM makes the error go away, so lets add a quirk for this eMMC
> to disable TRIM.
Let's leave this another week or so, to allow Micron folkz to confirm
before applying.
>
> Signed-off-by: Robert Marko <robimarko@gmail.com>
Kind regards
Uffe
> ---
> drivers/mmc/core/quirks.h | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/mmc/core/quirks.h b/drivers/mmc/core/quirks.h
> index 29b9497936df..77caa0c903f8 100644
> --- a/drivers/mmc/core/quirks.h
> +++ b/drivers/mmc/core/quirks.h
> @@ -100,6 +100,13 @@ static const struct mmc_fixup __maybe_unused mmc_blk_fixups[] = {
> MMC_FIXUP("V10016", CID_MANFID_KINGSTON, CID_OEMID_ANY, add_quirk_mmc,
> MMC_QUIRK_TRIM_BROKEN),
>
> + /*
> + * Micron MTFC4GACAJCN-1M advertises TRIM but it does not seems to
> + * support being used to offload WRITE_ZEROES.
> + */
> + MMC_FIXUP("Q2J54A", CID_MANFID_MICRON, 0x014e, add_quirk_mmc,
> + MMC_QUIRK_TRIM_BROKEN),
> +
> /*
> * Some SD cards reports discard support while they don't
> */
> --
> 2.40.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] mmc: core: disable TRIM on Micron MTFC4GACAJCN-1M
2023-06-08 22:18 ` Ulf Hansson
@ 2023-06-19 11:43 ` Ulf Hansson
2023-06-19 19:36 ` Robert Marko
0 siblings, 1 reply; 5+ messages in thread
From: Ulf Hansson @ 2023-06-19 11:43 UTC (permalink / raw)
To: Robert Marko
Cc: Luca Porzio (lporzio), windhl, avri.altman, linux-mmc, linux-kernel
On Fri, 9 Jun 2023 at 00:18, Ulf Hansson <ulf.hansson@linaro.org> wrote:
>
> + Luca (Bean was added by Avri in another thread)
>
> On Tue, 30 May 2023 at 23:33, Robert Marko <robimarko@gmail.com> wrote:
> >
> > It seems that Micron MTFC4GACAJCN-1M despite advertising TRIM support does
> > not work when the core is trying to use REQ_OP_WRITE_ZEROES.
> >
> > We are seeing the following errors in OpenWrt under 6.1 on Qnap Qhora 301W
> > that we did not previously have and tracked it down to REQ_OP_WRITE_ZEROES:
> > [ 18.085950] I/O error, dev loop0, sector 596 op 0x9:(WRITE_ZEROES) flags 0x800 phys_seg 0 prio class 2
> >
> > Disabling TRIM makes the error go away, so lets add a quirk for this eMMC
> > to disable TRIM.
>
> Let's leave this another week or so, to allow Micron folkz to confirm
> before applying.
>
> >
> > Signed-off-by: Robert Marko <robimarko@gmail.com>
Applied for next and by adding a stable tag, thanks!
Kind regards
Uffe
>
> > ---
> > drivers/mmc/core/quirks.h | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/drivers/mmc/core/quirks.h b/drivers/mmc/core/quirks.h
> > index 29b9497936df..77caa0c903f8 100644
> > --- a/drivers/mmc/core/quirks.h
> > +++ b/drivers/mmc/core/quirks.h
> > @@ -100,6 +100,13 @@ static const struct mmc_fixup __maybe_unused mmc_blk_fixups[] = {
> > MMC_FIXUP("V10016", CID_MANFID_KINGSTON, CID_OEMID_ANY, add_quirk_mmc,
> > MMC_QUIRK_TRIM_BROKEN),
> >
> > + /*
> > + * Micron MTFC4GACAJCN-1M advertises TRIM but it does not seems to
> > + * support being used to offload WRITE_ZEROES.
> > + */
> > + MMC_FIXUP("Q2J54A", CID_MANFID_MICRON, 0x014e, add_quirk_mmc,
> > + MMC_QUIRK_TRIM_BROKEN),
> > +
> > /*
> > * Some SD cards reports discard support while they don't
> > */
> > --
> > 2.40.1
> >
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] mmc: core: disable TRIM on Micron MTFC4GACAJCN-1M
2023-06-19 11:43 ` Ulf Hansson
@ 2023-06-19 19:36 ` Robert Marko
0 siblings, 0 replies; 5+ messages in thread
From: Robert Marko @ 2023-06-19 19:36 UTC (permalink / raw)
To: Ulf Hansson
Cc: Luca Porzio (lporzio), windhl, avri.altman, linux-mmc, linux-kernel
On Mon, 19 Jun 2023 at 13:43, Ulf Hansson <ulf.hansson@linaro.org> wrote:
>
> On Fri, 9 Jun 2023 at 00:18, Ulf Hansson <ulf.hansson@linaro.org> wrote:
> >
> > + Luca (Bean was added by Avri in another thread)
> >
> > On Tue, 30 May 2023 at 23:33, Robert Marko <robimarko@gmail.com> wrote:
> > >
> > > It seems that Micron MTFC4GACAJCN-1M despite advertising TRIM support does
> > > not work when the core is trying to use REQ_OP_WRITE_ZEROES.
> > >
> > > We are seeing the following errors in OpenWrt under 6.1 on Qnap Qhora 301W
> > > that we did not previously have and tracked it down to REQ_OP_WRITE_ZEROES:
> > > [ 18.085950] I/O error, dev loop0, sector 596 op 0x9:(WRITE_ZEROES) flags 0x800 phys_seg 0 prio class 2
> > >
> > > Disabling TRIM makes the error go away, so lets add a quirk for this eMMC
> > > to disable TRIM.
> >
> > Let's leave this another week or so, to allow Micron folkz to confirm
> > before applying.
> >
> > >
> > > Signed-off-by: Robert Marko <robimarko@gmail.com>
>
> Applied for next and by adding a stable tag, thanks!
Thanks, I have sent the patch for one of Kingstom eMMC as well that
seems to have TRIM broken
as well.
Regards,
Robert
>
>
> Kind regards
> Uffe
>
> >
> > > ---
> > > drivers/mmc/core/quirks.h | 7 +++++++
> > > 1 file changed, 7 insertions(+)
> > >
> > > diff --git a/drivers/mmc/core/quirks.h b/drivers/mmc/core/quirks.h
> > > index 29b9497936df..77caa0c903f8 100644
> > > --- a/drivers/mmc/core/quirks.h
> > > +++ b/drivers/mmc/core/quirks.h
> > > @@ -100,6 +100,13 @@ static const struct mmc_fixup __maybe_unused mmc_blk_fixups[] = {
> > > MMC_FIXUP("V10016", CID_MANFID_KINGSTON, CID_OEMID_ANY, add_quirk_mmc,
> > > MMC_QUIRK_TRIM_BROKEN),
> > >
> > > + /*
> > > + * Micron MTFC4GACAJCN-1M advertises TRIM but it does not seems to
> > > + * support being used to offload WRITE_ZEROES.
> > > + */
> > > + MMC_FIXUP("Q2J54A", CID_MANFID_MICRON, 0x014e, add_quirk_mmc,
> > > + MMC_QUIRK_TRIM_BROKEN),
> > > +
> > > /*
> > > * Some SD cards reports discard support while they don't
> > > */
> > > --
> > > 2.40.1
> > >
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-06-19 19:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-30 21:32 [PATCH] mmc: core: disable TRIM on Micron MTFC4GACAJCN-1M Robert Marko
2023-05-31 5:30 ` Avri Altman
2023-06-08 22:18 ` Ulf Hansson
2023-06-19 11:43 ` Ulf Hansson
2023-06-19 19:36 ` Robert Marko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).