* [PATCH] mmc: sdhci-of-dwcmshc: Remove useless "&" of th1520_execute_tuning
@ 2024-04-14 16:43 Jisheng Zhang
2024-04-15 6:14 ` Adrian Hunter
2024-04-25 16:21 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Jisheng Zhang @ 2024-04-14 16:43 UTC (permalink / raw)
To: Adrian Hunter, Ulf Hansson; +Cc: linux-mmc, linux-kernel
The preceding "&" before th1520_execute_tuning is useless, remove it.
Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
---
drivers/mmc/host/sdhci-of-dwcmshc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-of-dwcmshc.c b/drivers/mmc/host/sdhci-of-dwcmshc.c
index 7b55acd9830c..6206ff7615e8 100644
--- a/drivers/mmc/host/sdhci-of-dwcmshc.c
+++ b/drivers/mmc/host/sdhci-of-dwcmshc.c
@@ -822,7 +822,7 @@ static const struct sdhci_ops sdhci_dwcmshc_th1520_ops = {
.reset = th1520_sdhci_reset,
.adma_write_desc = dwcmshc_adma_write_desc,
.voltage_switch = dwcmshc_phy_1_8v_init,
- .platform_execute_tuning = &th1520_execute_tuning,
+ .platform_execute_tuning = th1520_execute_tuning,
};
static const struct sdhci_ops sdhci_dwcmshc_cv18xx_ops = {
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: sdhci-of-dwcmshc: Remove useless "&" of th1520_execute_tuning
2024-04-14 16:43 [PATCH] mmc: sdhci-of-dwcmshc: Remove useless "&" of th1520_execute_tuning Jisheng Zhang
@ 2024-04-15 6:14 ` Adrian Hunter
2024-04-25 16:21 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Adrian Hunter @ 2024-04-15 6:14 UTC (permalink / raw)
To: Jisheng Zhang, Ulf Hansson; +Cc: linux-mmc, linux-kernel
On 14/04/24 19:43, Jisheng Zhang wrote:
> The preceding "&" before th1520_execute_tuning is useless, remove it.
>
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-of-dwcmshc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-of-dwcmshc.c b/drivers/mmc/host/sdhci-of-dwcmshc.c
> index 7b55acd9830c..6206ff7615e8 100644
> --- a/drivers/mmc/host/sdhci-of-dwcmshc.c
> +++ b/drivers/mmc/host/sdhci-of-dwcmshc.c
> @@ -822,7 +822,7 @@ static const struct sdhci_ops sdhci_dwcmshc_th1520_ops = {
> .reset = th1520_sdhci_reset,
> .adma_write_desc = dwcmshc_adma_write_desc,
> .voltage_switch = dwcmshc_phy_1_8v_init,
> - .platform_execute_tuning = &th1520_execute_tuning,
> + .platform_execute_tuning = th1520_execute_tuning,
> };
>
> static const struct sdhci_ops sdhci_dwcmshc_cv18xx_ops = {
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: sdhci-of-dwcmshc: Remove useless "&" of th1520_execute_tuning
2024-04-14 16:43 [PATCH] mmc: sdhci-of-dwcmshc: Remove useless "&" of th1520_execute_tuning Jisheng Zhang
2024-04-15 6:14 ` Adrian Hunter
@ 2024-04-25 16:21 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2024-04-25 16:21 UTC (permalink / raw)
To: Jisheng Zhang; +Cc: Adrian Hunter, linux-mmc, linux-kernel
On Sun, 14 Apr 2024 at 18:57, Jisheng Zhang <jszhang@kernel.org> wrote:
>
> The preceding "&" before th1520_execute_tuning is useless, remove it.
>
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-of-dwcmshc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-of-dwcmshc.c b/drivers/mmc/host/sdhci-of-dwcmshc.c
> index 7b55acd9830c..6206ff7615e8 100644
> --- a/drivers/mmc/host/sdhci-of-dwcmshc.c
> +++ b/drivers/mmc/host/sdhci-of-dwcmshc.c
> @@ -822,7 +822,7 @@ static const struct sdhci_ops sdhci_dwcmshc_th1520_ops = {
> .reset = th1520_sdhci_reset,
> .adma_write_desc = dwcmshc_adma_write_desc,
> .voltage_switch = dwcmshc_phy_1_8v_init,
> - .platform_execute_tuning = &th1520_execute_tuning,
> + .platform_execute_tuning = th1520_execute_tuning,
> };
>
> static const struct sdhci_ops sdhci_dwcmshc_cv18xx_ops = {
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-25 16:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-14 16:43 [PATCH] mmc: sdhci-of-dwcmshc: Remove useless "&" of th1520_execute_tuning Jisheng Zhang
2024-04-15 6:14 ` Adrian Hunter
2024-04-25 16:21 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).