[PATCH v2 3/4] dt-bindings: mmc: fsl-imx-esdhc: remove property "fsl,wp-controller"

[PATCH v2 3/4] dt-bindings: mmc: fsl-imx-esdhc: remove property "fsl,wp-controller"

[haibo.chen]

From: Haibo Chen <haibo.chen@nxp.com>

Driver do not use this property, so remove it here.

Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
---
 Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
index fbfd822b9270..e34b4fb4778a 100644
--- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
+++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
@@ -96,11 +96,6 @@ properties:
   interrupts:
     maxItems: 1
 
-  fsl,wp-controller:
-    description: |
-      boolean, if present, indicate to use controller internal write protection.
-    type: boolean
-
   fsl,delay-line:
     $ref: /schemas/types.yaml#/definitions/uint32
     description: |
@@ -190,7 +185,6 @@ examples:
         compatible = "fsl,imx51-esdhc";
         reg = <0x70004000 0x4000>;
         interrupts = <1>;
-        fsl,wp-controller;
     };
 
     mmc@70008000 {
-- 
2.34.1

Re: [PATCH v2 3/4] dt-bindings: mmc: fsl-imx-esdhc: remove property "fsl,wp-controller"

[Krzysztof Kozlowski]

On 05/05/2023 12:12, haibo.chen@nxp.com wrote:
> From: Haibo Chen <haibo.chen@nxp.com>
> 
> Driver do not use this property, so remove it here.

That's not true, it uses. I got only patch #3 and nothing else.

> 
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> ---
>  Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 6 ------
>  1 file changed, 6 deletions(-)


Best regards,
Krzysztof

RE: [PATCH v2 3/4] dt-bindings: mmc: fsl-imx-esdhc: remove property "fsl,wp-controller"

[Bough Chen]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: 2023年5月6日 1:48
> To: Bough Chen <haibo.chen@nxp.com>; adrian.hunter@intel.com;
> ulf.hansson@linaro.org; linux-mmc@vger.kernel.org; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; shawnguo@kernel.org;
> s.hauer@pengutronix.de
> Cc: dl-linux-imx <linux-imx@nxp.com>; kernel@pengutronix.de;
> festevam@gmail.com; cniedermaier@dh-electronics.com;
> devicetree@vger.kernel.org; kernel@dh-electronics.com
> Subject: Re: [PATCH v2 3/4] dt-bindings: mmc: fsl-imx-esdhc: remove property
> "fsl,wp-controller"
> 
> On 05/05/2023 12:12, haibo.chen@nxp.com wrote:
> > From: Haibo Chen <haibo.chen@nxp.com>
> >
> > Driver do not use this property, so remove it here.
> 
> That's not true, it uses. I got only patch #3 and nothing else.

This v2 patch only fix a dt-check error, for patch1,2,4, still not get comments, so I do not send out to avoid noise.

Here is the patch to remove "fsl,wp-controller" in driver:
https://patchwork.kernel.org/project/linux-mmc/patch/20230505084955.238940-2-haibo.chen@nxp.com/

Best Regards
Haibo Chen
> 
> >
> > Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 6 ------
> >  1 file changed, 6 deletions(-)
> 
> 
> Best regards,
> Krzysztof

Re: [PATCH v2 3/4] dt-bindings: mmc: fsl-imx-esdhc: remove property "fsl,wp-controller"

[Krzysztof Kozlowski]

On 06/05/2023 04:37, Bough Chen wrote:
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Sent: 2023年5月6日 1:48
>> To: Bough Chen <haibo.chen@nxp.com>; adrian.hunter@intel.com;
>> ulf.hansson@linaro.org; linux-mmc@vger.kernel.org; robh+dt@kernel.org;
>> krzysztof.kozlowski+dt@linaro.org; shawnguo@kernel.org;
>> s.hauer@pengutronix.de
>> Cc: dl-linux-imx <linux-imx@nxp.com>; kernel@pengutronix.de;
>> festevam@gmail.com; cniedermaier@dh-electronics.com;
>> devicetree@vger.kernel.org; kernel@dh-electronics.com
>> Subject: Re: [PATCH v2 3/4] dt-bindings: mmc: fsl-imx-esdhc: remove property
>> "fsl,wp-controller"
>>
>> On 05/05/2023 12:12, haibo.chen@nxp.com wrote:
>>> From: Haibo Chen <haibo.chen@nxp.com>
>>>
>>> Driver do not use this property, so remove it here.
>>
>> That's not true, it uses. I got only patch #3 and nothing else.
> 
> This v2 patch only fix a dt-check error, for patch1,2,4, still not get comments, so I do not send out to avoid noise.

So while sending a patchset of 4 patches you skipped 1+2+4? This does
not make sense. Send entire patchset.

The patch by itself, without context, is incorrect and not justified.

Best regards,
Krzysztof

[PATCH v2 0/4] cd/wp code clean up for i.MX USDHC

[haibo.chen]

From: Haibo Chen <haibo.chen@nxp.com>

Now i.MX USDHC driver convert to a DT-only platform driver, the legency
code for non-DT is reduncant, like the cd_types and wp_types. So clean
it up here.

V2:
-PATCH 3, fix the dt-binding-check error issue.
-no changes for other PATCH.

Haibo Chen (4):
  mmc: sdhci-esdhc-imx: remove unused enum cd_types
  mmc: sdhci-esdhc-imx: remove redundant write protect code
  dt-bindings: mmc: fsl-imx-esdhc: remove property "fsl,wp-controller"
  arm: dts: imx: remove "fsl,wp-controller" since it is dropped

 .../bindings/mmc/fsl-imx-esdhc.yaml           |  6 --
 arch/arm/boot/dts/imx53-sk-imx53.dts          |  1 -
 arch/arm/boot/dts/imx53-tx53.dtsi             |  2 -
 arch/arm/boot/dts/imx6dl-tx6s-8035.dts        |  1 -
 arch/arm/boot/dts/imx6dl-tx6u-8033.dts        |  1 -
 arch/arm/boot/dts/imx6q-bosch-acc.dts         |  2 -
 arch/arm/boot/dts/imx6q-tx6q-1020-comtft.dts  |  1 -
 arch/arm/boot/dts/imx6q-tx6q-1020.dts         |  1 -
 arch/arm/boot/dts/imx6q-tx6q-1036.dts         |  1 -
 arch/arm/boot/dts/imx6qdl-dhcom-som.dtsi      |  1 -
 arch/arm/boot/dts/imx6qdl-emcon.dtsi          |  2 -
 arch/arm/boot/dts/imx6qdl-ts4900.dtsi         |  1 -
 arch/arm/boot/dts/imx6qdl-ts7970.dtsi         |  1 -
 arch/arm/boot/dts/imx6qdl-tx6.dtsi            |  2 -
 arch/arm/boot/dts/imx6qp-tx6qp-8037.dts       |  1 -
 arch/arm/boot/dts/imx6qp-tx6qp-8137.dts       |  1 -
 arch/arm/boot/dts/imx6ul-tx6ul-0011.dts       |  1 -
 arch/arm/boot/dts/imx6ul-tx6ul.dtsi           |  1 -
 arch/arm/boot/dts/imxrt1050.dtsi              |  1 -
 drivers/mmc/host/sdhci-esdhc-imx.c            | 56 +------------------
 20 files changed, 1 insertion(+), 83 deletions(-)

-- 
2.34.1

[PATCH v2 3/4] dt-bindings: mmc: fsl-imx-esdhc: remove property "fsl,wp-controller"

[haibo.chen]

From: Haibo Chen <haibo.chen@nxp.com>

Driver do not use this property, so remove it here.

Signed-off-by: Haibo Chen <haibo.chen@nxp.com>

---
v2:
-fix dt-binding-check issue, also remove "fsl,wp-controller" in examples.
---
 Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
index fbfd822b9270..e34b4fb4778a 100644
--- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
+++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
@@ -96,11 +96,6 @@ properties:
   interrupts:
     maxItems: 1
 
-  fsl,wp-controller:
-    description: |
-      boolean, if present, indicate to use controller internal write protection.
-    type: boolean
-
   fsl,delay-line:
     $ref: /schemas/types.yaml#/definitions/uint32
     description: |
@@ -190,7 +185,6 @@ examples:
         compatible = "fsl,imx51-esdhc";
         reg = <0x70004000 0x4000>;
         interrupts = <1>;
-        fsl,wp-controller;
     };
 
     mmc@70008000 {
-- 
2.34.1

Re: [PATCH v2 3/4] dt-bindings: mmc: fsl-imx-esdhc: remove property "fsl,wp-controller"

[Krzysztof Kozlowski]

On 06/05/2023 09:40, haibo.chen@nxp.com wrote:
> From: Haibo Chen <haibo.chen@nxp.com>
> 
> Driver do not use this property, so remove it here.

You still need to expand the commit msg and justify why this property is
being removed. "Driver" is vague, as it can be BSD driver which also
might use this binding. Instead describe why this property should be
removed, so we can understand also ABI implications.

> 
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> 
> ---
> v2:
> -fix dt-binding-check issue, also remove "fsl,wp-controller" in examples.
> ---
>  Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 6 ------
>  1 file changed, 6 deletions(-)

Best regards,
Krzysztof

Re: [PATCH v2 3/4] dt-bindings: mmc: fsl-imx-esdhc: remove property "fsl,wp-controller"

[Peng Fan]

On 5/6/2023 6:59 PM, Krzysztof Kozlowski wrote:
> Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button
> 
> 
> On 06/05/2023 09:40, haibo.chen@nxp.com wrote:
>> From: Haibo Chen <haibo.chen@nxp.com>
>>
>> Driver do not use this property, so remove it here.
> 
> You still need to expand the commit msg and justify why this property is
> being removed. "Driver" is vague, as it can be BSD driver which also
> might use this binding. Instead describe why this property should be
> removed, so we can understand also ABI implications.

The better approach would be mark it as deprecated.

Regards,
Peng.

> 
>>
>> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
>>
>> ---
>> v2:
>> -fix dt-binding-check issue, also remove "fsl,wp-controller" in examples.
>> ---
>>   Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 6 ------
>>   1 file changed, 6 deletions(-)
> 
> Best regards,
> Krzysztof
> 

Re: [PATCH v2 3/4] dt-bindings: mmc: fsl-imx-esdhc: remove property "fsl,wp-controller"

[Rob Herring]

On Tue, May 23, 2023 at 10:03:08AM +0800, Peng Fan wrote:
> 
> 
> On 5/6/2023 6:59 PM, Krzysztof Kozlowski wrote:
> > Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button
> > 
> > 
> > On 06/05/2023 09:40, haibo.chen@nxp.com wrote:
> > > From: Haibo Chen <haibo.chen@nxp.com>
> > > 
> > > Driver do not use this property, so remove it here.
> > 
> > You still need to expand the commit msg and justify why this property is
> > being removed. "Driver" is vague, as it can be BSD driver which also
> > might use this binding. Instead describe why this property should be
> > removed, so we can understand also ABI implications.
> 
> The better approach would be mark it as deprecated.

Sure, but still need to say why.

Rob