* [PATCH] lib: packing: remove MODULE_LICENSE in non-modules
@ 2023-03-08 12:12 Nick Alcock
2023-03-08 12:12 ` [PATCH] mctp: " Nick Alcock
2023-03-10 7:30 ` [PATCH] lib: packing: " patchwork-bot+netdevbpf
0 siblings, 2 replies; 4+ messages in thread
From: Nick Alcock @ 2023-03-08 12:12 UTC (permalink / raw)
To: netdev
Cc: Luis Chamberlain, linux-modules, linux-kernel, Hitomi Hasegawa,
Vladimir Oltean
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Vladimir Oltean <olteanv@gmail.com>
Cc: netdev@vger.kernel.org
---
lib/packing.c | 1 -
1 file changed, 1 deletion(-)
(reposted to netdev as requested.)
diff --git a/lib/packing.c b/lib/packing.c
index a96169237ae66..3f656167c17e0 100644
--- a/lib/packing.c
+++ b/lib/packing.c
@@ -198,5 +198,4 @@ int packing(void *pbuf, u64 *uval, int startbit, int endbit, size_t pbuflen,
}
EXPORT_SYMBOL(packing);
-MODULE_LICENSE("GPL v2");
MODULE_DESCRIPTION("Generic bitfield packing and unpacking");
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] mctp: remove MODULE_LICENSE in non-modules
2023-03-08 12:12 [PATCH] lib: packing: remove MODULE_LICENSE in non-modules Nick Alcock
@ 2023-03-08 12:12 ` Nick Alcock
2023-03-10 7:11 ` patchwork-bot+netdevbpf
2023-03-10 7:30 ` [PATCH] lib: packing: " patchwork-bot+netdevbpf
1 sibling, 1 reply; 4+ messages in thread
From: Nick Alcock @ 2023-03-08 12:12 UTC (permalink / raw)
To: netdev
Cc: Luis Chamberlain, linux-modules, linux-kernel, Hitomi Hasegawa,
Jeremy Kerr, Matt Johnston, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Jeremy Kerr <jk@codeconstruct.com.au>
Cc: Matt Johnston <matt@codeconstruct.com.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org
---
net/mctp/af_mctp.c | 1 -
1 file changed, 1 deletion(-)
(Reposted to netdev as requested.)
diff --git a/net/mctp/af_mctp.c b/net/mctp/af_mctp.c
index 3150f3f0c8725..bb4bd0b6a4f79 100644
--- a/net/mctp/af_mctp.c
+++ b/net/mctp/af_mctp.c
@@ -704,7 +704,6 @@ subsys_initcall(mctp_init);
module_exit(mctp_exit);
MODULE_DESCRIPTION("MCTP core");
-MODULE_LICENSE("GPL v2");
MODULE_AUTHOR("Jeremy Kerr <jk@codeconstruct.com.au>");
MODULE_ALIAS_NETPROTO(PF_MCTP);
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] mctp: remove MODULE_LICENSE in non-modules
2023-03-08 12:12 ` [PATCH] mctp: " Nick Alcock
@ 2023-03-10 7:11 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-03-10 7:11 UTC (permalink / raw)
To: Nick Alcock
Cc: netdev, mcgrof, linux-modules, linux-kernel, hasegawa-hitomi, jk,
matt, davem, edumazet, kuba, pabeni
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 8 Mar 2023 12:12:30 +0000 you wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>
> [...]
Here is the summary with links:
- mctp: remove MODULE_LICENSE in non-modules
https://git.kernel.org/netdev/net-next/c/14296c7d72ec
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] lib: packing: remove MODULE_LICENSE in non-modules
2023-03-08 12:12 [PATCH] lib: packing: remove MODULE_LICENSE in non-modules Nick Alcock
2023-03-08 12:12 ` [PATCH] mctp: " Nick Alcock
@ 2023-03-10 7:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-03-10 7:30 UTC (permalink / raw)
To: Nick Alcock
Cc: netdev, mcgrof, linux-modules, linux-kernel, hasegawa-hitomi, olteanv
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 8 Mar 2023 12:12:29 +0000 you wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>
> [...]
Here is the summary with links:
- lib: packing: remove MODULE_LICENSE in non-modules
https://git.kernel.org/netdev/net-next/c/efb5b62d7271
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-10 7:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-08 12:12 [PATCH] lib: packing: remove MODULE_LICENSE in non-modules Nick Alcock
2023-03-08 12:12 ` [PATCH] mctp: " Nick Alcock
2023-03-10 7:11 ` patchwork-bot+netdevbpf
2023-03-10 7:30 ` [PATCH] lib: packing: " patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).