* kmod documentation issue -- module parameters must after modulename
@ 2016-06-01 11:12 Honggang LI
2016-06-04 14:07 ` Lucas De Marchi
0 siblings, 1 reply; 3+ messages in thread
From: Honggang LI @ 2016-06-01 11:12 UTC (permalink / raw)
To: linux-modules
upstream-git]$ git clone https://git.kernel.org/pub/scm/utils/kernel/kmod/kmod.git
upstream-git]$ cd kmod
kmod]$ grep -w -n fred -r .
./man/modprobe.d.xml:144: This can be useful because users expect "modprobe fred opt=1" to
^^^^^^^^^^^^^^^^^^^
./man/modprobe.d.xml:148: --ignore-install fred $CMDLINE_OPTS"
^^^^^^^^^^^^^^^^^^
"modprobe fred opt=1" should be "modprobe opt=1 fred"
"fred $CMDLINE_OPTS" should be "$CMDLINE_OPTS fred"
Please fix it.
thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: kmod documentation issue -- module parameters must after modulename
2016-06-01 11:12 kmod documentation issue -- module parameters must after modulename Honggang LI
@ 2016-06-04 14:07 ` Lucas De Marchi
2016-06-06 3:06 ` Honggang LI
0 siblings, 1 reply; 3+ messages in thread
From: Lucas De Marchi @ 2016-06-04 14:07 UTC (permalink / raw)
To: Honggang LI; +Cc: linux-modules
On Wed, Jun 1, 2016 at 8:12 AM, Honggang LI <honli@redhat.com> wrote:
> upstream-git]$ git clone https://git.kernel.org/pub/scm/utils/kernel/kmod/kmod.git
> upstream-git]$ cd kmod
> kmod]$ grep -w -n fred -r .
> ./man/modprobe.d.xml:144: This can be useful because users expect "modprobe fred opt=1" to
> ^^^^^^^^^^^^^^^^^^^
> ./man/modprobe.d.xml:148: --ignore-install fred $CMDLINE_OPTS"
> ^^^^^^^^^^^^^^^^^^
>
> "modprobe fred opt=1" should be "modprobe opt=1 fred"
> "fred $CMDLINE_OPTS" should be "$CMDLINE_OPTS fred"
Have you tried that? The doc is actually correct that the options
should be after the module name, not before. And it *is* the modprobe
behavior: https://git.kernel.org/cgit/utils/kernel/kmod/kmod.git/tree/tools/modprobe.c#n591
Lucas De Marchi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: kmod documentation issue -- module parameters must after modulename
2016-06-04 14:07 ` Lucas De Marchi
@ 2016-06-06 3:06 ` Honggang LI
0 siblings, 0 replies; 3+ messages in thread
From: Honggang LI @ 2016-06-06 3:06 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: linux-modules
On Sat, Jun 04, 2016 at 11:07:14AM -0300, Lucas De Marchi wrote:
> On Wed, Jun 1, 2016 at 8:12 AM, Honggang LI <honli@redhat.com> wrote:
> > upstream-git]$ git clone https://git.kernel.org/pub/scm/utils/kernel/kmod/kmod.git
> > upstream-git]$ cd kmod
> > kmod]$ grep -w -n fred -r .
> > ./man/modprobe.d.xml:144: This can be useful because users expect "modprobe fred opt=1" to
> > ^^^^^^^^^^^^^^^^^^^
> > ./man/modprobe.d.xml:148: --ignore-install fred $CMDLINE_OPTS"
> > ^^^^^^^^^^^^^^^^^^
> >
> > "modprobe fred opt=1" should be "modprobe opt=1 fred"
> > "fred $CMDLINE_OPTS" should be "$CMDLINE_OPTS fred"
>
> Have you tried that? The doc is actually correct that the options
Sorry, it is my bad.
> should be after the module name, not before. And it *is* the modprobe
> behavior: https://git.kernel.org/cgit/utils/kernel/kmod/kmod.git/tree/tools/modprobe.c#n591
>
>
>
> Lucas De Marchi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-06 3:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-01 11:12 kmod documentation issue -- module parameters must after modulename Honggang LI
2016-06-04 14:07 ` Lucas De Marchi
2016-06-06 3:06 ` Honggang LI
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).