From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Lucas De Marchi <lucas.de.marchi@gmail.com>
Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>,
linux-modules <linux-modules@vger.kernel.org>
Subject: Re: [PATCH] Makefile.am: filter -Wl,--no-undefined
Date: Mon, 18 Nov 2019 23:45:56 +0100 [thread overview]
Message-ID: <20191118234556.21a4984e@windsurf.home> (raw)
In-Reply-To: <CAKi4VAKB1myn8AuMaV3SjBrthNiTxc8TkE18w95BPdRuzQBn2g@mail.gmail.com>
Hello Lucas,
On Mon, 18 Nov 2019 14:18:07 -0800
Lucas De Marchi <lucas.de.marchi@gmail.com> wrote:
> On Mon, Nov 18, 2019 at 1:59 PM Fabrice Fontaine
> <fontaine.fabrice@gmail.com> wrote:
> >
> > Commit 1d14ef82f4a3be741bcdf6b1c6d51ce9dce43567 does not completely fix
>
> CC'ing Thomas.
>
> Lucas De Marchi
Fabrice also submitted this patch to Buildroot, and I merged it.
Indeed, the -z undefs option was only introduced in binutils 2.30, so
any toolchain using a binutils older than that is not able to use -z
undefs.
So I'd say that Fabrice's proposal is fine. Another option would be to
detect if the toolchain support -z undefs, and only use --no-undefined
if -z undefs is supported, for example.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2019-11-18 22:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-18 21:56 [PATCH] Makefile.am: filter -Wl,--no-undefined Fabrice Fontaine
2019-11-18 22:18 ` Lucas De Marchi
2019-11-18 22:45 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191118234556.21a4984e@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=fontaine.fabrice@gmail.com \
--cc=linux-modules@vger.kernel.org \
--cc=lucas.de.marchi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).