linux-modules.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] libkmod: ignore kcmdline option if we fail to parse modname
@ 2020-03-10  8:23 Lucas De Marchi
  2020-03-10  8:23 ` [PATCH 2/2] testsuite: check for ill-formed kcmdline Lucas De Marchi
  2020-03-23 19:29 ` [PATCH 1/2] libkmod: ignore kcmdline option if we fail to parse modname Lucas De Marchi
  0 siblings, 2 replies; 3+ messages in thread
From: Lucas De Marchi @ 2020-03-10  8:23 UTC (permalink / raw)
  To: linux-modules; +Cc: joao.moreira, leandro.maciel.dorileo, Lucas De Marchi

The error message is saying we are ignoring the option on the kernel
command line, so just do it.
---
 libkmod/libkmod-config.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/libkmod/libkmod-config.c b/libkmod/libkmod-config.c
index 7b62367..971f20b 100644
--- a/libkmod/libkmod-config.c
+++ b/libkmod/libkmod-config.c
@@ -488,8 +488,9 @@ static void kcmdline_parse_result(struct kmod_config *config, char *modname,
 		if (underscores(modname) < 0) {
 			ERR(config->ctx, "Ignoring bad option on kernel command line while parsing module name: '%s'\n",
 			    modname);
+		} else {
+			kmod_config_add_options(config, modname, param);
 		}
-		kmod_config_add_options(config, modname, param);
 	}
 }
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-03-23 19:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-10  8:23 [PATCH 1/2] libkmod: ignore kcmdline option if we fail to parse modname Lucas De Marchi
2020-03-10  8:23 ` [PATCH 2/2] testsuite: check for ill-formed kcmdline Lucas De Marchi
2020-03-23 19:29 ` [PATCH 1/2] libkmod: ignore kcmdline option if we fail to parse modname Lucas De Marchi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).