From: Jorge Lucangeli Obes <jorgelo@google.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: linux-modules@vger.kernel.org
Subject: Re: Buffer overflow in modprobe
Date: Thu, 19 Dec 2019 14:48:57 -0500 [thread overview]
Message-ID: <CAKYuF5T6fVDjgwY1hReOEp-gBKDy4M1Of6=sMeeDYYb3QvT5oA@mail.gmail.com> (raw)
In-Reply-To: <20191219004538.aqlw354ivugk7vym@ldmartin-desk1.jf.intel.com>
I am not the author of the change, the change was suggested to us as
part of the report that we received.
I can still try to send it in as a patch.
Cheers,
Jorge
On Wed, Dec 18, 2019 at 7:45 PM Lucas De Marchi
<lucas.demarchi@intel.com> wrote:
>
> On Thu, Dec 12, 2019 at 02:16:18PM -0500, Jorge Lucangeli Obes wrote:
> >Reset the state of was_space to false between passes.
> >For your assistance, we have provided the following code:
> >
> >--- libkmod-config.c 2018-06-21 17:59:48.633600181 +0100
> >+++ libkmod-config.fixed 2018-09-12 21:42:34.499453017 +0100 @@
> >-333,6 +333,8 @@
> > memcpy(dep->name ,modname ,modnamelen);
> >+ was_space = false;
> >+ /* copy strings */
>
> this looks reasonable. Are you the author of such change? Could you send
> this as a patch with git send-email?
>
> It would be nice to have a test added to the testsuite too if you can.
>
> thanks
> Lucas De Marchi
>
>
> > itr = dep->name + modnamelen;
> > n_pre = 0;
prev parent reply other threads:[~2019-12-19 19:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 19:16 Buffer overflow in modprobe Jorge Lucangeli Obes
2019-12-19 0:45 ` Lucas De Marchi
2019-12-19 19:48 ` Jorge Lucangeli Obes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKYuF5T6fVDjgwY1hReOEp-gBKDy4M1Of6=sMeeDYYb3QvT5oA@mail.gmail.com' \
--to=jorgelo@google.com \
--cc=linux-modules@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).