Linux-Modules Archive on lore.kernel.org
 help / Atom feed
* [PATCH] kmod: compiling with old sed version (!ERE support)
@ 2016-05-02 14:38 hector.oron
  2016-05-21 18:09 ` Lucas De Marchi
  0 siblings, 1 reply; 2+ messages in thread
From: hector.oron @ 2016-05-02 14:38 UTC (permalink / raw)
  To: linux-modules; +Cc: Héctor Orón Martínez

From: Héctor Orón Martínez <hector.oron@gmail.com>

  Makefile.am uses `sed -E', which it is found on BSD sed; however a
  replacement on GNU sed would be `sed -r'. Both intend to use extended
  regular expressions (ERE). However I have a system that does not support
  those, in benefit for portability could you consider replacing ERE by BRE.

Signed-off-by: Héctor Orón Martínez <hector.oron@gmail.com>
---
 Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile.am b/Makefile.am
index 2d9f2cf..8813475 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -107,7 +107,7 @@ install-exec-hook:
 	if test "$(libdir)" != "$(rootlibdir)"; then \
 		$(MKDIR_P) $(DESTDIR)$(rootlibdir) && \
 		so_img_name=$$(readlink $(DESTDIR)$(libdir)/libkmod.so) && \
-		so_img_rel_target_prefix=$$(echo $(libdir) | sed -E 's,(^/|)[^/][^/]*,..,g') && \
+		so_img_rel_target_prefix=$$(echo $(libdir) | sed 's,\(^/\|\)[^/][^/]*,..,g') && \
 		ln -sf $$so_img_rel_target_prefix$(rootlibdir)/$$so_img_name $(DESTDIR)$(libdir)/libkmod.so && \
 		mv $(DESTDIR)$(libdir)/libkmod.so.* $(DESTDIR)$(rootlibdir); \
 	fi
-- 
2.8.0.rc3


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] kmod: compiling with old sed version (!ERE support)
  2016-05-02 14:38 [PATCH] kmod: compiling with old sed version (!ERE support) hector.oron
@ 2016-05-21 18:09 ` Lucas De Marchi
  0 siblings, 0 replies; 2+ messages in thread
From: Lucas De Marchi @ 2016-05-21 18:09 UTC (permalink / raw)
  To: hector.oron; +Cc: linux-modules

On Mon, May 2, 2016 at 11:38 AM,  <hector.oron@gmail.com> wrote:
> From: H=C3=A9ctor Or=C3=B3n Mart=C3=ADnez <hector.oron@gmail.com>
>
>   Makefile.am uses `sed -E', which it is found on BSD sed; however a
>   replacement on GNU sed would be `sed -r'. Both intend to use extended
>   regular expressions (ERE). However I have a system that does not suppor=
t
>   those, in benefit for portability could you consider replacing ERE by B=
RE.
>
> Signed-off-by: H=C3=A9ctor Or=C3=B3n Mart=C3=ADnez <hector.oron@gmail.com=
>
> ---

Applied, thanks.

Lucas De Marchi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-02 14:38 [PATCH] kmod: compiling with old sed version (!ERE support) hector.oron
2016-05-21 18:09 ` Lucas De Marchi

Linux-Modules Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-modules/0 linux-modules/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-modules linux-modules/ https://lore.kernel.org/linux-modules \
		linux-modules@vger.kernel.org linux-modules@archiver.kernel.org
	public-inbox-index linux-modules


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-modules


AGPL code for this site: git clone https://public-inbox.org/ public-inbox