From: Tejun Heo <tj@kernel.org>
To: Igor Pylypiv <ipylypiv@google.com>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
Changyuan Lyu <changyuanl@google.com>
Subject: Re: [PATCH] Revert "module, async: async_synchronize_full() on module init iff async is used"
Date: Tue, 1 Feb 2022 07:43:27 -1000 [thread overview]
Message-ID: <YflxP28HlVrrNBU2@slm.duckdns.org> (raw)
In-Reply-To: <20220127233953.2185045-1-ipylypiv@google.com>
On Thu, Jan 27, 2022 at 03:39:53PM -0800, Igor Pylypiv wrote:
> This reverts commit 774a1221e862b343388347bac9b318767336b20b.
>
> We need to finish all async code before the module init sequence is done.
> In the reverted commit the PF_USED_ASYNC flag was added to mark a thread
> that called async_schedule(). Then the PF_USED_ASYNC flag was used to
> determine whether or not async_synchronize_full() needs to be invoked.
> This works when modprobe thread is calling async_schedule(), but it
> does not work if module dispatches init code to a worker thread which
> then calls async_schedule().
>
> For example, PCI driver probing is invoked from a worker thread based on
> a node where device is attached:
>
> if (cpu < nr_cpu_ids)
> error = work_on_cpu(cpu, local_pci_probe, &ddi);
> else
> error = local_pci_probe(&ddi);
>
> We end up in a situation where a worker thread gets the PF_USED_ASYNC flag
> set instead of the modprobe thread. As a result, async_synchronize_full()
> is not invoked and modprobe completes without waiting for the async code
> to finish.
>
> The issue was discovered while loading the pm80xx driver:
> (scsi_mod.scan=async)
>
> modprobe pm80xx worker
> ...
> do_init_module()
> ...
> pci_call_probe()
> work_on_cpu(local_pci_probe)
> local_pci_probe()
> pm8001_pci_probe()
> scsi_scan_host()
> async_schedule()
> worker->flags |= PF_USED_ASYNC;
> ...
> < return from worker >
> ...
> if (current->flags & PF_USED_ASYNC) <--- false
> async_synchronize_full();
>
> Commit 21c3c5d28007 ("block: don't request module during elevator init")
> fixed the deadlock issue which the reverted commit 774a1221e862 ("module,
> async: async_synchronize_full() on module init iff async is used") tried
> to fix.
>
> Since commit 0fdff3ec6d87 ("async, kmod: warn on synchronous
> request_module() from async workers") synchronous module loading
> from async is not allowed.
>
> Given that the original deadlock issue is fixed and it is no longer allowed
> to call synchronous request_module() from async we can remove PF_USED_ASYNC
> flag to make module init consistently invoke async_synchronize_full()
> unless async module probe is requested.
>
> Signed-off-by: Igor Pylypiv <ipylypiv@google.com>
> Reviewed-by: Changyuan Lyu <changyuanl@google.com>
That's quite a walk down the memory lane and I agree with your analysis. The
PF_USED_ASYNC is redundant for correctness with the removal of synchrnous
loading from iosched path and the WARN_ON guarantees that nothing in kernel
is creating a similar situation.
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
next prev parent reply other threads:[~2022-02-01 17:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 23:39 [PATCH] Revert "module, async: async_synchronize_full() on module init iff async is used" Igor Pylypiv
2022-01-28 7:39 ` Linus Torvalds
2022-01-31 21:58 ` Igor Pylypiv
2022-02-01 18:13 ` Tejun Heo
2022-02-01 18:20 ` Greg Kroah-Hartman
2022-02-01 17:43 ` Tejun Heo [this message]
2022-02-01 17:50 ` Tejun Heo
2022-02-03 1:11 ` Luis Chamberlain
2022-02-03 19:19 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YflxP28HlVrrNBU2@slm.duckdns.org \
--to=tj@kernel.org \
--cc=changyuanl@google.com \
--cc=ipylypiv@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).