linux-modules.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luis Chamberlain <mcgrof@kernel.org>
To: Tejun Heo <tj@kernel.org>, Aaron Tomlin <atomlin@redhat.com>
Cc: Igor Pylypiv <ipylypiv@google.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
	Changyuan Lyu <changyuanl@google.com>
Subject: Re: [PATCH] Revert "module, async: async_synchronize_full() on module init iff async is used"
Date: Wed, 2 Feb 2022 17:11:20 -0800	[thread overview]
Message-ID: <YfsruBT19o3j0KD2@bombadil.infradead.org> (raw)
In-Reply-To: <Yfly0P4e84373mGF@slm.duckdns.org>

On Tue, Feb 01, 2022 at 07:50:08AM -1000, Tejun Heo wrote:
> On Tue, Feb 01, 2022 at 07:43:27AM -1000, Tejun Heo wrote:
> > That's quite a walk down the memory lane and I agree with your analysis. The
> > PF_USED_ASYNC is redundant for correctness with the removal of synchrnous
> > loading from iosched path and the WARN_ON guarantees that nothing in kernel
> > is creating a similar situation.
> > 
> > Acked-by: Tejun Heo <tj@kernel.org>
> 
> BTW, I can route this through workqueue tree but -mm or going to Linus's
> tree directly might be a better option. Any opinions?

FWIW, although I was not working on modules when the reverted commit was
merged, my take on this is concern for a regression, much more than
others. However I do agree that async probe can help for any slowdown,
and the idea was that folks would eventually strive slowly to make more
and more modules default to async probe as they can verify that's fine.

With that said,

Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>

And I'd prefer this go through Linus' tree since this is a fix and
can be merged already. That would help with Aaron's kernel/module.c
refactor work (no functional changes) too as that will soon slice and
dice that to a kernel/module/*.c files.

 Luis

  reply	other threads:[~2022-02-03  1:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-27 23:39 [PATCH] Revert "module, async: async_synchronize_full() on module init iff async is used" Igor Pylypiv
2022-01-28  7:39 ` Linus Torvalds
2022-01-31 21:58   ` Igor Pylypiv
2022-02-01 18:13   ` Tejun Heo
2022-02-01 18:20     ` Greg Kroah-Hartman
2022-02-01 17:43 ` Tejun Heo
2022-02-01 17:50   ` Tejun Heo
2022-02-03  1:11     ` Luis Chamberlain [this message]
2022-02-03 19:19     ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YfsruBT19o3j0KD2@bombadil.infradead.org \
    --to=mcgrof@kernel.org \
    --cc=atomlin@redhat.com \
    --cc=changyuanl@google.com \
    --cc=ipylypiv@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=tj@kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).