Linux-Modules Archive on lore.kernel.org
 help / Atom feed
* depmod gets stuck in symlink cycle in arch/arm/boot/dts/include
@ 2017-05-12 22:23 Omar Sandoval
  2017-05-12 22:55 ` Olof Johansson
  2017-05-13  5:03 ` Yauheni Kaliuta
  0 siblings, 2 replies; 3+ messages in thread
From: Omar Sandoval @ 2017-05-12 22:23 UTC (permalink / raw)
  To: linux-modules, linux-kernel
  Cc: Lucas De Marchi, Olof Johansson, Heiko Stuebner

Hi,

Linux kernel commit 4027494ae6e3 ("ARM: dts: add arm/arm64 include
symlinks") introduced a couple of symlink cycles:

$ ls -al arch/arm{,64}/boot/dts/include
arch/arm64/boot/dts/include:
total 12
drwxr-xr-x 1 osandov users  38 May 11 14:01 .
drwxr-xr-x 1 osandov users 320 Jan 25 20:44 ..
lrwxrwxrwx 1 osandov users  24 May 11 14:01 arm -> ../../../../arm/boot/dts
lrwxrwxrwx 1 osandov users   2 May 11 14:01 arm64 -> ..
lrwxrwxrwx 1 osandov users  34 Nov 23 12:07 dt-bindings -> ../../../../../include/dt-bindings

arch/arm/boot/dts/include:
total 12
drwxr-xr-x 1 osandov users    38 May 11 14:01 .
drwxr-xr-x 1 osandov users 63102 May 11 14:01 ..
lrwxrwxrwx 1 osandov users     2 May 11 14:01 arm -> ..
lrwxrwxrwx 1 osandov users    26 May 11 14:01 arm64 -> ../../../../arm64/boot/dts
lrwxrwxrwx 1 osandov users    34 Nov 23 12:07 dt-bindings -> ../../../../../include/dt-bindings

On my system, /lib/modules/$(uname -r)/kernel is a symlink to
/lib/modules/$(uname -r)/build, which is my built linux.git. depmod
doesn't like these symlink cycles and ends up in an infinite loop.

Maybe I shouldn't be symlinking kernel to build like this, but depmod
shouldn't be getting stuck like this either. I wonder if anything else
is going to barf on these symlink cycles, too.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: depmod gets stuck in symlink cycle in arch/arm/boot/dts/include
  2017-05-12 22:23 depmod gets stuck in symlink cycle in arch/arm/boot/dts/include Omar Sandoval
@ 2017-05-12 22:55 ` Olof Johansson
  2017-05-13  5:03 ` Yauheni Kaliuta
  1 sibling, 0 replies; 3+ messages in thread
From: Olof Johansson @ 2017-05-12 22:55 UTC (permalink / raw)
  To: Omar Sandoval
  Cc: linux-modules, linux-kernel, Lucas De Marchi, Heiko Stuebner

Yeah, the location of the include directory needs to move. I'll post a
patch shortly. Russell reported it earlier but the week got busy and I
lost track of it.

The easiest solution here is to move the dts/include directory to
somewhere else.


-Olof

On Fri, May 12, 2017 at 3:23 PM, Omar Sandoval <osandov@osandov.com> wrote:
> Hi,
>
> Linux kernel commit 4027494ae6e3 ("ARM: dts: add arm/arm64 include
> symlinks") introduced a couple of symlink cycles:
>
> $ ls -al arch/arm{,64}/boot/dts/include
> arch/arm64/boot/dts/include:
> total 12
> drwxr-xr-x 1 osandov users  38 May 11 14:01 .
> drwxr-xr-x 1 osandov users 320 Jan 25 20:44 ..
> lrwxrwxrwx 1 osandov users  24 May 11 14:01 arm -> ../../../../arm/boot/dts
> lrwxrwxrwx 1 osandov users   2 May 11 14:01 arm64 -> ..
> lrwxrwxrwx 1 osandov users  34 Nov 23 12:07 dt-bindings -> ../../../../../include/dt-bindings
>
> arch/arm/boot/dts/include:
> total 12
> drwxr-xr-x 1 osandov users    38 May 11 14:01 .
> drwxr-xr-x 1 osandov users 63102 May 11 14:01 ..
> lrwxrwxrwx 1 osandov users     2 May 11 14:01 arm -> ..
> lrwxrwxrwx 1 osandov users    26 May 11 14:01 arm64 -> ../../../../arm64/boot/dts
> lrwxrwxrwx 1 osandov users    34 Nov 23 12:07 dt-bindings -> ../../../../../include/dt-bindings
>
> On my system, /lib/modules/$(uname -r)/kernel is a symlink to
> /lib/modules/$(uname -r)/build, which is my built linux.git. depmod
> doesn't like these symlink cycles and ends up in an infinite loop.
>
> Maybe I shouldn't be symlinking kernel to build like this, but depmod
> shouldn't be getting stuck like this either. I wonder if anything else
> is going to barf on these symlink cycles, too.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: depmod gets stuck in symlink cycle in arch/arm/boot/dts/include
  2017-05-12 22:23 depmod gets stuck in symlink cycle in arch/arm/boot/dts/include Omar Sandoval
  2017-05-12 22:55 ` Olof Johansson
@ 2017-05-13  5:03 ` Yauheni Kaliuta
  1 sibling, 0 replies; 3+ messages in thread
From: Yauheni Kaliuta @ 2017-05-13  5:03 UTC (permalink / raw)
  To: Omar Sandoval
  Cc: linux-modules, linux-kernel, Lucas De Marchi, Olof Johansson,
	Heiko Stuebner

Hi, Omar!

>>>>> On Fri, 12 May 2017 15:23:07 -0700, Omar Sandoval  wrote:

 > Hi,
 > Linux kernel commit 4027494ae6e3 ("ARM: dts: add arm/arm64 include
 > symlinks") introduced a couple of symlink cycles:

 > $ ls -al arch/arm{,64}/boot/dts/include
 > arch/arm64/boot/dts/include:
 > total 12
 > drwxr-xr-x 1 osandov users  38 May 11 14:01 .
 > drwxr-xr-x 1 osandov users 320 Jan 25 20:44 ..
 > lrwxrwxrwx 1 osandov users  24 May 11 14:01 arm -> ../../../../arm/boot/dts
 > lrwxrwxrwx 1 osandov users   2 May 11 14:01 arm64 -> ..
 > lrwxrwxrwx 1 osandov users 34 Nov 23 12:07 dt-bindings ->
 > ../../../../../include/dt-bindings

 > arch/arm/boot/dts/include:
 > total 12
 > drwxr-xr-x 1 osandov users    38 May 11 14:01 .
 > drwxr-xr-x 1 osandov users 63102 May 11 14:01 ..
 > lrwxrwxrwx 1 osandov users     2 May 11 14:01 arm -> ..
 > lrwxrwxrwx 1 osandov users    26 May 11 14:01 arm64 -> ../../../../arm64/boot/dts
 > lrwxrwxrwx 1 osandov users 34 Nov 23 12:07 dt-bindings ->
 > ../../../../../include/dt-bindings

 > On my system, /lib/modules/$(uname -r)/kernel is a symlink to
 > /lib/modules/$(uname -r)/build, which is my built linux.git. depmod
 > doesn't like these symlink cycles and ends up in an infinite loop.

 > Maybe I shouldn't be symlinking kernel to build like this, but depmod
 > shouldn't be getting stuck like this either. I wonder if anything else
 > is going to barf on these symlink cycles, too.

depmod checks for special names "build" and "source" to skip them.

I wonder if it worth to implement full symlink loop check.

-- 
WBR,
Yauheni Kaliuta

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-12 22:23 depmod gets stuck in symlink cycle in arch/arm/boot/dts/include Omar Sandoval
2017-05-12 22:55 ` Olof Johansson
2017-05-13  5:03 ` Yauheni Kaliuta

Linux-Modules Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-modules/0 linux-modules/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-modules linux-modules/ https://lore.kernel.org/linux-modules \
		linux-modules@vger.kernel.org linux-modules@archiver.kernel.org
	public-inbox-index linux-modules


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-modules


AGPL code for this site: git clone https://public-inbox.org/ public-inbox