From: <Tudor.Ambarus@microchip.com>
To: <vigneshr@ti.com>, <marek.vasut@gmail.com>
Cc: richard@nod.at, linux-kernel@vger.kernel.org,
Nicolas.Ferre@microchip.com, boris.brezillon@collabora.com,
linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com,
computersforpeace@gmail.com, dwmw2@infradead.org
Subject: Re: [PATCH 5/5] mtd: spi-nor: add Kconfig option to disable write protection at power-up
Date: Wed, 17 Jul 2019 11:15:13 +0000 [thread overview]
Message-ID: <0fc5d3bb-aa11-2816-4734-75dc86deb0d2@microchip.com> (raw)
In-Reply-To: <20190717084745.19322-6-tudor.ambarus@microchip.com>
On 07/17/2019 11:48 AM, Tudor Ambarus - M18064 wrote:
> From: Tudor Ambarus <tudor.ambarus@microchip.com>
>
> Some spi-nor flashes come write protected by default after a
> power-on sequence to avoid destructing commands (erase, write)
> during power-up.
>
> Backward compatibility imposes to disable the write protection
> at power-up by default. Add a Kconfig option to let the user
> benefit of the power-up write protection.
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> ---
> drivers/mtd/spi-nor/Kconfig | 8 ++++++++
> drivers/mtd/spi-nor/spi-nor.c | 2 ++
> 2 files changed, 10 insertions(+)
I'll have to mark spi_nor_spansion_clear_sr_bp() and
spi_nor_unlock_global_block_protection() definitions as __maybe_unused.
drivers/mtd/spi-nor/spi-nor.c:1729:12: warning:
‘spi_nor_unlock_global_block_protection’ defined but not used [-Wunused-function]
static int spi_nor_unlock_global_block_protection(struct spi_nor *nor)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/mtd/spi-nor/spi-nor.c:1687:12: warning: ‘spi_nor_spansion_clear_sr_bp’
defined but not used [-Wunused-function]
static int spi_nor_spansion_clear_sr_bp(struct spi_nor *nor)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-07-17 11:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 8:47 [PATCH 0/5] mtd: spi-nor: write protection at power-up Tudor.Ambarus
2019-07-17 8:48 ` [PATCH 1/5] mtd: spi-nor: fix description for int (*flash_is_locked)() Tudor.Ambarus
2019-08-05 5:34 ` Vignesh Raghavendra
2019-08-12 11:24 ` Tudor.Ambarus
2019-07-17 8:48 ` [PATCH 2/5] mtd: spi-nor: group the code about the write protection at power-up Tudor.Ambarus
2019-08-05 5:44 ` Vignesh Raghavendra
2019-08-05 6:30 ` Tudor.Ambarus
2019-07-17 8:48 ` [PATCH 3/5] mtd: spi-nor: add Global Block Unlock support Tudor.Ambarus
2019-08-05 6:18 ` Vignesh Raghavendra
2019-07-17 8:48 ` [PATCH 4/5] mtd: spi-nor: unlock global block protection on sst26vf064b Tudor.Ambarus
2019-07-17 8:48 ` [PATCH 5/5] mtd: spi-nor: add Kconfig option to disable write protection at power-up Tudor.Ambarus
2019-07-17 11:15 ` Tudor.Ambarus [this message]
2019-07-17 11:30 ` [PATCH v2 " Tudor.Ambarus
2019-08-07 16:24 ` Vignesh Raghavendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fc5d3bb-aa11-2816-4734-75dc86deb0d2@microchip.com \
--to=tudor.ambarus@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=boris.brezillon@collabora.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).