From: <Tudor.Ambarus@microchip.com>
To: <p.yadav@ti.com>
Cc: alexandre.belloni@bootlin.com, masonccyang@mxic.com.tw,
vigneshr@ti.com, richard@nod.at, nsekhar@ti.com,
Nicolas.Ferre@microchip.com, boris.brezillon@collabora.com,
michal.simek@xilinx.com, Ludovic.Desroches@microchip.com,
broonie@kernel.org, linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, miquel.raynal@bootlin.com,
matthias.bgg@gmail.com, linux-mediatek@lists.infradead.org,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 06/19] mtd: spi-nor: sfdp: default to addr_width of 3 for configurable widths
Date: Sat, 30 May 2020 18:49:21 +0000 [thread overview]
Message-ID: <12165309.mSmAnqxVWc@192.168.0.120> (raw)
In-Reply-To: <20200525091544.17270-7-p.yadav@ti.com>
On Monday, May 25, 2020 12:15:31 PM EEST Pratyush Yadav wrote:
> JESD216D.01 says that when the address width can be 3 or 4, it defaults
> to 3 and enters 4-byte mode when given the appropriate command. So, when
> we see a configurable width, default to 3 and let flash that default to
> 4 change it in a post-bfpt fixup.
>
> This fixes SMPT parsing for flashes with configurable address width. If
> the SMPT descriptor advertises variable address width, we use
> nor->addr_width as the address width. But since it was not set to any
> value from the SFDP table, the read command uses an address width of 0,
> resulting in an incorrect read being issued.
>
> Signed-off-by: Pratyush Yadav <p.yadav@ti.com>
> ---
> drivers/mtd/spi-nor/sfdp.c | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-05-30 18:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 9:15 [PATCH v9 00/19] mtd: spi-nor: add xSPI Octal DTR support Pratyush Yadav
2020-05-25 9:15 ` [PATCH v9 01/19] spi: spi-mem: allow specifying whether an op is DTR or not Pratyush Yadav
2020-05-25 9:15 ` [PATCH v9 02/19] spi: spi-mem: allow specifying a command's extension Pratyush Yadav
2020-05-25 9:15 ` [PATCH v9 03/19] spi: atmel-quadspi: reject DTR ops Pratyush Yadav
2020-05-25 9:15 ` [PATCH v9 04/19] spi: spi-mtk-nor: " Pratyush Yadav
2020-05-25 9:15 ` [PATCH v9 05/19] mtd: spi-nor: add support for DTR protocol Pratyush Yadav
2020-05-25 9:15 ` [PATCH v9 06/19] mtd: spi-nor: sfdp: default to addr_width of 3 for configurable widths Pratyush Yadav
2020-05-30 18:49 ` Tudor.Ambarus [this message]
2020-05-25 9:15 ` [PATCH v9 07/19] mtd: spi-nor: sfdp: prepare BFPT parsing for JESD216 rev D Pratyush Yadav
2020-05-30 18:50 ` Tudor.Ambarus
2020-05-25 9:15 ` [PATCH v9 08/19] mtd: spi-nor: sfdp: get command opcode extension type from BFPT Pratyush Yadav
2020-05-25 9:15 ` [PATCH v9 09/19] mtd: spi-nor: sfdp: parse xSPI Profile 1.0 table Pratyush Yadav
2020-05-25 9:15 ` [PATCH v9 10/19] mtd: spi-nor: core: use dummy cycle and address width info from SFDP Pratyush Yadav
2020-05-25 9:15 ` [PATCH v9 11/19] mtd: spi-nor: core: do 2 byte reads for SR and FSR in DTR mode Pratyush Yadav
2020-05-25 9:15 ` [PATCH v9 12/19] mtd: spi-nor: core: enable octal DTR mode when possible Pratyush Yadav
2020-05-25 9:15 ` [PATCH v9 13/19] mtd: spi-nor: sfdp: do not make invalid quad enable fatal Pratyush Yadav
2020-05-30 18:42 ` Tudor.Ambarus
2020-06-01 8:58 ` Pratyush Yadav
2020-05-25 9:15 ` [PATCH v9 14/19] mtd: spi-nor: sfdp: detect Soft Reset sequence support from BFPT Pratyush Yadav
2020-05-25 9:15 ` [PATCH v9 15/19] mtd: spi-nor: core: perform a Soft Reset on shutdown Pratyush Yadav
2020-05-25 9:15 ` [PATCH v9 16/19] mtd: spi-nor: core: disable Octal DTR mode on suspend Pratyush Yadav
2020-05-25 9:15 ` [PATCH v9 17/19] mtd: spi-nor: core: expose spi_nor_default_setup() in core.h Pratyush Yadav
2020-05-25 9:15 ` [PATCH v9 18/19] mtd: spi-nor: spansion: add support for Cypress Semper flash Pratyush Yadav
2020-05-25 9:15 ` [PATCH v9 19/19] mtd: spi-nor: micron-st: allow using MT35XU512ABA in Octal DTR mode Pratyush Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12165309.mSmAnqxVWc@192.168.0.120 \
--to=tudor.ambarus@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=boris.brezillon@collabora.com \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=masonccyang@mxic.com.tw \
--cc=matthias.bgg@gmail.com \
--cc=michal.simek@xilinx.com \
--cc=miquel.raynal@bootlin.com \
--cc=nsekhar@ti.com \
--cc=p.yadav@ti.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).