linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Jonas Gorski <jonas.gorski@gmail.com>
To: linux-mtd@lists.infradead.org
Cc: linux-mips@linux-mips.org,
	Artem Bityutskiy <Artem.Bityutskiy@intel.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Florian Fainelli <florian@openwrt.org>,
	Ralf Baechle <ralf@linux-mips.org>
Subject: [PATCH 3/7] MTD: MAPS: bcm963xx-flash: clean up printk usage
Date: Mon,  5 Dec 2011 16:08:07 +0100	[thread overview]
Message-ID: <1323097691-16414-4-git-send-email-jonas.gorski@gmail.com> (raw)
In-Reply-To: <1323097691-16414-1-git-send-email-jonas.gorski@gmail.com>

Replace raw printk's with their pr_XXX equivalent and unify broken up
strings so they become grepable.

Also replace the PFX definition with a pr_fmt().

Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
---
 drivers/mtd/maps/bcm963xx-flash.c |   20 ++++++++++----------
 1 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/mtd/maps/bcm963xx-flash.c b/drivers/mtd/maps/bcm963xx-flash.c
index 58cbaf2..ce2ca2a 100644
--- a/drivers/mtd/maps/bcm963xx-flash.c
+++ b/drivers/mtd/maps/bcm963xx-flash.c
@@ -18,6 +18,8 @@
  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
  */
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/init.h>
 #include <linux/kernel.h>
 #include <linux/slab.h>
@@ -33,8 +35,6 @@
 #define BCM63XX_BUSWIDTH	2		/* Buswidth */
 #define BCM63XX_EXTENDED_SIZE	0xBFC00000	/* Extended flash address */
 
-#define PFX KBUILD_MODNAME ": "
-
 static struct mtd_partition *parsed_parts;
 
 static struct mtd_info *bcm963xx_mtd_info;
@@ -79,8 +79,8 @@ static int parse_cfe_partitions(struct mtd_info *master,
 	tagversion = &(buf->tag_version[0]);
 	boardid = &(buf->board_id[0]);
 
-	printk(KERN_INFO PFX "CFE boot tag found with version %s "
-				"and board type %s\n", tagversion, boardid);
+	pr_info("CFE boot tag found with version %s and board type %s\n",
+		tagversion, boardid);
 
 	kerneladdr = kerneladdr - BCM63XX_EXTENDED_SIZE;
 	rootfsaddr = kerneladdr + kernellen;
@@ -139,13 +139,13 @@ static int parse_cfe_partitions(struct mtd_info *master,
 	parts[curpart].size = master->size - parts[0].size - parts[3].size;
 
 	for (i = 0; i < nrparts; i++)
-		printk(KERN_INFO PFX "Partition %d is %s offset %lx and "
-					"length %lx\n", i, parts[i].name,
-					(long unsigned int)(parts[i].offset),
-					(long unsigned int)(parts[i].size));
+		pr_info("Partition %d is %s offset %lx and length %lx\n", i,
+			parts[i].name, (long unsigned int)(parts[i].offset),
+			(long unsigned int)(parts[i].size));
+
+	pr_info("Spare partition is offset %x and length %x\n",	spareaddr,
+		sparelen);
 
-	printk(KERN_INFO PFX "Spare partition is offset %x and length %x\n",
-							spareaddr, sparelen);
 	*pparts = parts;
 	vfree(buf);
 
-- 
1.7.2.5

  parent reply	other threads:[~2011-12-05 15:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-05 15:08 [PATCH 0/7] MTD: MAPS: remove bcm963xx-flash Jonas Gorski
2011-12-05 15:08 ` [PATCH 1/7] MTD: MAPS: bcm963xx-flash: fix word order for spare partition Jonas Gorski
2011-12-05 15:08 ` [PATCH 2/7] MTD: MAPS: bcm963xx-flash: remove superfluous semicolons Jonas Gorski
2011-12-05 15:08 ` Jonas Gorski [this message]
2011-12-05 15:08 ` [PATCH 4/7] MTD: MAPS: bcm963xx-flash: make CFE partition parsing an mtd parser Jonas Gorski
2011-12-05 15:08 ` [PATCH 5/7] MTD: MAPS: physmap: allow partition parsers for physmap_flash_data Jonas Gorski
2011-12-05 15:08 ` [PATCH 6/7] MIPS: BCM63XX: use the new bcm63xxpart parser Jonas Gorski
2011-12-05 15:08 ` [PATCH 7/7] MTD: MAPS: remove the now unused bcm963xx-flash Jonas Gorski
2011-12-05 22:36 ` [PATCH 0/7] MTD: MAPS: remove bcm963xx-flash Florian Fainelli
2011-12-06 12:02 ` Artem Bityutskiy
2011-12-06 12:13   ` Jonas Gorski
2011-12-06 21:01     ` Artem Bityutskiy
2011-12-07  5:45 ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1323097691-16414-4-git-send-email-jonas.gorski@gmail.com \
    --to=jonas.gorski@gmail.com \
    --cc=Artem.Bityutskiy@intel.com \
    --cc=dwmw2@infradead.org \
    --cc=florian@openwrt.org \
    --cc=linux-mips@linux-mips.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).