From: Florian Fainelli <florian@openwrt.org>
To: Jonas Gorski <jonas.gorski@gmail.com>
Cc: linux-mips@linux-mips.org,
Artem Bityutskiy <Artem.Bityutskiy@intel.com>,
linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>,
Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH 0/7] MTD: MAPS: remove bcm963xx-flash
Date: Mon, 5 Dec 2011 23:36:07 +0100 [thread overview]
Message-ID: <201112052336.07901.florian@openwrt.org> (raw)
In-Reply-To: <1323097691-16414-1-git-send-email-jonas.gorski@gmail.com>
Hello Jonas,
Le lundi 05 décembre 2011 16:08:04, Jonas Gorski a écrit :
> While trying to improve the bcm963xx CFE partition parsing, I noticed
> that it could be completely replaced by the generic physmap flash
> driver using a custom parser.
>
> The following patch set tries to accomplish that.
>
> The first few patches clean take care of some minor code style issues
> first to prevent checkpatch from complaining when moving code around.
>
> After that I move the CFE partition parsing into a parser and make
> bcm963xx-flash use it to make sure I don't create a non working version.
>
> Finally I'll allow physmap_flash_data to take partition parser names for
> overriding the default parsers list (the OF version already allows that),
> let BCM63XX use it, and remove the bcm963xx-flash driver as it is now
> completely replaced by physmap + CFE parser.
>
> While most patches are limited to the MTD tree, patch 6/7 touches MIPS,
> so it could go in either tree. But since the MTD tree already has some
> modifications for bcm963xx-flash, I think it's better to let it go
> through the MTD tree, to reduce the (potential for) conflicts.
For the whole series, feel free to add my:
Acked-by: Florian Fainelli <florian@openwrt.org>
thanks!
>
> Regards
> Jonas
>
> P.S: This patchset is based on l2-mtd-2.6.git, which seems to be the
> "correct" tree now (the website says mtd-2.6.git, but it doesn't look
> like the correct one, having no commits).
>
> Jonas Gorski (7):
> MTD: MAPS: bcm963xx-flash: fix word order for spare partition
> MTD: MAPS: bcm963xx-flash: remove superfluous semicolons
> MTD: MAPS: bcm963xx-flash: clean up printk usage
> MTD: MAPS: bcm963xx-flash: make CFE partition parsing an mtd parser
> MTD: MAPS: physmap: allow partition parsers for physmap_flash_data
> MIPS: BCM63XX: use the new bcm63xxpart parser
> MTD: MAPS: remove the now unused bcm963xx-flash
>
> arch/mips/bcm63xx/boards/board_bcm963xx.c | 3 +
> drivers/mtd/Kconfig | 8 +
> drivers/mtd/Makefile | 1 +
> drivers/mtd/bcm63xxpart.c | 189 ++++++++++++++++++++
> drivers/mtd/maps/Kconfig | 1 +
> drivers/mtd/maps/bcm963xx-flash.c | 265
> ----------------------------- drivers/mtd/maps/physmap.c |
> 5 +-
> include/linux/mtd/physmap.h | 1 +
> 8 files changed, 207 insertions(+), 266 deletions(-)
> create mode 100644 drivers/mtd/bcm63xxpart.c
> delete mode 100644 drivers/mtd/maps/bcm963xx-flash.c
--
Florian
next prev parent reply other threads:[~2011-12-05 22:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-05 15:08 [PATCH 0/7] MTD: MAPS: remove bcm963xx-flash Jonas Gorski
2011-12-05 15:08 ` [PATCH 1/7] MTD: MAPS: bcm963xx-flash: fix word order for spare partition Jonas Gorski
2011-12-05 15:08 ` [PATCH 2/7] MTD: MAPS: bcm963xx-flash: remove superfluous semicolons Jonas Gorski
2011-12-05 15:08 ` [PATCH 3/7] MTD: MAPS: bcm963xx-flash: clean up printk usage Jonas Gorski
2011-12-05 15:08 ` [PATCH 4/7] MTD: MAPS: bcm963xx-flash: make CFE partition parsing an mtd parser Jonas Gorski
2011-12-05 15:08 ` [PATCH 5/7] MTD: MAPS: physmap: allow partition parsers for physmap_flash_data Jonas Gorski
2011-12-05 15:08 ` [PATCH 6/7] MIPS: BCM63XX: use the new bcm63xxpart parser Jonas Gorski
2011-12-05 15:08 ` [PATCH 7/7] MTD: MAPS: remove the now unused bcm963xx-flash Jonas Gorski
2011-12-05 22:36 ` Florian Fainelli [this message]
2011-12-06 12:02 ` [PATCH 0/7] MTD: MAPS: remove bcm963xx-flash Artem Bityutskiy
2011-12-06 12:13 ` Jonas Gorski
2011-12-06 21:01 ` Artem Bityutskiy
2011-12-07 5:45 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112052336.07901.florian@openwrt.org \
--to=florian@openwrt.org \
--cc=Artem.Bityutskiy@intel.com \
--cc=dwmw2@infradead.org \
--cc=jonas.gorski@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=linux-mtd@lists.infradead.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).