* [PATCH v2] mtd: sh_flctl: Fix warnings due to improper casts
@ 2013-11-27 10:17 Laurent Pinchart
2013-12-13 18:22 ` Brian Norris
0 siblings, 1 reply; 2+ messages in thread
From: Laurent Pinchart @ 2013-11-27 10:17 UTC (permalink / raw)
To: linux-sh; +Cc: linux-mtd, David Woodhouse
Cast pointers to uintptr_t instead of unsigned int. This fixes warnings
on platforms where pointers have a different size than int.
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: linux-mtd@lists.infradead.org
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
drivers/mtd/nand/sh_flctl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Changes compared to v1:
- Cast to uintptr_t instead of unsigned long
diff --git a/drivers/mtd/nand/sh_flctl.c b/drivers/mtd/nand/sh_flctl.c
index a3c84eb..0f135cb 100644
--- a/drivers/mtd/nand/sh_flctl.c
+++ b/drivers/mtd/nand/sh_flctl.c
@@ -151,7 +151,7 @@ static void flctl_setup_dma(struct sh_flctl *flctl)
dma_cap_set(DMA_SLAVE, mask);
flctl->chan_fifo0_tx = dma_request_channel(mask, shdma_chan_filter,
- (void *)pdata->slave_id_fifo0_tx);
+ (void *)(uintptr_t)pdata->slave_id_fifo0_tx);
dev_dbg(&pdev->dev, "%s: TX: got channel %p\n", __func__,
flctl->chan_fifo0_tx);
@@ -168,7 +168,7 @@ static void flctl_setup_dma(struct sh_flctl *flctl)
goto err;
flctl->chan_fifo0_rx = dma_request_channel(mask, shdma_chan_filter,
- (void *)pdata->slave_id_fifo0_rx);
+ (void *)(uintptr_t)pdata->slave_id_fifo0_rx);
dev_dbg(&pdev->dev, "%s: RX: got channel %p\n", __func__,
flctl->chan_fifo0_rx);
--
1.8.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] mtd: sh_flctl: Fix warnings due to improper casts
2013-11-27 10:17 [PATCH v2] mtd: sh_flctl: Fix warnings due to improper casts Laurent Pinchart
@ 2013-12-13 18:22 ` Brian Norris
0 siblings, 0 replies; 2+ messages in thread
From: Brian Norris @ 2013-12-13 18:22 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: David Woodhouse, linux-mtd, linux-sh
On Wed, Nov 27, 2013 at 11:17:28AM +0100, Laurent Pinchart wrote:
> Cast pointers to uintptr_t instead of unsigned int. This fixes warnings
> on platforms where pointers have a different size than int.
>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: linux-mtd@lists.infradead.org
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> drivers/mtd/nand/sh_flctl.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Changes compared to v1:
>
> - Cast to uintptr_t instead of unsigned long
This patch has been in l2-mtd.git, but I forgot to alert you. Thanks for
the patch!
Brian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-12-13 18:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-27 10:17 [PATCH v2] mtd: sh_flctl: Fix warnings due to improper casts Laurent Pinchart
2013-12-13 18:22 ` Brian Norris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).