* [PATCH 1/2] mtd: m25p80: Revive dual read support
@ 2014-04-22 12:45 Geert Uytterhoeven
2014-04-22 12:45 ` [PATCH 2/2] mtd: spi-nor: Enable Dual and Quad SPI read transfers for s25sl032p Geert Uytterhoeven
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2014-04-22 12:45 UTC (permalink / raw)
To: Brian Norris; +Cc: linux-mtd, Geert Uytterhoeven, linux-spi
Commit 03e296f613affcc2671c1e86d8c25ecad867204e ("mtd: m25p80: use the SPI
nor framework") accidentally removed support for Dual SPI read transfers.
Add it back.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/mtd/devices/m25p80.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
index 1557d8f672c1..ed7e0a1bed3c 100644
--- a/drivers/mtd/devices/m25p80.c
+++ b/drivers/mtd/devices/m25p80.c
@@ -221,6 +221,8 @@ static int m25p_probe(struct spi_device *spi)
if (spi->mode & SPI_RX_QUAD)
mode = SPI_NOR_QUAD;
+ else if (spi->mode & SPI_RX_DUAL)
+ mode = SPI_NOR_DUAL;
ret = spi_nor_scan(nor, spi_get_device_id(spi), mode);
if (ret)
return ret;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] mtd: spi-nor: Enable Dual and Quad SPI read transfers for s25sl032p
2014-04-22 12:45 [PATCH 1/2] mtd: m25p80: Revive dual read support Geert Uytterhoeven
@ 2014-04-22 12:45 ` Geert Uytterhoeven
2014-05-12 20:22 ` Brian Norris
2014-04-22 15:48 ` [PATCH 1/2] mtd: m25p80: Revive dual read support Huang Shijie
2014-05-12 20:21 ` Brian Norris
2 siblings, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2014-04-22 12:45 UTC (permalink / raw)
To: Brian Norris; +Cc: linux-mtd, Geert Uytterhoeven, linux-spi
Spansion s25sl032p supports Dual and Quad SPI transfers, hence set the
SPI_NOR_DUAL_READ and SPI_NOR_QUAD_READ flags.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Updated for m25p80 -> spi-nor
drivers/mtd/spi-nor/spi-nor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index d6f44d527701..c713c8656710 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -497,7 +497,7 @@ const struct spi_device_id spi_nor_ids[] = {
/* Spansion -- single (large) sector size only, at least
* for the chips listed here (without boot sectors).
*/
- { "s25sl032p", INFO(0x010215, 0x4d00, 64 * 1024, 64, 0) },
+ { "s25sl032p", INFO(0x010215, 0x4d00, 64 * 1024, 64, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
{ "s25sl064p", INFO(0x010216, 0x4d00, 64 * 1024, 128, 0) },
{ "s25fl256s0", INFO(0x010219, 0x4d00, 256 * 1024, 128, 0) },
{ "s25fl256s1", INFO(0x010219, 0x4d01, 64 * 1024, 512, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] mtd: m25p80: Revive dual read support
2014-04-22 12:45 [PATCH 1/2] mtd: m25p80: Revive dual read support Geert Uytterhoeven
2014-04-22 12:45 ` [PATCH 2/2] mtd: spi-nor: Enable Dual and Quad SPI read transfers for s25sl032p Geert Uytterhoeven
@ 2014-04-22 15:48 ` Huang Shijie
2014-05-12 20:21 ` Brian Norris
2 siblings, 0 replies; 5+ messages in thread
From: Huang Shijie @ 2014-04-22 15:48 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Brian Norris, linux-mtd, linux-spi
On Tue, Apr 22, 2014 at 02:45:31PM +0200, Geert Uytterhoeven wrote:
> Commit 03e296f613affcc2671c1e86d8c25ecad867204e ("mtd: m25p80: use the SPI
> nor framework") accidentally removed support for Dual SPI read transfers.
> Add it back.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/mtd/devices/m25p80.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
> index 1557d8f672c1..ed7e0a1bed3c 100644
> --- a/drivers/mtd/devices/m25p80.c
> +++ b/drivers/mtd/devices/m25p80.c
> @@ -221,6 +221,8 @@ static int m25p_probe(struct spi_device *spi)
>
> if (spi->mode & SPI_RX_QUAD)
> mode = SPI_NOR_QUAD;
> + else if (spi->mode & SPI_RX_DUAL)
> + mode = SPI_NOR_DUAL;
> ret = spi_nor_scan(nor, spi_get_device_id(spi), mode);
> if (ret)
> return ret;
sorry for the mistake.
Acked-by: Huang Shijie <shijie8@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] mtd: m25p80: Revive dual read support
2014-04-22 12:45 [PATCH 1/2] mtd: m25p80: Revive dual read support Geert Uytterhoeven
2014-04-22 12:45 ` [PATCH 2/2] mtd: spi-nor: Enable Dual and Quad SPI read transfers for s25sl032p Geert Uytterhoeven
2014-04-22 15:48 ` [PATCH 1/2] mtd: m25p80: Revive dual read support Huang Shijie
@ 2014-05-12 20:21 ` Brian Norris
2 siblings, 0 replies; 5+ messages in thread
From: Brian Norris @ 2014-05-12 20:21 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: linux-mtd, linux-spi
On Tue, Apr 22, 2014 at 02:45:31PM +0200, Geert Uytterhoeven wrote:
> Commit 03e296f613affcc2671c1e86d8c25ecad867204e ("mtd: m25p80: use the SPI
> nor framework") accidentally removed support for Dual SPI read transfers.
> Add it back.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Pushed to l2-mtd.git. Thanks!
Brian
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] mtd: spi-nor: Enable Dual and Quad SPI read transfers for s25sl032p
2014-04-22 12:45 ` [PATCH 2/2] mtd: spi-nor: Enable Dual and Quad SPI read transfers for s25sl032p Geert Uytterhoeven
@ 2014-05-12 20:22 ` Brian Norris
0 siblings, 0 replies; 5+ messages in thread
From: Brian Norris @ 2014-05-12 20:22 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: David Jander, linux-mtd, linux-spi
On Tue, Apr 22, 2014 at 02:45:32PM +0200, Geert Uytterhoeven wrote:
> Spansion s25sl032p supports Dual and Quad SPI transfers, hence set the
> SPI_NOR_DUAL_READ and SPI_NOR_QUAD_READ flags.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Updated for m25p80 -> spi-nor
Pushed to l2-mtd.git. Thanks!
Brian
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-05-12 20:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-22 12:45 [PATCH 1/2] mtd: m25p80: Revive dual read support Geert Uytterhoeven
2014-04-22 12:45 ` [PATCH 2/2] mtd: spi-nor: Enable Dual and Quad SPI read transfers for s25sl032p Geert Uytterhoeven
2014-05-12 20:22 ` Brian Norris
2014-04-22 15:48 ` [PATCH 1/2] mtd: m25p80: Revive dual read support Huang Shijie
2014-05-12 20:21 ` Brian Norris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).