* [PATCH] mtd: rawnand: brcmnand: Fix ecc chunk calculation for erased page bitfips
@ 2019-08-26 19:57 Kamal Dasu
2019-08-29 12:47 ` Miquel Raynal
0 siblings, 1 reply; 2+ messages in thread
From: Kamal Dasu @ 2019-08-26 19:57 UTC (permalink / raw)
To: kdasu.kdev
Cc: Vignesh Raghavendra, Richard Weinberger, linux-kernel,
bcm-kernel-feedback-list, Marek Vasut, Claire Lin, Miquel Raynal,
linux-mtd, Brian Norris, David Woodhouse
From: Claire Lin <claire.lin@broadcom.com>
In brcmstb_nand_verify_erased_page(), fix ecc chunk pointer calculation
while correcting erased page bitflip.
Fixes: 02b88eea9f9c ("mtd: brcmnand: Add check for erased page bitflips")
Signed-off-by: Claire Lin <claire.lin@broadcom.com>
Reviewed-by: Ray Jui <ray.jui@broadcom.com>
Signed-off-by: Kamal Dasu <kdasu.kdev@gmail.com>
---
drivers/mtd/nand/raw/brcmnand/brcmnand.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
index 33310b8..15ef30b 100644
--- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c
+++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
@@ -1792,6 +1792,7 @@ static int brcmstb_nand_verify_erased_page(struct mtd_info *mtd,
int bitflips = 0;
int page = addr >> chip->page_shift;
int ret;
+ void *ecc_chunk;
if (!buf)
buf = nand_get_data_buf(chip);
@@ -1804,7 +1805,9 @@ static int brcmstb_nand_verify_erased_page(struct mtd_info *mtd,
return ret;
for (i = 0; i < chip->ecc.steps; i++, oob += sas) {
- ret = nand_check_erased_ecc_chunk(buf, chip->ecc.size,
+ ecc_chunk = buf + chip->ecc.size * i;
+ ret = nand_check_erased_ecc_chunk(ecc_chunk,
+ chip->ecc.size,
oob, sas, NULL, 0,
chip->ecc.strength);
if (ret < 0)
--
1.9.0.138.g2de3478
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mtd: rawnand: brcmnand: Fix ecc chunk calculation for erased page bitfips
2019-08-26 19:57 [PATCH] mtd: rawnand: brcmnand: Fix ecc chunk calculation for erased page bitfips Kamal Dasu
@ 2019-08-29 12:47 ` Miquel Raynal
0 siblings, 0 replies; 2+ messages in thread
From: Miquel Raynal @ 2019-08-29 12:47 UTC (permalink / raw)
To: Kamal Dasu
Cc: Vignesh Raghavendra, Richard Weinberger, linux-kernel,
Marek Vasut, bcm-kernel-feedback-list, linux-mtd, Miquel Raynal,
Claire Lin, Brian Norris, David Woodhouse
On Mon, 2019-08-26 at 19:57:56 UTC, Kamal Dasu wrote:
> From: Claire Lin <claire.lin@broadcom.com>
>
> In brcmstb_nand_verify_erased_page(), fix ecc chunk pointer calculation
> while correcting erased page bitflip.
>
> Fixes: 02b88eea9f9c ("mtd: brcmnand: Add check for erased page bitflips")
> Signed-off-by: Claire Lin <claire.lin@broadcom.com>
> Reviewed-by: Ray Jui <ray.jui@broadcom.com>
> Signed-off-by: Kamal Dasu <kdasu.kdev@gmail.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-29 12:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-26 19:57 [PATCH] mtd: rawnand: brcmnand: Fix ecc chunk calculation for erased page bitfips Kamal Dasu
2019-08-29 12:47 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).