From: "Rafał Miłecki" <zajec5@gmail.com>
To: Hauke Mehrtens <hauke@hauke-m.de>,
miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com,
robh+dt@kernel.org
Cc: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
rafal@milecki.pl, musashino.open@gmail.com
Subject: Re: [PATCH 2/2] mtd: parsers: trx: Remove dependency to BRCM architectures
Date: Thu, 18 Mar 2021 07:45:04 +0100 [thread overview]
Message-ID: <16aba7dd-63ca-e68c-469f-f21cff75b32e@gmail.com> (raw)
In-Reply-To: <20210315170711.567358-3-hauke@hauke-m.de>
On 15.03.2021 18:07, Hauke Mehrtens wrote:
> Buffalo uses the TRX partition format also on Mediatek SoCs.
>
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---
> drivers/mtd/parsers/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/parsers/Kconfig b/drivers/mtd/parsers/Kconfig
> index d90c30229052..6242903d8844 100644
> --- a/drivers/mtd/parsers/Kconfig
> +++ b/drivers/mtd/parsers/Kconfig
> @@ -96,7 +96,7 @@ config MTD_AFS_PARTS
>
> config MTD_PARSER_TRX
> tristate "Parser for TRX format partitions"
> - depends on MTD && (BCM47XX || ARCH_BCM_5301X || COMPILE_TEST)
> + depends on MTD
> help
> TRX is a firmware format used by Broadcom on their devices. It
> may contain up to 3/4 partitions (depending on the version).
>
Please check Documentation/kbuild/kconfig-language.rst and commit
18084e435ff6 ("Documentation/kbuild: Document platform dependency
practises")
I think you should rather add platform to DEPENDS.
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-03-18 6:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 17:07 [PATCH 0/2] mtd: parsers: trx: Add support for Buffalo WSR-2533DHP2 Hauke Mehrtens
2021-03-15 17:07 ` [PATCH 1/2] mtd: parsers: trx: Allow to specify trx-magic in DT Hauke Mehrtens
2021-03-17 9:25 ` Miquel Raynal
2021-04-18 16:53 ` Hauke Mehrtens
2021-03-18 6:43 ` Rafał Miłecki
2021-04-18 16:59 ` Hauke Mehrtens
2021-03-15 17:07 ` [PATCH 2/2] mtd: parsers: trx: Remove dependency to BRCM architectures Hauke Mehrtens
2021-03-18 6:45 ` Rafał Miłecki [this message]
2021-04-18 17:03 ` Hauke Mehrtens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16aba7dd-63ca-e68c-469f-f21cff75b32e@gmail.com \
--to=zajec5@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=hauke@hauke-m.de \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=musashino.open@gmail.com \
--cc=rafal@milecki.pl \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).