From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Richard Weinberger <richard@nod.at>
Cc: Kees Cook <keescook@chromium.org>,
Boris Brezillon <bbrezillon@kernel.org>,
linux-kernel@vger.kernel.org, Marek Vasut <marek.vasut@gmail.com>,
linux-mtd@lists.infradead.org,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] mtd: cfi_util: mark expected switch fall-throughs
Date: Wed, 20 Mar 2019 16:23:21 -0500 [thread overview]
Message-ID: <1b9c6280-f1dc-2381-59d6-dc29fda3a63b@embeddedor.com> (raw)
In-Reply-To: <3141647.IxSqQhjO87@blindfold>
On 3/20/19 4:05 PM, Richard Weinberger wrote:
> Hi!
>
> Am Mittwoch, 20. März 2019, 21:20:51 CET schrieb Gustavo A. R. Silva:
>> Hi all,
>>
>> Friendly ping:
>>
>> Who can take this?
>
> Hmmm, for MTD I think we can schedule these patches for the next merge window.
> But I'm not sure whether these comments are a good solution.
> I much more prefer the compiler attribute solution.
> Also a tree-wide (sane) coccinelle script would be better IMHO,
> and not zillions of individual patches via different trees.
>
If that script is sophisticated enough to spot both false positives and
actual bugs, then yeah, I'd love that solution. But it's actually not
that simple.
The thing about the compiler attributes is not a big deal, once we
finally enable -Wimplicit-fallthrough, for which we first need to
address each one of these cases. But we are getting close, there
are less than 100 of these issues in linux-next. :)
So, if this is too much of a burden for people, I can add all these
MTD patches to my own tree for 5.2.
Just, please, let me know.
Thanks
--
Gustavo
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-03-20 21:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 18:02 [PATCH] mtd: cfi_util: mark expected switch fall-throughs Gustavo A. R. Silva
2019-03-20 20:20 ` Gustavo A. R. Silva
2019-03-20 21:05 ` Richard Weinberger
2019-03-20 21:23 ` Gustavo A. R. Silva [this message]
2019-03-20 23:25 ` Richard Weinberger
2019-03-20 23:36 ` Gustavo A. R. Silva
2019-04-10 21:16 ` Gustavo A. R. Silva
2019-04-15 8:44 ` Miquel Raynal
2019-04-15 12:57 ` Gustavo A. R. Silva
2019-04-16 17:24 ` Miquel Raynal
2019-04-16 20:49 ` Gustavo A. R. Silva
2019-05-07 14:54 ` Gustavo A. R. Silva
2019-05-07 15:49 ` Richard Weinberger
2019-05-07 15:59 ` Gustavo A. R. Silva
2019-05-09 6:53 ` Miquel Raynal
2019-04-10 21:46 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b9c6280-f1dc-2381-59d6-dc29fda3a63b@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=bbrezillon@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).