* [PATCH] mtd: powernv: SPDX and comment fixups
@ 2019-02-06 0:36 Joel Stanley
2019-02-06 1:08 ` Stewart Smith
2019-02-07 8:37 ` Boris Brezillon
0 siblings, 2 replies; 3+ messages in thread
From: Joel Stanley @ 2019-02-06 0:36 UTC (permalink / raw)
To: David Woodhouse, Brian Norris, Boris Brezillon, Marek Vasut,
Richard Weinberger
Cc: Michael Ellerman, linux-mtd, linuxppc-dev
This converts the powernv flash driver to use SPDX, and adds some
clarifying comments that came out of a discussion on how the mtd driver
works.
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
drivers/mtd/devices/powernv_flash.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/mtd/devices/powernv_flash.c b/drivers/mtd/devices/powernv_flash.c
index 22f753e555ac..0bf43336c3f7 100644
--- a/drivers/mtd/devices/powernv_flash.c
+++ b/drivers/mtd/devices/powernv_flash.c
@@ -1,17 +1,9 @@
+// SPDX-License-Identifier: GPL-2.0+
+
/*
* OPAL PNOR flash MTD abstraction
*
* Copyright IBM 2015
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
*/
#include <linux/kernel.h>
@@ -261,6 +253,14 @@ static int powernv_flash_probe(struct platform_device *pdev)
* The current flash that skiboot exposes is one contiguous flash chip
* with an ffs partition at the start, it should prove easier for users
* to deal with partitions or not as they see fit
+ *
+ * When developing the skiboot MTD driver an experiment with FFS
+ * parsing in the kernel, and exposing a seperate /dev/mtdX for each
+ * partition (eg BOOTKERNEL, PAYLOAD, NVRAM, etc), was done.
+ *
+ * We didn't go with that as it meant users couldn't do a full flash
+ * re-write, as this can cause a partition to change size, and there
+ * wasn't a way to tell the MTD layer that a device has shrunk/grown.
*/
return mtd_device_register(&data->mtd, NULL, 0);
}
--
2.20.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: powernv: SPDX and comment fixups
2019-02-06 0:36 [PATCH] mtd: powernv: SPDX and comment fixups Joel Stanley
@ 2019-02-06 1:08 ` Stewart Smith
2019-02-07 8:37 ` Boris Brezillon
1 sibling, 0 replies; 3+ messages in thread
From: Stewart Smith @ 2019-02-06 1:08 UTC (permalink / raw)
To: Joel Stanley, David Woodhouse, Brian Norris, Boris Brezillon,
Marek Vasut, Richard Weinberger
Cc: linuxppc-dev, linux-mtd
Joel Stanley <joel@jms.id.au> writes:
> converts the powernv flash driver to use SPDX, and adds some
> clarifying comments that came out of a discussion on how the mtd driver
> works.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
We probably don't need to mention the dim dark corners of the FFS format
and I kind of wish it'd die rather than spread further.
Reviewed-by: Stewart Smith <stewart@linux.ibm.com>
--
Stewart Smith
OPAL Architect, IBM.
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: powernv: SPDX and comment fixups
2019-02-06 0:36 [PATCH] mtd: powernv: SPDX and comment fixups Joel Stanley
2019-02-06 1:08 ` Stewart Smith
@ 2019-02-07 8:37 ` Boris Brezillon
1 sibling, 0 replies; 3+ messages in thread
From: Boris Brezillon @ 2019-02-07 8:37 UTC (permalink / raw)
To: Joel Stanley
Cc: Michael Ellerman, linuxppc-dev, Marek Vasut, linux-mtd,
Richard Weinberger, Brian Norris, David Woodhouse
Hello Joel,
On Wed, 6 Feb 2019 11:06:58 +1030
Joel Stanley <joel@jms.id.au> wrote:
> This converts the powernv flash driver to use SPDX, and adds some
> clarifying comments that came out of a discussion on how the mtd driver
> works.
Can you split that in 2 patches, one adding the SPDX header, and the
other one clarifying the driver behavior.
Thanks,
Boris
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> drivers/mtd/devices/powernv_flash.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/mtd/devices/powernv_flash.c b/drivers/mtd/devices/powernv_flash.c
> index 22f753e555ac..0bf43336c3f7 100644
> --- a/drivers/mtd/devices/powernv_flash.c
> +++ b/drivers/mtd/devices/powernv_flash.c
> @@ -1,17 +1,9 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +
> /*
> * OPAL PNOR flash MTD abstraction
> *
> * Copyright IBM 2015
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License as published by
> - * the Free Software Foundation; either version 2 of the License, or
> - * (at your option) any later version.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> - * GNU General Public License for more details.
> */
>
> #include <linux/kernel.h>
> @@ -261,6 +253,14 @@ static int powernv_flash_probe(struct platform_device *pdev)
> * The current flash that skiboot exposes is one contiguous flash chip
> * with an ffs partition at the start, it should prove easier for users
> * to deal with partitions or not as they see fit
> + *
> + * When developing the skiboot MTD driver an experiment with FFS
> + * parsing in the kernel, and exposing a seperate /dev/mtdX for each
> + * partition (eg BOOTKERNEL, PAYLOAD, NVRAM, etc), was done.
> + *
> + * We didn't go with that as it meant users couldn't do a full flash
> + * re-write, as this can cause a partition to change size, and there
> + * wasn't a way to tell the MTD layer that a device has shrunk/grown.
> */
> return mtd_device_register(&data->mtd, NULL, 0);
> }
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-07 8:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-06 0:36 [PATCH] mtd: powernv: SPDX and comment fixups Joel Stanley
2019-02-06 1:08 ` Stewart Smith
2019-02-07 8:37 ` Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).