Linux-mtd Archive on lore.kernel.org
 help / Atom feed
* [PATCH v2] mtd: spi-nor: Fix wrong abbreviation HWCPAS
@ 2019-02-08 14:23 Bean Huo (beanhuo)
  2019-02-08 14:43 ` Tudor.Ambarus
  0 siblings, 1 reply; 11+ messages in thread
From: Bean Huo (beanhuo) @ 2019-02-08 14:23 UTC (permalink / raw)
  To: Tudor.Ambarus, linux-mtd, linux-kernel
  Cc: bbrezillon, richard, marek.vasut, computersforpeace, dwmw2,
	Bean Huo \(beanhuo\)

Change SNOR_HWCPAS_READ_OCTAL to SNOR_HWCAPS_READ_OCTAL.

Signed-off-by: Bean Huo <beanhuo@micron.com>
---
 include/linux/mtd/spi-nor.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/mtd/spi-nor.h b/include/linux/mtd/spi-nor.h
index 2353af8..b3d360b 100644
--- a/include/linux/mtd/spi-nor.h
+++ b/include/linux/mtd/spi-nor.h
@@ -487,7 +487,7 @@ struct spi_nor_hwcaps {
 #define SNOR_HWCAPS_READ_4_4_4		BIT(9)
 #define SNOR_HWCAPS_READ_1_4_4_DTR	BIT(10)
 
-#define SNOR_HWCPAS_READ_OCTAL		GENMASK(14, 11)
+#define SNOR_HWCAPS_READ_OCTAL		GENMASK(14, 11)
 #define SNOR_HWCAPS_READ_1_1_8		BIT(11)
 #define SNOR_HWCAPS_READ_1_8_8		BIT(12)
 #define SNOR_HWCAPS_READ_8_8_8		BIT(13)
-- 
2.7.4

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v2] mtd: spi-nor: Fix wrong abbreviation HWCPAS
  2019-02-08 14:23 [PATCH v2] mtd: spi-nor: Fix wrong abbreviation HWCPAS Bean Huo (beanhuo)
@ 2019-02-08 14:43 ` Tudor.Ambarus
  2019-02-08 15:07   ` [EXT] " Bean Huo (beanhuo)
  2019-02-08 15:27   ` Bean Huo (beanhuo)
  0 siblings, 2 replies; 11+ messages in thread
From: Tudor.Ambarus @ 2019-02-08 14:43 UTC (permalink / raw)
  To: beanhuo, linux-mtd, linux-kernel
  Cc: marek.vasut, computersforpeace, dwmw2, richard, bbrezillon


On 02/08/2019 04:23 PM, Bean Huo (beanhuo) wrote:
> Change SNOR_HWCPAS_READ_OCTAL to SNOR_HWCAPS_READ_OCTAL.
> 
> Signed-off-by: Bean Huo <beanhuo@micron.com>

$ ./scripts/checkpatch.pl --strict
v2-mtd-spi-nor-Fix-wrong-abbreviation-HWCPAS.patch
WARNING: Missing Signed-off-by: line by nominal patch author 'Bean Huo (beanhuo)
<beanhuo@micron.com>'

There are scripts that check that the author/committer has its SoB, depending on
how strict the check is, it might complaint that SoB an author/committer do not
match, so please change gitconfig to make them match.

> ---
>  include/linux/mtd/spi-nor.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/mtd/spi-nor.h b/include/linux/mtd/spi-nor.h
> index 2353af8..b3d360b 100644
> --- a/include/linux/mtd/spi-nor.h
> +++ b/include/linux/mtd/spi-nor.h
> @@ -487,7 +487,7 @@ struct spi_nor_hwcaps {
>  #define SNOR_HWCAPS_READ_4_4_4		BIT(9)
>  #define SNOR_HWCAPS_READ_1_4_4_DTR	BIT(10)
>  
> -#define SNOR_HWCPAS_READ_OCTAL		GENMASK(14, 11)
> +#define SNOR_HWCAPS_READ_OCTAL		GENMASK(14, 11)
>  #define SNOR_HWCAPS_READ_1_1_8		BIT(11)
>  #define SNOR_HWCAPS_READ_1_8_8		BIT(12)
>  #define SNOR_HWCAPS_READ_8_8_8		BIT(13)
> 
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 11+ messages in thread

* RE: [EXT] Re: [PATCH v2] mtd: spi-nor: Fix wrong abbreviation HWCPAS
  2019-02-08 14:43 ` Tudor.Ambarus
@ 2019-02-08 15:07   ` " Bean Huo (beanhuo)
  2019-02-08 15:27   ` Bean Huo (beanhuo)
  1 sibling, 0 replies; 11+ messages in thread
From: Bean Huo (beanhuo) @ 2019-02-08 15:07 UTC (permalink / raw)
  To: Tudor.Ambarus, linux-mtd, linux-kernel
  Cc: marek.vasut, computersforpeace, dwmw2, bbrezillon, richard

Hi, Tudor

./scripts/checkpatch.pl --strict 0001-mtd-spi-nor-Fix-wrong-abbreviation-HWCPAS.patch 
total: 0 errors, 0 warnings, 0 checks, 8 lines checked

0001-mtd-spi-nor-Fix-wrong-abbreviation-HWCPAS.patch has no obvious style problems and is ready for submission.

>
>On 02/08/2019 04:23 PM, Bean Huo (beanhuo) wrote:
>> Change SNOR_HWCPAS_READ_OCTAL to SNOR_HWCAPS_READ_OCTAL.
>>
>> Signed-off-by: Bean Huo <beanhuo@micron.com>
>
>$ ./scripts/checkpatch.pl --strict
>v2-mtd-spi-nor-Fix-wrong-abbreviation-HWCPAS.patch
>WARNING: Missing Signed-off-by: line by nominal patch author 'Bean Huo
>(beanhuo) <beanhuo@micron.com>'
> 
'Bean Huo (beanhuo) <beanhuo@micron.com>' is wrong.
 If you prefer to 'Bean Huo (beanhuo) <beanhuo@micron.com>, would you please change that.

//Bean

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 11+ messages in thread

* RE: [EXT] Re: [PATCH v2] mtd: spi-nor: Fix wrong abbreviation HWCPAS
  2019-02-08 14:43 ` Tudor.Ambarus
  2019-02-08 15:07   ` [EXT] " Bean Huo (beanhuo)
@ 2019-02-08 15:27   ` Bean Huo (beanhuo)
  2019-02-08 15:51     ` Tudor.Ambarus
  1 sibling, 1 reply; 11+ messages in thread
From: Bean Huo (beanhuo) @ 2019-02-08 15:27 UTC (permalink / raw)
  To: Tudor.Ambarus, linux-mtd, linux-kernel
  Cc: marek.vasut, computersforpeace, dwmw2, bbrezillon, richard

Hi, Tutor

>$ ./scripts/checkpatch.pl --strict
>v2-mtd-spi-nor-Fix-wrong-abbreviation-HWCPAS.patch
>WARNING: Missing Signed-off-by: line by nominal patch author 'Bean Huo
>(beanhuo) <beanhuo@micron.com>'
>
I think, this is because of our email system, it always adds '(xxx)' between user name 
and email address.
If you are convenient, please help fix since it is not such hug change.
Thanks,
//Bean

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [EXT] Re: [PATCH v2] mtd: spi-nor: Fix wrong abbreviation HWCPAS
  2019-02-08 15:27   ` Bean Huo (beanhuo)
@ 2019-02-08 15:51     ` Tudor.Ambarus
  2019-02-08 17:13       ` Bean Huo (beanhuo)
  0 siblings, 1 reply; 11+ messages in thread
From: Tudor.Ambarus @ 2019-02-08 15:51 UTC (permalink / raw)
  To: beanhuo, linux-mtd, linux-kernel
  Cc: marek.vasut, computersforpeace, dwmw2, bbrezillon, richard

Hi, Bean,

On 02/08/2019 05:27 PM, Bean Huo (beanhuo) wrote:
> Hi, Tutor
> 
>> $ ./scripts/checkpatch.pl --strict
>> v2-mtd-spi-nor-Fix-wrong-abbreviation-HWCPAS.patch
>> WARNING: Missing Signed-off-by: line by nominal patch author 'Bean Huo
>> (beanhuo) <beanhuo@micron.com>'
>>
> I think, this is because of our email system, it always adds '(xxx)' between user name 
> and email address.
> If you are convenient, please help fix since it is not such hug change.

I'm on a funny email server too, it keeps overwriting my email header "from
field". I have a workaround that might work for you too. Here's part of my
.gitconfig:

[user]
        name = Tudor Ambarus
        email = tudor.ambarus@microchip.com
[sendemail]
        from = Tudor X Ambarus <tudor.ambarus@microchip.com>

Because my [sendemail] from field is different than my [user] name and email,
git send-email will add in the body of the patch the [user] name and email:

From: Tudor Ambarus <tudor.ambarus@microchip.com>

When the patch is applied, it takes the author name from the patch body. Even if
the server overwrites the from field from the header, it will be ignored.

Let me know if this works for you.
ta
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 11+ messages in thread

* RE: [EXT] Re: [PATCH v2] mtd: spi-nor: Fix wrong abbreviation HWCPAS
  2019-02-08 15:51     ` Tudor.Ambarus
@ 2019-02-08 17:13       ` Bean Huo (beanhuo)
  2019-02-08 17:47         ` Boris Brezillon
  0 siblings, 1 reply; 11+ messages in thread
From: Bean Huo (beanhuo) @ 2019-02-08 17:13 UTC (permalink / raw)
  To: Tudor.Ambarus, linux-mtd, linux-kernel
  Cc: marek.vasut, computersforpeace, dwmw2, richard, bbrezillon

Hi, Tutor
Thanks. unfortunately, it doesn't work on my side. Problem is on our email server side, not my local setting.
I followed your configuration, then git-email failed.
Please just change my S-o-b to 'Bean Huo (beanhuo) <beanhuo@micron.com>' in my patch to please checkpacth.pl.  It is not huge change. 
Thanks,

>
>On 02/08/2019 05:27 PM, Bean Huo (beanhuo) wrote:
>> Hi, Tutor
>>
>>> $ ./scripts/checkpatch.pl --strict
>>> v2-mtd-spi-nor-Fix-wrong-abbreviation-HWCPAS.patch
>>> WARNING: Missing Signed-off-by: line by nominal patch author 'Bean
>>> Huo
>>> (beanhuo) <beanhuo@micron.com>'
>>>
>> I think, this is because of our email system, it always adds '(xxx)'
>> between user name and email address.
>> If you are convenient, please help fix since it is not such hug change.
>
>I'm on a funny email server too, it keeps overwriting my email header "from field".
>I have a workaround that might work for you too. Here's part of my
>.gitconfig:
>
>[user]
>        name = Tudor Ambarus
>        email = tudor.ambarus@microchip.com [sendemail]
>        from = Tudor X Ambarus <tudor.ambarus@microchip.com>
>
>Because my [sendemail] from field is different than my [user] name and email, git
>send-email will add in the body of the patch the [user] name and email:
>
>From: Tudor Ambarus <tudor.ambarus@microchip.com>
>
>When the patch is applied, it takes the author name from the patch body. Even if
>the server overwrites the from field from the header, it will be ignored.
>
>Let me know if this works for you.
>ta
>______________________________________________________
>Linux MTD discussion mailing list
>http://lists.infradead.org/mailman/listinfo/linux-mtd/

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [EXT] Re: [PATCH v2] mtd: spi-nor: Fix wrong abbreviation HWCPAS
  2019-02-08 17:13       ` Bean Huo (beanhuo)
@ 2019-02-08 17:47         ` Boris Brezillon
  2019-02-08 18:43           ` Bean Huo (beanhuo)
  0 siblings, 1 reply; 11+ messages in thread
From: Boris Brezillon @ 2019-02-08 17:47 UTC (permalink / raw)
  To: Bean Huo (beanhuo)
  Cc: Tudor.Ambarus, richard, linux-kernel, marek.vasut, linux-mtd,
	computersforpeace, dwmw2

Hi Bean,

On Fri, 8 Feb 2019 17:13:52 +0000
"Bean Huo (beanhuo)" <beanhuo@micron.com> wrote:

> Hi, Tutor
> Thanks. unfortunately, it doesn't work on my side. Problem is on our email server side, not my local setting.
> I followed your configuration, then git-email failed.

Can you paste the output of git send-email and the [sendemail] section
of your .gitconfig so we can check.
It shouldn't fail, really, because the server shouldn't check the body
section of your email, and this is where the extra

	From: First Last <foo@bar.com>

line is placed.

> Please just change my S-o-b to 'Bean Huo (beanhuo) <beanhuo@micron.com>' in my patch to please checkpacth.pl.  It is not huge change.

It's not a problem when an drive-by contributor posts a patch, but if
you don't patch it that means we'll have to do it manually every time
we apply one of your patch, so please find a solution.

Thanks,

Boris

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 11+ messages in thread

* RE: [EXT] Re: [PATCH v2] mtd: spi-nor: Fix wrong abbreviation HWCPAS
  2019-02-08 17:47         ` Boris Brezillon
@ 2019-02-08 18:43           ` Bean Huo (beanhuo)
  2019-02-08 18:46             ` Marek Vasut
  2019-02-08 18:50             ` Boris Brezillon
  0 siblings, 2 replies; 11+ messages in thread
From: Bean Huo (beanhuo) @ 2019-02-08 18:43 UTC (permalink / raw)
  To: Boris Brezillon
  Cc: Tudor.Ambarus, richard, linux-kernel, marek.vasut, linux-mtd,
	computersforpeace, dwmw2

Hi,Boris 
I sent three times, seems last time is successful. would you check that is correct?

git send-email 0001-mtd-spi-nor-Fix-wrong-abbreviation-HWCPAS.patch
0001-mtd-spi-nor-Fix-wrong-abbreviation-HWCPAS.patch
To whom should the emails be sent (if anyone)? linux-mtd@lists.infradead.org,Tudor.Ambarus@microchip.com,bbrezillon@kernel.org,linux-kernel@vger.kernel.org
Message-ID to be used as In-Reply-To for the first email (if any)? 
(mbox) Adding cc: Bean Huo <beanhuo@micron.com> from line 'From: Bean Huo <beanhuo@micron.com>'
(body) Adding cc: Bean Huo <beanhuo@micron.com> from line 'Signed-off-by: Bean Huo <beanhuo@micron.com>'

From: Bean Huo <beanhuo@micron.com>
To: linux-mtd@lists.infradead.org,
        Tudor.Ambarus@microchip.com,
        bbrezillon@kernel.org,
        linux-kernel@vger.kernel.org
Cc: Bean Huo <beanhuo@micron.com>
Subject: [PATCH] mtd: spi-nor: Fix wrong abbreviation HWCPAS
Date: Fri,  8 Feb 2019 18:00:12 +0000
Message-Id: <20190208180012.25852-1-beanhuo@micron.com>
X-Mailer: git-send-email 2.17.1

    The Cc list above has been expanded by additional
    addresses found in the patch commit message. By default
    send-email prompts before sending whenever this occurs.
    This behavior is controlled by the sendemail.confirm
    configuration setting.

    For additional information, run 'git send-email --help'.
    To retain the current behavior, but squelch this message,
    run 'git config --global sendemail.confirm auto'.

Send this email? ([y]es|[n]o|[q]uit|[a]ll): y
OK. Log says:
Sendmail: /usr/sbin/sendmail -i linux-mtd@lists.infradead.org Tudor.Ambarus@microchip.com bbrezillon@kernel.org linux-kernel@vger.kernel.org beanhuo@micron.com
From: Bean Huo <beanhuo@micron.com>
To: linux-mtd@lists.infradead.org,
        Tudor.Ambarus@microchip.com,
        bbrezillon@kernel.org,
        linux-kernel@vger.kernel.org
Cc: Bean Huo <beanhuo@micron.com>
Subject: [RESEND PATCH v2] mtd: spi-nor: Fix wrong abbreviation HWCPAS
Date: Fri,  8 Feb 2019 18:00:12 +0000
Message-Id: <20190208180012.25852-1-beanhuo@micron.com>
X-Mailer: git-send-email 2.17.1

Result: OK

>
>Hi Bean,
>
>On Fri, 8 Feb 2019 17:13:52 +0000
>"Bean Huo (beanhuo)" <beanhuo@micron.com> wrote:
>
>> Hi, Tutor
>> Thanks. unfortunately, it doesn't work on my side. Problem is on our email
>server side, not my local setting.
>> I followed your configuration, then git-email failed.
>
>Can you paste the output of git send-email and the [sendemail] section of
>your .gitconfig so we can check.
>It shouldn't fail, really, because the server shouldn't check the body section of
>your email, and this is where the extra
>
>	From: First Last <foo@bar.com>
>
>line is placed.
>
>> Please just change my S-o-b to 'Bean Huo (beanhuo) <beanhuo@micron.com>'
>in my patch to please checkpacth.pl.  It is not huge change.
>
>It's not a problem when an drive-by contributor posts a patch, but if you don't
>patch it that means we'll have to do it manually every time we apply one of your
>patch, so please find a solution.
>
>Thanks,
>
>Boris

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [EXT] Re: [PATCH v2] mtd: spi-nor: Fix wrong abbreviation HWCPAS
  2019-02-08 18:43           ` Bean Huo (beanhuo)
@ 2019-02-08 18:46             ` Marek Vasut
  2019-02-08 18:57               ` Bean Huo (beanhuo)
  2019-02-08 18:50             ` Boris Brezillon
  1 sibling, 1 reply; 11+ messages in thread
From: Marek Vasut @ 2019-02-08 18:46 UTC (permalink / raw)
  To: Bean Huo (beanhuo), Boris Brezillon
  Cc: Tudor.Ambarus, richard, linux-kernel, linux-mtd,
	computersforpeace, dwmw2

On 2/8/19 7:43 PM, Bean Huo (beanhuo) wrote:
> Hi,Boris 
> I sent three times, seems last time is successful. would you check that is correct?
> 
> git send-email 0001-mtd-spi-nor-Fix-wrong-abbreviation-HWCPAS.patch
> 0001-mtd-spi-nor-Fix-wrong-abbreviation-HWCPAS.patch

git send-email --annotate --to=... --cc=... --cc=... 000*patch

This will likely make your life easier, rather than having to paste
various email addresses to git send-email queries.

[...]

-- 
Best regards,
Marek Vasut

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [EXT] Re: [PATCH v2] mtd: spi-nor: Fix wrong abbreviation HWCPAS
  2019-02-08 18:43           ` Bean Huo (beanhuo)
  2019-02-08 18:46             ` Marek Vasut
@ 2019-02-08 18:50             ` Boris Brezillon
  1 sibling, 0 replies; 11+ messages in thread
From: Boris Brezillon @ 2019-02-08 18:50 UTC (permalink / raw)
  To: Bean Huo (beanhuo)
  Cc: Tudor.Ambarus, richard, linux-kernel, marek.vasut, linux-mtd,
	computersforpeace, dwmw2

On Fri, 8 Feb 2019 18:43:26 +0000
"Bean Huo (beanhuo)" <beanhuo@micron.com> wrote:

> Hi,Boris 
> I sent three times, seems last time is successful. would you check that is correct?

That's much better now, thanks!

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 11+ messages in thread

* RE: [EXT] Re: [PATCH v2] mtd: spi-nor: Fix wrong abbreviation HWCPAS
  2019-02-08 18:46             ` Marek Vasut
@ 2019-02-08 18:57               ` Bean Huo (beanhuo)
  0 siblings, 0 replies; 11+ messages in thread
From: Bean Huo (beanhuo) @ 2019-02-08 18:57 UTC (permalink / raw)
  To: Marek Vasut
  Cc: Tudor.Ambarus, richard, Boris Brezillon, linux-kernel, linux-mtd,
	computersforpeace, dwmw2

>> git send-email 0001-mtd-spi-nor-Fix-wrong-abbreviation-HWCPAS.patch
>> 0001-mtd-spi-nor-Fix-wrong-abbreviation-HWCPAS.patch
>
>git send-email --annotate --to=... --cc=... --cc=... 000*patch
>
>This will likely make your life easier, rather than having to paste various email
>addresses to git send-email queries.
>
Yes, thanks.

>[...]
>
>--
>Best regards,
>Marek Vasut
>
>______________________________________________________
>Linux MTD discussion mailing list
>http://lists.infradead.org/mailman/listinfo/linux-mtd/

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, back to index

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-08 14:23 [PATCH v2] mtd: spi-nor: Fix wrong abbreviation HWCPAS Bean Huo (beanhuo)
2019-02-08 14:43 ` Tudor.Ambarus
2019-02-08 15:07   ` [EXT] " Bean Huo (beanhuo)
2019-02-08 15:27   ` Bean Huo (beanhuo)
2019-02-08 15:51     ` Tudor.Ambarus
2019-02-08 17:13       ` Bean Huo (beanhuo)
2019-02-08 17:47         ` Boris Brezillon
2019-02-08 18:43           ` Bean Huo (beanhuo)
2019-02-08 18:46             ` Marek Vasut
2019-02-08 18:57               ` Bean Huo (beanhuo)
2019-02-08 18:50             ` Boris Brezillon

Linux-mtd Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mtd/0 linux-mtd/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mtd linux-mtd/ https://lore.kernel.org/linux-mtd \
		linux-mtd@lists.infradead.org linux-mtd@archiver.kernel.org
	public-inbox-index linux-mtd


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-mtd


AGPL code for this site: git clone https://public-inbox.org/ public-inbox