* [PATCH V4] mtd: spi-nor: split s25fl128s into s25fl128s0 and s25fl128s1
@ 2019-02-12 6:24 A. Celenk
2019-02-12 8:06 ` Tudor.Ambarus
2019-02-14 13:00 ` [V4] " Boris Brezillon
0 siblings, 2 replies; 3+ messages in thread
From: A. Celenk @ 2019-02-12 6:24 UTC (permalink / raw)
To: linux-mtd; +Cc: Boris Brezillon, Ahmet Celenk, Marek Vasut
From: "Ahmet Celenk" <ahmet.celenk@procenne.com>
Due to two different versions (S25FL128SAGBHI200 and S25FL128SAGBHI210) of
the s25fl128s qspi memory, the single "s25fl128s" device entry must be
split into two to match the correct JEDEC ID's for each version. Solves
paging related issues of S25FL128SAGBHI210 chips.
Signed-off-by: Ahmet Celenk <ahmet.celenk@procenne.com>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Marek Vasut <marek.vasut@gmail.com>
---
V4: Broke the over-80-column lines and put entries alphabetically into
the list
V3: Added missing SPI_NOR_DUAL_READ flags to new entries
V2: Removed the old s25fl128s entry
V1: Added 2 two splitted entries
---
drivers/mtd/spi-nor/spi-nor.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index f9f7de2..6e5b591 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -1893,6 +1893,10 @@ static const struct flash_info spi_nor_ids[] = {
*/
{ "s25sl032p", INFO(0x010215, 0x4d00, 64 * 1024, 64, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
{ "s25sl064p", INFO(0x010216, 0x4d00, 64 * 1024, 128, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
+ { "s25fl128s0", INFO6(0x012018, 0x4d0080, 256 * 1024, 64,
+ SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_CLSR) },
+ { "s25fl128s1", INFO6(0x012018, 0x4d0180, 64 * 1024, 256,
+ SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_CLSR) },
{ "s25fl256s0", INFO(0x010219, 0x4d00, 256 * 1024, 128, USE_CLSR) },
{ "s25fl256s1", INFO(0x010219, 0x4d01, 64 * 1024, 512, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_CLSR) },
{ "s25fl512s", INFO6(0x010220, 0x4d0080, 256 * 1024, 256, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_CLSR) },
@@ -1900,7 +1904,6 @@ static const struct flash_info spi_nor_ids[] = {
{ "s70fl01gs", INFO(0x010221, 0x4d00, 256 * 1024, 256, 0) },
{ "s25sl12800", INFO(0x012018, 0x0300, 256 * 1024, 64, 0) },
{ "s25sl12801", INFO(0x012018, 0x0301, 64 * 1024, 256, 0) },
- { "s25fl128s", INFO6(0x012018, 0x4d0180, 64 * 1024, 256, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_CLSR) },
{ "s25fl129p0", INFO(0x012018, 0x4d00, 256 * 1024, 64, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_CLSR) },
{ "s25fl129p1", INFO(0x012018, 0x4d01, 64 * 1024, 256, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_CLSR) },
{ "s25sl004a", INFO(0x010212, 0, 64 * 1024, 8, 0) },
--
2.7.4
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH V4] mtd: spi-nor: split s25fl128s into s25fl128s0 and s25fl128s1
2019-02-12 6:24 [PATCH V4] mtd: spi-nor: split s25fl128s into s25fl128s0 and s25fl128s1 A. Celenk
@ 2019-02-12 8:06 ` Tudor.Ambarus
2019-02-14 13:00 ` [V4] " Boris Brezillon
1 sibling, 0 replies; 3+ messages in thread
From: Tudor.Ambarus @ 2019-02-12 8:06 UTC (permalink / raw)
To: ahmet.celenk, linux-mtd; +Cc: boris.brezillon, marek.vasut
On 02/12/2019 08:24 AM, A. Celenk wrote:
> From: "Ahmet Celenk" <ahmet.celenk@procenne.com>
>
> Due to two different versions (S25FL128SAGBHI200 and S25FL128SAGBHI210) of
> the s25fl128s qspi memory, the single "s25fl128s" device entry must be
> split into two to match the correct JEDEC ID's for each version. Solves
> paging related issues of S25FL128SAGBHI210 chips.
>
> Signed-off-by: Ahmet Celenk <ahmet.celenk@procenne.com>
Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
> Cc: Marek Vasut <marek.vasut@gmail.com>
> ---
> V4: Broke the over-80-column lines and put entries alphabetically into
> the list
> V3: Added missing SPI_NOR_DUAL_READ flags to new entries
> V2: Removed the old s25fl128s entry
> V1: Added 2 two splitted entries
> ---
> drivers/mtd/spi-nor/spi-nor.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index f9f7de2..6e5b591 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -1893,6 +1893,10 @@ static const struct flash_info spi_nor_ids[] = {
> */
> { "s25sl032p", INFO(0x010215, 0x4d00, 64 * 1024, 64, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> { "s25sl064p", INFO(0x010216, 0x4d00, 64 * 1024, 128, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> + { "s25fl128s0", INFO6(0x012018, 0x4d0080, 256 * 1024, 64,
> + SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_CLSR) },
> + { "s25fl128s1", INFO6(0x012018, 0x4d0180, 64 * 1024, 256,
> + SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_CLSR) },
> { "s25fl256s0", INFO(0x010219, 0x4d00, 256 * 1024, 128, USE_CLSR) },
> { "s25fl256s1", INFO(0x010219, 0x4d01, 64 * 1024, 512, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_CLSR) },
> { "s25fl512s", INFO6(0x010220, 0x4d0080, 256 * 1024, 256, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_CLSR) },
> @@ -1900,7 +1904,6 @@ static const struct flash_info spi_nor_ids[] = {
> { "s70fl01gs", INFO(0x010221, 0x4d00, 256 * 1024, 256, 0) },
> { "s25sl12800", INFO(0x012018, 0x0300, 256 * 1024, 64, 0) },
> { "s25sl12801", INFO(0x012018, 0x0301, 64 * 1024, 256, 0) },
> - { "s25fl128s", INFO6(0x012018, 0x4d0180, 64 * 1024, 256, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_CLSR) },
> { "s25fl129p0", INFO(0x012018, 0x4d00, 256 * 1024, 64, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_CLSR) },
> { "s25fl129p1", INFO(0x012018, 0x4d01, 64 * 1024, 256, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_CLSR) },
> { "s25sl004a", INFO(0x010212, 0, 64 * 1024, 8, 0) },
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [V4] mtd: spi-nor: split s25fl128s into s25fl128s0 and s25fl128s1
2019-02-12 6:24 [PATCH V4] mtd: spi-nor: split s25fl128s into s25fl128s0 and s25fl128s1 A. Celenk
2019-02-12 8:06 ` Tudor.Ambarus
@ 2019-02-14 13:00 ` Boris Brezillon
1 sibling, 0 replies; 3+ messages in thread
From: Boris Brezillon @ 2019-02-14 13:00 UTC (permalink / raw)
To: A. Celenk, linux-mtd; +Cc: Boris Brezillon, Marek Vasut, Boris Brezillon
From: Boris Brezillon <bbrezillon@kernel.org>
On Tue, 2019-02-12 at 06:24:42 UTC, "A. Celenk" wrote:
> From: "Ahmet Celenk" <ahmet.celenk@procenne.com>
>
> Due to two different versions (S25FL128SAGBHI200 and S25FL128SAGBHI210) of
> the s25fl128s qspi memory, the single "s25fl128s" device entry must be
> split into two to match the correct JEDEC ID's for each version. Solves
> paging related issues of S25FL128SAGBHI210 chips.
>
> Signed-off-by: Ahmet Celenk <ahmet.celenk@procenne.com>
> Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
> Cc: Marek Vasut <marek.vasut@gmail.com>
> Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Applied to http://git.infradead.org/linux-mtd.git spi-nor/next, thanks.
Boris
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-14 13:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-12 6:24 [PATCH V4] mtd: spi-nor: split s25fl128s into s25fl128s0 and s25fl128s1 A. Celenk
2019-02-12 8:06 ` Tudor.Ambarus
2019-02-14 13:00 ` [V4] " Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).